From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>,
"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
"Johnson Wang (王聖鑫)" <Johnson.Wang@mediatek.com>,
"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Elvis Wang (王军)" <Elvis.Wang@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH 02/15] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id
Date: Mon, 25 Sep 2023 08:42:11 +0200 [thread overview]
Message-ID: <e69ca292-e0b9-4ee2-9f4e-6e9300a636a6@linaro.org> (raw)
In-Reply-To: <1f324b04cbd8faa7510a3519eb718c0be25af2be.camel@mediatek.com>
On 25/09/2023 07:05, Jason-JH Lin (林睿祥) wrote:
> Hi Krzysztof,
>
> Thanks for the reviews.
>
> On Sat, 2023-09-23 at 20:01 +0200, Krzysztof Kozlowski wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>> On 18/09/2023 21:21, Jason-JH.Lin wrote:
>>> CMDQ_SYNC_TOKEN_SECURE_THR_EOF is used as secure irq to notify CMDQ
>>> driver in the normal world that GCE secure thread has completed a
>> task
>>> in thee secure world.
>>
>> How can #define be added after its usage? Does it even make any sense
>> of
>> being separate patch?
>>
>
> This definition is used in the mt8195.dts at [PATCH 15/15] and the CMDQ
No, the define is used in previous patch, which means your patchset is
not bisectable and not tested.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-25 6:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230918192204.32263-1-jason-jh.lin@mediatek.com>
[not found] ` <20230918192204.32263-12-jason-jh.lin@mediatek.com>
2023-09-19 3:04 ` [PATCH 11/15] soc: mediatek: Add cmdq_insert_backup_cookie before EOC for secure pkt CK Hu (胡俊光)
2023-09-21 14:28 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-2-jason-jh.lin@mediatek.com>
2023-09-19 16:46 ` [PATCH 01/15] dt-bindings: mailbox: Add property for CMDQ secure driver Rob Herring
2023-09-21 15:12 ` Jason-JH Lin (林睿祥)
2023-09-20 3:08 ` [PATCH 00/15] Add CMDQ secure driver for SVP CK Hu (胡俊光)
2023-09-21 14:44 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-3-jason-jh.lin@mediatek.com>
2023-09-23 18:01 ` [PATCH 02/15] dt-bindings: gce: mt8195: Add CMDQ_SYNC_TOKEN_SECURE_THR_EOF event id Krzysztof Kozlowski
2023-09-25 5:05 ` Jason-JH Lin (林睿祥)
2023-09-25 6:42 ` Krzysztof Kozlowski [this message]
2023-09-25 9:11 ` Jason-JH Lin (林睿祥)
2023-09-25 9:28 ` Krzysztof Kozlowski
2023-09-26 2:45 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-4-jason-jh.lin@mediatek.com>
2023-09-23 18:02 ` [PATCH 03/15] soc: mailbox: Add SPR definition for GCE Krzysztof Kozlowski
2023-09-25 5:08 ` Jason-JH Lin (林睿祥)
2023-09-25 6:42 ` Krzysztof Kozlowski
2023-09-25 10:24 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-7-jason-jh.lin@mediatek.com>
2023-09-19 1:24 ` [PATCH 06/15] mailbox: mediatek: Add cmdq_mbox_stop to disable GCE thread CK Hu (胡俊光)
2023-09-21 14:15 ` Jason-JH Lin (林睿祥)
2023-09-23 18:02 ` Krzysztof Kozlowski
2023-09-25 5:10 ` Jason-JH Lin (林睿祥)
2023-09-23 18:07 ` Krzysztof Kozlowski
2023-09-25 5:25 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-8-jason-jh.lin@mediatek.com>
2023-09-23 18:03 ` [PATCH 07/15] mailbox: mediatek: Add loop pkt flag and irq handling for loop command Krzysztof Kozlowski
2023-09-25 5:21 ` Jason-JH Lin (林睿祥)
2023-09-25 6:44 ` Krzysztof Kozlowski
2023-09-26 3:20 ` Jason-JH Lin (林睿祥)
2023-09-26 20:32 ` Krzysztof Kozlowski
[not found] ` <20230918192204.32263-9-jason-jh.lin@mediatek.com>
2023-09-19 1:38 ` [PATCH 08/15] soc: mediatek: Add cmdq_pkt_finalize_loop to CMDQ driver CK Hu (胡俊光)
2023-09-21 14:25 ` Jason-JH Lin (林睿祥)
2023-09-23 18:04 ` Krzysztof Kozlowski
2023-09-23 18:08 ` Krzysztof Kozlowski
2023-09-25 6:04 ` Jason-JH Lin (林睿祥)
2023-09-25 6:40 ` Krzysztof Kozlowski
[not found] ` <20230918192204.32263-15-jason-jh.lin@mediatek.com>
2023-09-23 18:08 ` [PATCH 14/15] mailbox: mediatek: Add mt8195 support for CMDQ secure driver Krzysztof Kozlowski
2023-09-25 5:48 ` Jason-JH Lin (林睿祥)
[not found] ` <20230918192204.32263-14-jason-jh.lin@mediatek.com>
2023-09-23 18:09 ` [PATCH 13/15] mailbox: mediatek: Add mt8188 " Krzysztof Kozlowski
2023-09-25 6:01 ` Jason-JH Lin (林睿祥)
2023-09-25 6:45 ` Krzysztof Kozlowski
2023-09-25 9:02 ` Jason-JH Lin (林睿祥)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69ca292-e0b9-4ee2-9f4e-6e9300a636a6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Elvis.Wang@mediatek.com \
--cc=Jason-JH.Lin@mediatek.com \
--cc=Jason-ch.Chen@mediatek.com \
--cc=Johnson.Wang@mediatek.com \
--cc=Nancy.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Shawn.Sung@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox