Re: [PATCH 1/2] arm64: dts: sc7180: Remove additional spi chip select muxes

Re: [PATCH 1/2] arm64: dts: sc7180: Remove additional spi chip select muxes

[Stephen Boyd]

Quoting Rajendra Nayak (2019-12-10 23:12:52)
> remove the additional CS muxes that were added by default for
> spi so every board using sc7180 does not have to override it.
> 
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Re: [PATCH 1/2] arm64: dts: sc7180: Remove additional spi chip select muxes

[Doug Anderson]

Hi,

On Tue, Dec 10, 2019 at 11:12 PM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> remove the additional CS muxes that were added by default for
> spi so every board using sc7180 does not have to override it.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

In theory we could add some extra pinmux configs that boards could
reference if they want to use those chip selects (as long as we keep
them out of the "default"), but it's also fine to wait until someone
has an actual need for it.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

[PATCH 1/2] arm64: dts: sc7180: Remove additional spi chip select muxes

[Rajendra Nayak]

remove the additional CS muxes that were added by default for
spi so every board using sc7180 does not have to override it.

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 666e9b9..88db1f5 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -751,8 +751,7 @@
 			qup_spi1_default: qup-spi1-default {
 				pinmux {
 					pins = "gpio0", "gpio1",
-					       "gpio2", "gpio3",
-					       "gpio12", "gpio94";
+					       "gpio2", "gpio3";
 					function = "qup01";
 				};
 			};
@@ -776,8 +775,7 @@
 			qup_spi6_default: qup-spi6-default {
 				pinmux {
 					pins = "gpio59", "gpio60",
-					       "gpio61", "gpio62",
-					       "gpio68", "gpio72";
+					       "gpio61", "gpio62";
 					function = "qup10";
 				};
 			};
@@ -793,8 +791,7 @@
 			qup_spi10_default: qup-spi10-default {
 				pinmux {
 					pins = "gpio86", "gpio87",
-					       "gpio88", "gpio89",
-					       "gpio90", "gpio91";
+					       "gpio88", "gpio89";
 					function = "qup14";
 				};
 			};
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation