From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Lee Jones <lee.jones@linaro.org>, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH v5 2/2] mfd: dm355evm_msp: Change error messages in add_child()
Date: Thu, 11 Aug 2016 14:26:44 +0200 [thread overview]
Message-ID: <5e0c3af5-5efd-2e7e-020a-5c7304131cc1@users.sourceforge.net> (raw)
In-Reply-To: <80dc4486-01d1-df66-c9c2-b71ee2251251@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 11 Aug 2016 14:00:43 +0200
Delete an error message at the end while increasing the importance of
related information.
Link: https://lkml.kernel.org/g/<20160809153615.GU5243@dell>
Suggested-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v5: Rebased on the source files from Linux next-20160809.
Requested changes were applied.
drivers/mfd/dm355evm_msp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c
index 86eca61..463f9e2e 100644
--- a/drivers/mfd/dm355evm_msp.c
+++ b/drivers/mfd/dm355evm_msp.c
@@ -208,7 +208,7 @@ static struct device *add_child(struct i2c_client *client, const char *name,
if (pdata) {
status = platform_device_add_data(pdev, pdata, pdata_len);
if (status < 0) {
- dev_dbg(&pdev->dev, "can't add platform_data\n");
+ dev_err(&pdev->dev, "can't add platform_data\n");
goto put_device;
}
}
@@ -221,7 +221,7 @@ static struct device *add_child(struct i2c_client *client, const char *name,
status = platform_device_add_resources(pdev, &r, 1);
if (status < 0) {
- dev_dbg(&pdev->dev, "can't add irq\n");
+ dev_err(&pdev->dev, "can't add irq\n");
goto put_device;
}
}
@@ -234,7 +234,6 @@ static struct device *add_child(struct i2c_client *client, const char *name,
put_device:
platform_device_put(pdev);
- dev_err(&client->dev, "failed to add device %s\n", name);
return ERR_PTR(status);
}
--
2.9.2
next prev parent reply other threads:[~2016-08-11 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 12:20 [PATCH v5 0/2] mfd: dm355evm_msp: Improve implementation of add_child() SF Markus Elfring
2016-08-11 12:23 ` [PATCH v5 1/2] mfd: dm355evm_msp: Refactoring for add_child() SF Markus Elfring
2016-08-30 15:10 ` Lee Jones
2016-08-11 12:26 ` SF Markus Elfring [this message]
2016-08-11 12:39 ` [PATCH v5 2/2] mfd: dm355evm_msp: Change error messages in add_child() Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0c3af5-5efd-2e7e-020a-5c7304131cc1@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox