* [PATCH] w1: ds2408: Fix the wrong output format
@ 2024-10-28 12:57 Liu Jing
2024-10-28 14:07 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Liu Jing @ 2024-10-28 12:57 UTC (permalink / raw)
To: krzk; +Cc: linux-kernel, Liu Jing
The output format of the retries variable should be %u instead of %d
Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com>
diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
index 56f822a1dfdb..1efe55e1dd8a 100644
--- a/drivers/w1/slaves/w1_ds2408.c
+++ b/drivers/w1/slaves/w1_ds2408.c
@@ -199,7 +199,7 @@ static ssize_t output_write(struct file *filp, struct kobject *kobj,
out:
mutex_unlock(&sl->master->bus_mutex);
- dev_dbg(&sl->dev, "%s, mutex unlocked retries:%d\n",
+ dev_dbg(&sl->dev, "%s, mutex unlocked retries:%u\n",
(bytes_written > 0) ? "succeeded" : "error", retries);
return bytes_written;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] w1: ds2408: Fix the wrong output format
2024-10-28 12:57 [PATCH] w1: ds2408: Fix the wrong output format Liu Jing
@ 2024-10-28 14:07 ` Krzysztof Kozlowski
2024-12-02 14:13 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-10-28 14:07 UTC (permalink / raw)
To: Liu Jing; +Cc: linux-kernel
On 28/10/2024 13:57, Liu Jing wrote:
> The output format of the retries variable should be %u instead of %d
Why? Is there a specific compiler warning?
Please organize your patches in patchsets (see submitting patches and b4
tool).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] w1: ds2408: Fix the wrong output format
2024-10-28 14:07 ` Krzysztof Kozlowski
@ 2024-12-02 14:13 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-02 14:13 UTC (permalink / raw)
To: Liu Jing; +Cc: linux-kernel
On 28/10/2024 15:07, Krzysztof Kozlowski wrote:
> On 28/10/2024 13:57, Liu Jing wrote:
>> The output format of the retries variable should be %u instead of %d
>
> Why? Is there a specific compiler warning?
>
> Please organize your patches in patchsets (see submitting patches and b4
> tool).
I did not receive any answers so I dropped these two from my queue.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-02 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 12:57 [PATCH] w1: ds2408: Fix the wrong output format Liu Jing
2024-10-28 14:07 ` Krzysztof Kozlowski
2024-12-02 14:13 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox