Re: [PATCH] dt-bindings: mmc: ti-omap: convert text based binding to json schema

[Charan Pedumuru <charan.pedumuru@gmail.com>]

On 12-05-2025 01:48, Krzysztof Kozlowski wrote:
> On 10/05/2025 19:20, Charan Pedumuru wrote:
>>
>>
>> On 10-05-2025 22:07, Charan Pedumuru wrote:
>>> Convert TI MMC host controller binding to YAML format. It's a
>>> straight-forward conversion of the typical mmc host controller.
> 
> 
> Not really - you added properties.
> 
> 
>>>
>>> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
>>> ---
>>>  Documentation/devicetree/bindings/mmc/ti-omap.txt  | 26 ---------
>>>  Documentation/devicetree/bindings/mmc/ti-omap.yaml | 61 ++++++++++++++++++++++
>>>  2 files changed, 61 insertions(+), 26 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap.txt b/Documentation/devicetree/bindings/mmc/ti-omap.txt
>>> deleted file mode 100644
>>> index 02fd31cf361d6ed893ec2f9eb8368b358ab2bae1..0000000000000000000000000000000000000000
>>> --- a/Documentation/devicetree/bindings/mmc/ti-omap.txt
>>> +++ /dev/null
>>> @@ -1,26 +0,0 @@
>>> -* TI MMC host controller for OMAP1 and 2420
>>> -
> 
> ...
> 
>>> -	};
>>> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap.yaml b/Documentation/devicetree/bindings/mmc/ti-omap.yaml
> 
> 
> Filename based on the compatible. Didn't you get exactly such feedback
> already?

Yes, I will rename it.

> 
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..3660f54550e0ee46d3a7cfa3f531d95802f1e2fb
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mmc/ti-omap.yaml
>>> @@ -0,0 +1,61 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mmc/ti-omap.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: TI MMC host controller for OMAP1 and 2420
>>> +
>>> +description:
>>> +  The MMC Host controller for TI OMAP1 and 2420 family provides
>>> +  an interface for MMC, SD and SDIO types of memory cards.
>>> +
>>> +allOf:
>>> +  - $ref: mmc-controller.yaml
>>> +
>>> +maintainers:
>>> +  - Ulf Hansson <ulf.hansson@linaro.org>
> 
> 
> No, this is supposed someone responsible for the device, not subsystem
> maintainer.
> 

Okay.

>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: ti,omap2420-mmc
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  dmas:
>>> +    maxItems: 2
>>> +
>>> +  dma-names:
>>> +    items:
>>> +      - const: tx
>>> +      - const: rx
>>> +
>>> +  ti,hwmods:
>>> +    items:
>>> +      pattern: "^msdi[0-9]+$"
> 
> Missing type: string-array
> min/maxItems?
> 

I think the type can be string, will modify defining type and maxItems. If it's string-array, the defaults can only be "msdi0" and "msdi1". So, I thought to define pattern with string type.

>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - interrupts
>>> +  - dmas
>>> +  - dma-names
> 
> That's a change - binding did not mention it, did not make it required.
> Every change should be explain in commit msg.
> 
>>> +  - ti,hwmods
>>> +
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    mmc@4809c000 {
>>> +        compatible = "ti,omap2420-mmc";
>>> +        ti,hwmods = "msdi1";
>>> +        reg = <0x4809c000 0x80>;
>>> +        interrupts = <83>;
>>
>> Forgot to include irq interrupt-controller header and use it for the interrupts, will change in next revision.
> 
> Header does not look like used...

Yeah, will change the interrupts format to take header format.

> 
>>
>>
>>> +        dmas = <&sdma 61 &sdma 62>;
> 
> But here you need two <> phandles.

Sure, I will rewrite them in 2 different phandles separated by , .

> 
>>> +        dma-names = "tx", "rx";
>>> +    };
>>> +...
>>>
>>> ---
>>> base-commit: 3e039dcc9c1320c0d33ddd51c372dcc91d3ea3c7
>>> change-id: 20250502-ti-omap-12655fa9db3e
>>>
>>> Best regards,
>>
> 
> 
> Best regards,
> Krzysztof

-- 
Best Regards,
Charan.