public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charan Pedumuru <charan.pedumuru@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: ti-omap: convert text based binding to json schema
Date: Sat, 10 May 2025 22:50:41 +0530	[thread overview]
Message-ID: <b18bc629-6bf6-4490-be98-033b771ecda7@gmail.com> (raw)
In-Reply-To: <20250510-ti-omap-v1-1-588b0ccb1823@gmail.com>



On 10-05-2025 22:07, Charan Pedumuru wrote:
> Convert TI MMC host controller binding to YAML format. It's a
> straight-forward conversion of the typical mmc host controller.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> ---
>  Documentation/devicetree/bindings/mmc/ti-omap.txt  | 26 ---------
>  Documentation/devicetree/bindings/mmc/ti-omap.yaml | 61 ++++++++++++++++++++++
>  2 files changed, 61 insertions(+), 26 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap.txt b/Documentation/devicetree/bindings/mmc/ti-omap.txt
> deleted file mode 100644
> index 02fd31cf361d6ed893ec2f9eb8368b358ab2bae1..0000000000000000000000000000000000000000
> --- a/Documentation/devicetree/bindings/mmc/ti-omap.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -* TI MMC host controller for OMAP1 and 2420
> -
> -The MMC Host Controller on TI OMAP1 and 2420 family provides
> -an interface for MMC, SD, and SDIO types of memory cards.
> -
> -This file documents differences between the core properties described
> -by mmc.txt and the properties used by the omap mmc driver.
> -
> -Note that this driver will not work with omap2430 or later omaps,
> -please see the omap hsmmc driver for the current omaps.
> -
> -Required properties:
> -- compatible: Must be "ti,omap2420-mmc", for OMAP2420 controllers
> -- ti,hwmods: For 2420, must be "msdi<n>", where n is controller
> -  instance starting 1
> -
> -Examples:
> -
> -	msdi1: mmc@4809c000 {
> -		compatible = "ti,omap2420-mmc";
> -		ti,hwmods = "msdi1";
> -		reg = <0x4809c000 0x80>;
> -		interrupts = <83>;
> -		dmas = <&sdma 61 &sdma 62>;
> -		dma-names = "tx", "rx";
> -	};
> diff --git a/Documentation/devicetree/bindings/mmc/ti-omap.yaml b/Documentation/devicetree/bindings/mmc/ti-omap.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..3660f54550e0ee46d3a7cfa3f531d95802f1e2fb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/ti-omap.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/ti-omap.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI MMC host controller for OMAP1 and 2420
> +
> +description:
> +  The MMC Host controller for TI OMAP1 and 2420 family provides
> +  an interface for MMC, SD and SDIO types of memory cards.
> +
> +allOf:
> +  - $ref: mmc-controller.yaml
> +
> +maintainers:
> +  - Ulf Hansson <ulf.hansson@linaro.org>
> +
> +properties:
> +  compatible:
> +    const: ti,omap2420-mmc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  dmas:
> +    maxItems: 2
> +
> +  dma-names:
> +    items:
> +      - const: tx
> +      - const: rx
> +
> +  ti,hwmods:
> +    items:
> +      pattern: "^msdi[0-9]+$"
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - dmas
> +  - dma-names
> +  - ti,hwmods
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mmc@4809c000 {
> +        compatible = "ti,omap2420-mmc";
> +        ti,hwmods = "msdi1";
> +        reg = <0x4809c000 0x80>;
> +        interrupts = <83>;

Forgot to include irq interrupt-controller header and use it for the interrupts, will change in next revision.


> +        dmas = <&sdma 61 &sdma 62>;
> +        dma-names = "tx", "rx";
> +    };
> +...
> 
> ---
> base-commit: 3e039dcc9c1320c0d33ddd51c372dcc91d3ea3c7
> change-id: 20250502-ti-omap-12655fa9db3e
> 
> Best regards,

-- 
Best Regards,
Charan.


  reply	other threads:[~2025-05-10 17:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-10 16:37 [PATCH] dt-bindings: mmc: ti-omap: convert text based binding to json schema Charan Pedumuru
2025-05-10 17:20 ` Charan Pedumuru [this message]
2025-05-11 20:18   ` Krzysztof Kozlowski
2025-05-19  5:08     ` Charan Pedumuru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b18bc629-6bf6-4490-be98-033b771ecda7@gmail.com \
    --to=charan.pedumuru@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox