From: Steven Price <steven.price@arm.com>
To: Osama Abdelkader <osama.abdelkader@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Grant Likely <grant.likely@linaro.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panthor: return PTR_ERR() from devm_drm_dev_alloc()
Date: Fri, 24 Jul 2026 16:08:46 +0100 [thread overview]
Message-ID: <64cdc80f-f8a0-482a-9207-059a5f45ca68@arm.com> (raw)
In-Reply-To: <20260716140337.10679-1-osama.abdelkader@gmail.com>
On 16/07/2026 15:03, Osama Abdelkader wrote:
> devm_drm_dev_alloc() returns an ERR_PTR() on failure, but panthor_probe()
> always converts that failure to -ENOMEM. Preserve the actual error code
> returned by the DRM core instead.
>
> Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Reviewed-by: Steven Price <steven.price@arm.com>
I'll apply this to drm-misc-next.
Thanks,
Steve
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 487eedb72ac5..847db031e165 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1824,7 +1824,7 @@ static int panthor_probe(struct platform_device *pdev)
> ptdev = devm_drm_dev_alloc(&pdev->dev, &panthor_drm_driver,
> struct panthor_device, base);
> if (IS_ERR(ptdev))
> - return -ENOMEM;
> + return PTR_ERR(ptdev);
>
> platform_set_drvdata(pdev, ptdev);
>
prev parent reply other threads:[~2026-07-24 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 14:03 [PATCH] drm/panthor: return PTR_ERR() from devm_drm_dev_alloc() Osama Abdelkader
2026-07-24 15:08 ` Steven Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64cdc80f-f8a0-482a-9207-059a5f45ca68@arm.com \
--to=steven.price@arm.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=osama.abdelkader@gmail.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox