* [PATCH] drm/panthor: return PTR_ERR() from devm_drm_dev_alloc()
@ 2026-07-16 14:03 Osama Abdelkader
2026-07-24 15:08 ` Steven Price
0 siblings, 1 reply; 2+ messages in thread
From: Osama Abdelkader @ 2026-07-16 14:03 UTC (permalink / raw)
To: Boris Brezillon, Steven Price, Liviu Dudau, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Grant Likely, dri-devel, linux-kernel
Cc: Osama Abdelkader
devm_drm_dev_alloc() returns an ERR_PTR() on failure, but panthor_probe()
always converts that failure to -ENOMEM. Preserve the actual error code
returned by the DRM core instead.
Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
drivers/gpu/drm/panthor/panthor_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
index 487eedb72ac5..847db031e165 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -1824,7 +1824,7 @@ static int panthor_probe(struct platform_device *pdev)
ptdev = devm_drm_dev_alloc(&pdev->dev, &panthor_drm_driver,
struct panthor_device, base);
if (IS_ERR(ptdev))
- return -ENOMEM;
+ return PTR_ERR(ptdev);
platform_set_drvdata(pdev, ptdev);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panthor: return PTR_ERR() from devm_drm_dev_alloc()
2026-07-16 14:03 [PATCH] drm/panthor: return PTR_ERR() from devm_drm_dev_alloc() Osama Abdelkader
@ 2026-07-24 15:08 ` Steven Price
0 siblings, 0 replies; 2+ messages in thread
From: Steven Price @ 2026-07-24 15:08 UTC (permalink / raw)
To: Osama Abdelkader, Boris Brezillon, Liviu Dudau, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Grant Likely, dri-devel, linux-kernel
On 16/07/2026 15:03, Osama Abdelkader wrote:
> devm_drm_dev_alloc() returns an ERR_PTR() on failure, but panthor_probe()
> always converts that failure to -ENOMEM. Preserve the actual error code
> returned by the DRM core instead.
>
> Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Reviewed-by: Steven Price <steven.price@arm.com>
I'll apply this to drm-misc-next.
Thanks,
Steve
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 487eedb72ac5..847db031e165 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1824,7 +1824,7 @@ static int panthor_probe(struct platform_device *pdev)
> ptdev = devm_drm_dev_alloc(&pdev->dev, &panthor_drm_driver,
> struct panthor_device, base);
> if (IS_ERR(ptdev))
> - return -ENOMEM;
> + return PTR_ERR(ptdev);
>
> platform_set_drvdata(pdev, ptdev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-24 15:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-16 14:03 [PATCH] drm/panthor: return PTR_ERR() from devm_drm_dev_alloc() Osama Abdelkader
2026-07-24 15:08 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox