* [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible
@ 2024-07-31 7:19 Alexander Stein
2024-07-31 7:25 ` Alexander Stein
2024-07-31 7:27 ` Krzysztof Kozlowski
0 siblings, 2 replies; 6+ messages in thread
From: Alexander Stein @ 2024-07-31 7:19 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Fabio Estevam
Cc: Alexander Stein, linux-usb, devicetree, linux-kernel
USB2517 is a 7-port variant of this USB hub. Add an USB compatible
based on USB vendor & product ID.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
index 783c27591e564..245e8c3ce6699 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
@@ -18,6 +18,7 @@ properties:
- usb424,2412
- usb424,2417
- usb424,2514
+ - usb424,2517
reg: true
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible
2024-07-31 7:19 [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible Alexander Stein
@ 2024-07-31 7:25 ` Alexander Stein
2024-07-31 7:27 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Alexander Stein @ 2024-07-31 7:25 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Fabio Estevam
Cc: linux-usb, devicetree, linux-kernel
Am Mittwoch, 31. Juli 2024, 09:19:50 CEST schrieb Alexander Stein:
> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
> based on USB vendor & product ID.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> index 783c27591e564..245e8c3ce6699 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> @@ -18,6 +18,7 @@ properties:
> - usb424,2412
> - usb424,2417
> - usb424,2514
> + - usb424,2517
>
> reg: true
>
>
One question unrelated to this change but regarding this binding:
Why is this referring usb-hcd.yaml and not usb-device.yaml? This USB hub
is not a host controller but a USB device.
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible
2024-07-31 7:19 [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible Alexander Stein
2024-07-31 7:25 ` Alexander Stein
@ 2024-07-31 7:27 ` Krzysztof Kozlowski
2024-07-31 7:32 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-31 7:27 UTC (permalink / raw)
To: Alexander Stein, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Fabio Estevam
Cc: linux-usb, devicetree, linux-kernel
On 31/07/2024 09:19, Alexander Stein wrote:
> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
> based on USB vendor & product ID.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible
2024-07-31 7:27 ` Krzysztof Kozlowski
@ 2024-07-31 7:32 ` Krzysztof Kozlowski
2024-07-31 7:34 ` [PATCH 1/1] dt-bindings: usb: microchip, usb2514: " Alexander Stein
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-31 7:32 UTC (permalink / raw)
To: Alexander Stein, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Fabio Estevam
Cc: linux-usb, devicetree, linux-kernel
On 31/07/2024 09:27, Krzysztof Kozlowski wrote:
> On 31/07/2024 09:19, Alexander Stein wrote:
>> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
>> based on USB vendor & product ID.
>>
>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Of course assuming there is some user? If so, where?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] dt-bindings: usb: microchip, usb2514: Add USB2517 compatible
2024-07-31 7:32 ` Krzysztof Kozlowski
@ 2024-07-31 7:34 ` Alexander Stein
2024-07-31 8:05 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2024-07-31 7:34 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Fabio Estevam, Krzysztof Kozlowski
Cc: linux-usb, devicetree, linux-kernel
Am Mittwoch, 31. Juli 2024, 09:32:43 CEST schrieb Krzysztof Kozlowski:
> On 31/07/2024 09:27, Krzysztof Kozlowski wrote:
> > On 31/07/2024 09:19, Alexander Stein wrote:
> >> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
> >> based on USB vendor & product ID.
> >>
> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Of course assuming there is some user? If so, where?
There is: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
introduced by commit ba9943f47dca1 ("arm64: dts: mba93xxla: Add USB support")
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] dt-bindings: usb: microchip, usb2514: Add USB2517 compatible
2024-07-31 7:34 ` [PATCH 1/1] dt-bindings: usb: microchip, usb2514: " Alexander Stein
@ 2024-07-31 8:05 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-31 8:05 UTC (permalink / raw)
To: Alexander Stein, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Fabio Estevam
Cc: linux-usb, devicetree, linux-kernel
On 31/07/2024 09:34, Alexander Stein wrote:
> Am Mittwoch, 31. Juli 2024, 09:32:43 CEST schrieb Krzysztof Kozlowski:
>> On 31/07/2024 09:27, Krzysztof Kozlowski wrote:
>>> On 31/07/2024 09:19, Alexander Stein wrote:
>>>> USB2517 is a 7-port variant of this USB hub. Add an USB compatible
>>>> based on USB vendor & product ID.
>>>>
>>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Of course assuming there is some user? If so, where?
>
> There is: arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxla.dts
> introduced by commit ba9943f47dca1 ("arm64: dts: mba93xxla: Add USB support")
Bindings 1.5 years after you added compatible... checkpatch told you
that you miss bindings that time.
This should be explained in commit msg - you add compatible for a
compatible already present in the kernel.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-31 8:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 7:19 [PATCH 1/1] dt-bindings: usb: microchip,usb2514: Add USB2517 compatible Alexander Stein
2024-07-31 7:25 ` Alexander Stein
2024-07-31 7:27 ` Krzysztof Kozlowski
2024-07-31 7:32 ` Krzysztof Kozlowski
2024-07-31 7:34 ` [PATCH 1/1] dt-bindings: usb: microchip, usb2514: " Alexander Stein
2024-07-31 8:05 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox