From: Ira Weiny <ira.weiny@intel.com>
To: Borislav Petkov <bp@alien8.de>, "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>,
Feng Tang <feng.tang@linux.alibaba.com>, <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Ira Weiny <ira.weiny@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] APEI: GHES: Have GHES honor the panic= setting
Date: Mon, 13 Jan 2025 14:08:23 -0600 [thread overview]
Message-ID: <678572b7c28b0_182bf92941f@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20250113125224.GFZ4UMiNtWIJvgpveU@fat_crate.local>
Borislav Petkov wrote:
> The GHES driver overrides the panic= setting by force-rebooting the
> system after a fatal hw error has been reported. The intent being that
> such an error would be reported earlier.
>
> However, this is not optimal when a hard-to-debug issue requires long
> time to reproduce and when that happens, the box will get rebooted after
> 30 seconds and thus destroy the whole hw context of when the error
> happened.
>
> So rip out the default GHES panic timeout and honor the global one.
>
> In the panic disabled (panic=0) case, the error will still be logged to
> dmesg for later inspection and if panic after a hw error is really
> required, then that can be controlled the usual way - use panic= on the
> cmdline or set it in the kernel .config's CONFIG_PANIC_TIMEOUT.
>
> Reported-by: Feng Tang <feng.tang@linux.alibaba.com>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
next prev parent reply other threads:[~2025-01-13 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 9:54 [PATCH] acpi/ghes: Make ghes_panic_timeout adjustable as a parameter Feng Tang
2024-12-27 10:09 ` Borislav Petkov
2024-12-30 5:54 ` Huang, Ying
2024-12-30 10:16 ` Borislav Petkov
2024-12-30 11:04 ` Huang, Ying
2024-12-30 11:26 ` Borislav Petkov
2024-12-30 11:40 ` Feng Tang
2024-12-30 12:10 ` Borislav Petkov
2024-12-30 13:04 ` Feng Tang
2024-12-30 13:24 ` Borislav Petkov
2024-12-31 6:44 ` Feng Tang
2024-12-31 9:23 ` Borislav Petkov
2024-12-31 10:15 ` Feng Tang
2024-12-31 11:13 ` Borislav Petkov
2024-12-31 12:02 ` Feng Tang
2025-01-02 2:46 ` Huang, Ying
2025-01-02 8:35 ` Borislav Petkov
2025-01-13 12:52 ` [PATCH] APEI: GHES: Have GHES honor the panic= setting Borislav Petkov
2025-01-13 20:08 ` Ira Weiny [this message]
2025-01-14 17:29 ` Rafael J. Wysocki
2025-01-09 13:47 ` [PATCH] acpi/ghes: Make ghes_panic_timeout adjustable as a parameter Feng Tang
2025-01-13 12:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=678572b7c28b0_182bf92941f@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=feng.tang@linux.alibaba.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox