From: Feng Tang <feng.tang@linux.alibaba.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>,
rafael@kernel.org, Len Brown <lenb@kernel.org>,
James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Ira Weiny <ira.weiny@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] acpi/ghes: Make ghes_panic_timeout adjustable as a parameter
Date: Tue, 31 Dec 2024 18:15:59 +0800 [thread overview]
Message-ID: <Z3PEXxFTGXW2j2F3@U-2FWC9VHC-2323.local> (raw)
In-Reply-To: <20241231092358.GAZ3O4LroNtlnztneC@fat_crate.local>
On Tue, Dec 31, 2024 at 10:23:58AM +0100, Borislav Petkov wrote:
> On Tue, Dec 31, 2024 at 02:44:48PM +0800, Feng Tang wrote:
> > + /* If user hasn't specifically set panic timeout, reboot to log the error! */
> > + if (!panic_timeout && !strstr(saved_command_line, "panic="))
>
> And you want to scan saved_command_line because?
>
> Hint: look at how other code checks panic_timeout.
Thanks for the hint! IIUC, you are mentioning the set_arch_panic_timeout().
One thing is, most ARCHs' default timeout is 0, while in our case, the user
will also set 'panic=0' :), so we can't easily detect if the 0 is the user-set
value or the OS default one. Originally I even thought about adding a flag
of 'timeout_user_changed'. Any suggestion?
> > Or we want to stick the orignal patch, which doesn't change the
> > original flow?
>
> And pile more broken stuff ontop?
OK, will skip this.
Thanks,
Feng
next prev parent reply other threads:[~2024-12-31 10:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 9:54 [PATCH] acpi/ghes: Make ghes_panic_timeout adjustable as a parameter Feng Tang
2024-12-27 10:09 ` Borislav Petkov
2024-12-30 5:54 ` Huang, Ying
2024-12-30 10:16 ` Borislav Petkov
2024-12-30 11:04 ` Huang, Ying
2024-12-30 11:26 ` Borislav Petkov
2024-12-30 11:40 ` Feng Tang
2024-12-30 12:10 ` Borislav Petkov
2024-12-30 13:04 ` Feng Tang
2024-12-30 13:24 ` Borislav Petkov
2024-12-31 6:44 ` Feng Tang
2024-12-31 9:23 ` Borislav Petkov
2024-12-31 10:15 ` Feng Tang [this message]
2024-12-31 11:13 ` Borislav Petkov
2024-12-31 12:02 ` Feng Tang
2025-01-02 2:46 ` Huang, Ying
2025-01-02 8:35 ` Borislav Petkov
2025-01-13 12:52 ` [PATCH] APEI: GHES: Have GHES honor the panic= setting Borislav Petkov
2025-01-13 20:08 ` Ira Weiny
2025-01-14 17:29 ` Rafael J. Wysocki
2025-01-09 13:47 ` [PATCH] acpi/ghes: Make ghes_panic_timeout adjustable as a parameter Feng Tang
2025-01-13 12:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3PEXxFTGXW2j2F3@U-2FWC9VHC-2323.local \
--to=feng.tang@linux.alibaba.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox