* [PATCH] ata: sata_gemini: Add check for clk_enable
@ 2024-04-03 3:43 Chen Ni
2024-04-03 3:56 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2024-04-03 3:43 UTC (permalink / raw)
To: linus.walleij, dlemoal, cassel; +Cc: linux-ide, linux-kernel, Chen Ni
As the potential failure of the clk_enable(), it should be better to
check it and return error if fails.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/ata/sata_gemini.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index 400b22ee99c3..4c270999ba3c 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge)
pclk = sg->sata0_pclk;
else
pclk = sg->sata1_pclk;
- clk_enable(pclk);
+ ret = clk_enable(pclk);
+ if (ret)
+ return ret;
+
msleep(10);
/* Do not keep clocking a bridge that is not online */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: sata_gemini: Add check for clk_enable
2024-04-03 3:43 [PATCH] ata: sata_gemini: Add check for clk_enable Chen Ni
@ 2024-04-03 3:56 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2024-04-03 3:56 UTC (permalink / raw)
To: Chen Ni, linus.walleij, cassel; +Cc: linux-ide, linux-kernel
On 4/3/24 12:43, Chen Ni wrote:
> As the potential failure of the clk_enable(), it should be better to
> check it and return error if fails.
Simplify please:
The call to clk_enable() in gemini_sata_start_bridge() can fail. Add a check to
detect such failure.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/ata/sata_gemini.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
> index 400b22ee99c3..4c270999ba3c 100644
> --- a/drivers/ata/sata_gemini.c
> +++ b/drivers/ata/sata_gemini.c
> @@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge)
> pclk = sg->sata0_pclk;
> else
> pclk = sg->sata1_pclk;
> - clk_enable(pclk);
> + ret = clk_enable(pclk);
> + if (ret)
> + return ret;
> +
> msleep(10);
>
> /* Do not keep clocking a bridge that is not online */
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-03 3:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-03 3:43 [PATCH] ata: sata_gemini: Add check for clk_enable Chen Ni
2024-04-03 3:56 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox