* [syzbot] [hams?] possible deadlock in nr_remove_neigh (2)
@ 2024-12-30 2:36 syzbot
2025-02-08 5:02 ` syzbot
0 siblings, 1 reply; 6+ messages in thread
From: syzbot @ 2024-12-30 2:36 UTC (permalink / raw)
To: davem, edumazet, horms, kuba, linux-hams, linux-kernel, netdev,
pabeni, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: 059dd502b263 Merge tag 'block-6.13-20241228' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=150b2af8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=aa8dc22aa6de51f5
dashboard link: https://syzkaller.appspot.com/bug?extid=8863ad36d31449b4dc17
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/27659a620a43/disk-059dd502.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/996b6ce6c350/vmlinux-059dd502.xz
kernel image: https://storage.googleapis.com/syzbot-assets/094cd4888c06/bzImage-059dd502.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8863ad36d31449b4dc17@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc4-syzkaller-00078-g059dd502b263 #0 Not tainted
------------------------------------------------------
syz.2.1275/10378 is trying to acquire lock:
ffffffff90129eb8 (nr_neigh_list_lock){+...}-{3:3}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffffffff90129eb8 (nr_neigh_list_lock){+...}-{3:3}, at: nr_remove_neigh+0x1a/0x290 net/netrom/nr_route.c:307
but task is already holding lock:
ffff88802369c470 (&nr_node->node_lock){+...}-{3:3}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff88802369c470 (&nr_node->node_lock){+...}-{3:3}, at: nr_node_lock include/net/netrom.h:152 [inline]
ffff88802369c470 (&nr_node->node_lock){+...}-{3:3}, at: nr_add_node+0x60b/0x2be0 net/netrom/nr_route.c:214
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&nr_node->node_lock){+...}-{3:3}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_node_lock include/net/netrom.h:152 [inline]
nr_rt_device_down+0x188/0x7f0 net/netrom/nr_route.c:519
nr_device_event+0x126/0x170 net/netrom/af_netrom.c:126
notifier_call_chain+0xb7/0x410 kernel/notifier.c:85
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:1996
call_netdevice_notifiers_extack net/core/dev.c:2034 [inline]
call_netdevice_notifiers net/core/dev.c:2048 [inline]
dev_close_many+0x333/0x6a0 net/core/dev.c:1589
dev_close net/core/dev.c:1611 [inline]
dev_close+0x181/0x230 net/core/dev.c:1605
bpq_device_event+0x820/0xaf0 drivers/net/hamradio/bpqether.c:547
notifier_call_chain+0xb7/0x410 kernel/notifier.c:85
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:1996
call_netdevice_notifiers_extack net/core/dev.c:2034 [inline]
call_netdevice_notifiers net/core/dev.c:2048 [inline]
dev_close_many+0x333/0x6a0 net/core/dev.c:1589
dev_close net/core/dev.c:1611 [inline]
dev_close+0x181/0x230 net/core/dev.c:1605
bond_setup_by_slave drivers/net/bonding/bond_main.c:1631 [inline]
bond_enslave+0x1f67/0x6040 drivers/net/bonding/bond_main.c:2043
bond_do_ioctl+0x60e/0x6d0 drivers/net/bonding/bond_main.c:4685
dev_siocbond net/core/dev_ioctl.c:471 [inline]
dev_ifsioc+0x1ea/0x10b0 net/core/dev_ioctl.c:613
dev_ioctl+0x224/0x10c0 net/core/dev_ioctl.c:783
sock_do_ioctl+0x19e/0x280 net/socket.c:1223
sock_ioctl+0x228/0x6c0 net/socket.c:1328
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #1 (nr_node_list_lock){+...}-{3:3}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_rt_device_down+0xd5/0x7f0 net/netrom/nr_route.c:517
nr_device_event+0x126/0x170 net/netrom/af_netrom.c:126
notifier_call_chain+0xb7/0x410 kernel/notifier.c:85
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:1996
call_netdevice_notifiers_extack net/core/dev.c:2034 [inline]
call_netdevice_notifiers net/core/dev.c:2048 [inline]
dev_close_many+0x333/0x6a0 net/core/dev.c:1589
dev_close net/core/dev.c:1611 [inline]
dev_close+0x181/0x230 net/core/dev.c:1605
bpq_device_event+0x820/0xaf0 drivers/net/hamradio/bpqether.c:547
notifier_call_chain+0xb7/0x410 kernel/notifier.c:85
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:1996
call_netdevice_notifiers_extack net/core/dev.c:2034 [inline]
call_netdevice_notifiers net/core/dev.c:2048 [inline]
dev_close_many+0x333/0x6a0 net/core/dev.c:1589
dev_close net/core/dev.c:1611 [inline]
dev_close+0x181/0x230 net/core/dev.c:1605
bond_setup_by_slave drivers/net/bonding/bond_main.c:1631 [inline]
bond_enslave+0x1f67/0x6040 drivers/net/bonding/bond_main.c:2043
bond_do_ioctl+0x60e/0x6d0 drivers/net/bonding/bond_main.c:4685
dev_siocbond net/core/dev_ioctl.c:471 [inline]
dev_ifsioc+0x1ea/0x10b0 net/core/dev_ioctl.c:613
dev_ioctl+0x224/0x10c0 net/core/dev_ioctl.c:783
sock_do_ioctl+0x19e/0x280 net/socket.c:1223
sock_ioctl+0x228/0x6c0 net/socket.c:1328
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #0 (nr_neigh_list_lock){+...}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain kernel/locking/lockdep.c:3904 [inline]
__lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_remove_neigh+0x1a/0x290 net/netrom/nr_route.c:307
nr_add_node+0x23d1/0x2be0 net/netrom/nr_route.c:249
nr_rt_ioctl+0x126e/0x29e0 net/netrom/nr_route.c:651
nr_ioctl+0x19a/0x2e0 net/netrom/af_netrom.c:1254
sock_do_ioctl+0x116/0x280 net/socket.c:1209
sock_ioctl+0x228/0x6c0 net/socket.c:1328
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
other info that might help us debug this:
Chain exists of:
nr_neigh_list_lock --> nr_node_list_lock --> &nr_node->node_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&nr_node->node_lock);
lock(nr_node_list_lock);
lock(&nr_node->node_lock);
lock(nr_neigh_list_lock);
*** DEADLOCK ***
1 lock held by syz.2.1275/10378:
#0: ffff88802369c470 (&nr_node->node_lock){+...}-{3:3}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
#0: ffff88802369c470 (&nr_node->node_lock){+...}-{3:3}, at: nr_node_lock include/net/netrom.h:152 [inline]
#0: ffff88802369c470 (&nr_node->node_lock){+...}-{3:3}, at: nr_add_node+0x60b/0x2be0 net/netrom/nr_route.c:214
stack backtrace:
CPU: 0 UID: 0 PID: 10378 Comm: syz.2.1275 Not tainted 6.13.0-rc4-syzkaller-00078-g059dd502b263 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
print_circular_bug+0x419/0x5d0 kernel/locking/lockdep.c:2074
check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206
check_prev_add kernel/locking/lockdep.c:3161 [inline]
check_prevs_add kernel/locking/lockdep.c:3280 [inline]
validate_chain kernel/locking/lockdep.c:3904 [inline]
__lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_remove_neigh+0x1a/0x290 net/netrom/nr_route.c:307
nr_add_node+0x23d1/0x2be0 net/netrom/nr_route.c:249
nr_rt_ioctl+0x126e/0x29e0 net/netrom/nr_route.c:651
nr_ioctl+0x19a/0x2e0 net/netrom/af_netrom.c:1254
sock_do_ioctl+0x116/0x280 net/socket.c:1209
sock_ioctl+0x228/0x6c0 net/socket.c:1328
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f66b7b85d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f66b89c2038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f66b7d76080 RCX: 00007f66b7b85d29
RDX: 0000000020000280 RSI: 000000000000890b RDI: 0000000000000004
RBP: 00007f66b7c01b08 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000001 R14: 00007f66b7d76080 R15: 00007fff012efa98
</TASK>
bond0: (slave rose0): Error: Device is in use and cannot be enslaved
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [syzbot] [hams?] possible deadlock in nr_remove_neigh (2)
2024-12-30 2:36 [syzbot] [hams?] possible deadlock in nr_remove_neigh (2) syzbot
@ 2025-02-08 5:02 ` syzbot
2025-02-08 11:35 ` Hillf Danton
2025-02-08 23:45 ` Hillf Danton
0 siblings, 2 replies; 6+ messages in thread
From: syzbot @ 2025-02-08 5:02 UTC (permalink / raw)
To: davem, edumazet, horms, kuba, linux-hams, linux-kernel, netdev,
pabeni, syzkaller-bugs
syzbot has found a reproducer for the following issue on:
HEAD commit: 7ee983c850b4 Merge tag 'drm-fixes-2025-02-08' of https://g..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14b661b0580000
kernel config: https://syzkaller.appspot.com/x/.config?x=a7ddf49cf33ba213
dashboard link: https://syzkaller.appspot.com/bug?extid=8863ad36d31449b4dc17
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=137a5df8580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17148bdf980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ecfa63f9f35c/disk-7ee983c8.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e9bfce21362e/vmlinux-7ee983c8.xz
kernel image: https://storage.googleapis.com/syzbot-assets/2942fdcc30b7/bzImage-7ee983c8.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8863ad36d31449b4dc17@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.14.0-rc1-syzkaller-00181-g7ee983c850b4 #0 Not tainted
------------------------------------------------------
syz-executor270/7031 is trying to acquire lock:
ffffffff90146478 (nr_neigh_list_lock){+...}-{3:3}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffffffff90146478 (nr_neigh_list_lock){+...}-{3:3}, at: nr_remove_neigh+0x1a/0x290 net/netrom/nr_route.c:307
but task is already holding lock:
ffff888145b6b970 (&nr_node->node_lock){+...}-{3:3}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff888145b6b970 (&nr_node->node_lock){+...}-{3:3}, at: nr_node_lock include/net/netrom.h:152 [inline]
ffff888145b6b970 (&nr_node->node_lock){+...}-{3:3}, at: nr_add_node+0x60b/0x2be0 net/netrom/nr_route.c:214
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&nr_node->node_lock){+...}-{3:3}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_node_lock include/net/netrom.h:152 [inline]
nr_rt_device_down+0x188/0x7f0 net/netrom/nr_route.c:519
nr_device_event+0x126/0x170 net/netrom/af_netrom.c:126
notifier_call_chain+0xb7/0x410 kernel/notifier.c:85
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:2141
call_netdevice_notifiers_extack net/core/dev.c:2179 [inline]
call_netdevice_notifiers net/core/dev.c:2193 [inline]
__dev_notify_flags+0x1f9/0x2e0 net/core/dev.c:9213
dev_change_flags+0x10c/0x160 net/core/dev.c:9249
dev_ifsioc+0x9d8/0x10d0 net/core/dev_ioctl.c:563
dev_ioctl+0x224/0x10c0 net/core/dev_ioctl.c:826
sock_do_ioctl+0x19e/0x280 net/socket.c:1213
sock_ioctl+0x228/0x6c0 net/socket.c:1318
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #1 (nr_node_list_lock){+...}-{3:3}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_rt_device_down+0xd5/0x7f0 net/netrom/nr_route.c:517
nr_device_event+0x126/0x170 net/netrom/af_netrom.c:126
notifier_call_chain+0xb7/0x410 kernel/notifier.c:85
call_netdevice_notifiers_info+0xbe/0x140 net/core/dev.c:2141
call_netdevice_notifiers_extack net/core/dev.c:2179 [inline]
call_netdevice_notifiers net/core/dev.c:2193 [inline]
__dev_notify_flags+0x1f9/0x2e0 net/core/dev.c:9213
dev_change_flags+0x10c/0x160 net/core/dev.c:9249
dev_ifsioc+0x9d8/0x10d0 net/core/dev_ioctl.c:563
dev_ioctl+0x224/0x10c0 net/core/dev_ioctl.c:826
sock_do_ioctl+0x19e/0x280 net/socket.c:1213
sock_ioctl+0x228/0x6c0 net/socket.c:1318
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #0 (nr_neigh_list_lock){+...}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3163 [inline]
check_prevs_add kernel/locking/lockdep.c:3282 [inline]
validate_chain kernel/locking/lockdep.c:3906 [inline]
__lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_remove_neigh+0x1a/0x290 net/netrom/nr_route.c:307
nr_add_node+0x23d1/0x2be0 net/netrom/nr_route.c:249
nr_rt_ioctl+0x126e/0x29e0 net/netrom/nr_route.c:651
nr_ioctl+0x19a/0x2e0 net/netrom/af_netrom.c:1254
sock_do_ioctl+0x116/0x280 net/socket.c:1199
sock_ioctl+0x228/0x6c0 net/socket.c:1318
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
other info that might help us debug this:
Chain exists of:
nr_neigh_list_lock --> nr_node_list_lock --> &nr_node->node_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&nr_node->node_lock);
lock(nr_node_list_lock);
lock(&nr_node->node_lock);
lock(nr_neigh_list_lock);
*** DEADLOCK ***
1 lock held by syz-executor270/7031:
#0: ffff888145b6b970 (&nr_node->node_lock){+...}-{3:3}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
#0: ffff888145b6b970 (&nr_node->node_lock){+...}-{3:3}, at: nr_node_lock include/net/netrom.h:152 [inline]
#0: ffff888145b6b970 (&nr_node->node_lock){+...}-{3:3}, at: nr_add_node+0x60b/0x2be0 net/netrom/nr_route.c:214
stack backtrace:
CPU: 1 UID: 0 PID: 7031 Comm: syz-executor270 Not tainted 6.14.0-rc1-syzkaller-00181-g7ee983c850b4 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
print_circular_bug+0x490/0x760 kernel/locking/lockdep.c:2076
check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2208
check_prev_add kernel/locking/lockdep.c:3163 [inline]
check_prevs_add kernel/locking/lockdep.c:3282 [inline]
validate_chain kernel/locking/lockdep.c:3906 [inline]
__lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:356 [inline]
nr_remove_neigh+0x1a/0x290 net/netrom/nr_route.c:307
nr_add_node+0x23d1/0x2be0 net/netrom/nr_route.c:249
nr_rt_ioctl+0x126e/0x29e0 net/netrom/nr_route.c:651
nr_ioctl+0x19a/0x2e0 net/netrom/af_netrom.c:1254
sock_do_ioctl+0x116/0x280 net/socket.c:1199
sock_ioctl+0x228/0x6c0 net/socket.c:1318
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fcbef4bd2e9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 1f 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe540a63c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007fcbef4bd2e9
RDX: 00002000000001c0 RSI: 000000000000890b RDI: 0000000000000008
RBP: 0000000000000000 R08: 00007ffe540a6400 R09: 00007ffe540a6400
R10: 00007ffe540a6400 R11: 0000000000000246 R12: 00007ffe540a63e8
R13: 00007ffe540a6420 R14: 00000000000000de R15: 431bde82d7b634db
</TASK>
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [syzbot] [hams?] possible deadlock in nr_remove_neigh (2)
2025-02-08 5:02 ` syzbot
@ 2025-02-08 11:35 ` Hillf Danton
2025-02-08 12:06 ` syzbot
2025-02-08 23:45 ` Hillf Danton
1 sibling, 1 reply; 6+ messages in thread
From: Hillf Danton @ 2025-02-08 11:35 UTC (permalink / raw)
To: syzbot; +Cc: linux-kernel, syzkaller-bugs
On Fri, 07 Feb 2025 21:02:23 -0800
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 7ee983c850b4 Merge tag 'drm-fixes-2025-02-08' of https://g..
> git tree: upstream
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17148bdf980000
#syz test
--- x/net/netrom/nr_route.c
+++ y/net/netrom/nr_route.c
@@ -100,6 +100,7 @@ static int __must_check nr_add_node(ax25
{
struct nr_node *nr_node;
struct nr_neigh *nr_neigh;
+ struct nr_neigh *victim = NULL;
int i, found;
struct net_device *odev;
@@ -245,8 +246,9 @@ static int __must_check nr_add_node(ax25
nr_node->routes[2].neighbour->count--;
nr_neigh_put(nr_node->routes[2].neighbour);
- if (nr_node->routes[2].neighbour->count == 0 && !nr_node->routes[2].neighbour->locked)
- nr_remove_neigh(nr_node->routes[2].neighbour);
+ if (nr_node->routes[2].neighbour->count == 0 &&
+ !nr_node->routes[2].neighbour->locked)
+ victim = nr_node->routes[2].neighbour;
nr_node->routes[2].quality = quality;
nr_node->routes[2].obs_count = obs_count;
@@ -281,6 +283,8 @@ static int __must_check nr_add_node(ax25
nr_neigh_put(nr_neigh);
nr_node_unlock(nr_node);
+ if (victim)
+ nr_remove_neigh(victim);
nr_node_put(nr_node);
return 0;
}
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [syzbot] [hams?] possible deadlock in nr_remove_neigh (2)
2025-02-08 11:35 ` Hillf Danton
@ 2025-02-08 12:06 ` syzbot
0 siblings, 0 replies; 6+ messages in thread
From: syzbot @ 2025-02-08 12:06 UTC (permalink / raw)
To: hdanton, linux-kernel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: slab-use-after-free Read in nr_add_node
==================================================================
BUG: KASAN: slab-use-after-free in nr_add_node+0x2c1c/0x2e70 net/netrom/nr_route.c:249
Read of size 4 at addr ffff888035aff930 by task syz-executor312/14225
CPU: 1 UID: 0 PID: 14225 Comm: syz-executor312 Not tainted 6.14.0-rc1-syzkaller-00187-g8f6629c004b1-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
print_address_description mm/kasan/report.c:378 [inline]
print_report+0xc3/0x620 mm/kasan/report.c:489
kasan_report+0xd9/0x110 mm/kasan/report.c:602
nr_add_node+0x2c1c/0x2e70 net/netrom/nr_route.c:249
nr_rt_ioctl+0x1270/0x2c60 net/netrom/nr_route.c:655
nr_ioctl+0x19a/0x2e0 net/netrom/af_netrom.c:1254
sock_do_ioctl+0x116/0x280 net/socket.c:1199
sock_ioctl+0x228/0x6c0 net/socket.c:1318
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ff70bb692e9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 1f 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffeba91c178 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007ff70bb692e9
RDX: 0000200000000000 RSI: 000000000000890b RDI: 0000000000000008
RBP: 0000000000000000 R08: 00007ffeba91c1b0 R09: 00007ffeba91c1b0
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffeba91c198
R13: 00007ffeba91c1d0 R14: 00000000000000dc R15: 431bde82d7b634db
</TASK>
Allocated by task 14217:
kasan_save_stack+0x33/0x60 mm/kasan/common.c:47
kasan_save_track+0x14/0x30 mm/kasan/common.c:68
poison_kmalloc_redzone mm/kasan/common.c:377 [inline]
__kasan_kmalloc+0xaa/0xb0 mm/kasan/common.c:394
kmalloc_noprof include/linux/slab.h:901 [inline]
nr_add_node+0xf86/0x2e70 net/netrom/nr_route.c:147
nr_rt_ioctl+0x1270/0x2c60 net/netrom/nr_route.c:655
nr_ioctl+0x19a/0x2e0 net/netrom/af_netrom.c:1254
sock_do_ioctl+0x116/0x280 net/socket.c:1199
sock_ioctl+0x228/0x6c0 net/socket.c:1318
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Freed by task 14225:
kasan_save_stack+0x33/0x60 mm/kasan/common.c:47
kasan_save_track+0x14/0x30 mm/kasan/common.c:68
kasan_save_free_info+0x3b/0x60 mm/kasan/generic.c:576
poison_slab_object mm/kasan/common.c:247 [inline]
__kasan_slab_free+0x51/0x70 mm/kasan/common.c:264
kasan_slab_free include/linux/kasan.h:233 [inline]
slab_free_hook mm/slub.c:2353 [inline]
slab_free mm/slub.c:4609 [inline]
kfree+0x2c4/0x4d0 mm/slub.c:4757
nr_neigh_put include/net/netrom.h:143 [inline]
nr_neigh_put include/net/netrom.h:137 [inline]
nr_add_node+0x25db/0x2e70 net/netrom/nr_route.c:247
nr_rt_ioctl+0x1270/0x2c60 net/netrom/nr_route.c:655
nr_ioctl+0x19a/0x2e0 net/netrom/af_netrom.c:1254
sock_do_ioctl+0x116/0x280 net/socket.c:1199
sock_ioctl+0x228/0x6c0 net/socket.c:1318
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
The buggy address belongs to the object at ffff888035aff900
which belongs to the cache kmalloc-64 of size 64
The buggy address is located 48 bytes inside of
freed 64-byte region [ffff888035aff900, ffff888035aff940)
The buggy address belongs to the physical page:
page: refcount:0 mapcount:0 mapping:0000000000000000 index:0xffff888035affe00 pfn:0x35aff
flags: 0xfff00000000200(workingset|node=0|zone=1|lastcpupid=0x7ff)
page_type: f5(slab)
raw: 00fff00000000200 ffff88801b0418c0 ffffea0001f012d0 ffffea0000d58750
raw: ffff888035affe00 000000000020001f 00000000f5000000 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x52820(GFP_ATOMIC|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP), pid 32431, tgid 32431 (syz-executor), ts 397708526704, free_ts 397708295464
set_page_owner include/linux/page_owner.h:32 [inline]
post_alloc_hook+0x181/0x1b0 mm/page_alloc.c:1551
prep_new_page mm/page_alloc.c:1559 [inline]
get_page_from_freelist+0xfce/0x2f80 mm/page_alloc.c:3477
__alloc_frozen_pages_noprof+0x221/0x2470 mm/page_alloc.c:4739
alloc_pages_mpol+0x1fc/0x540 mm/mempolicy.c:2270
alloc_slab_page mm/slub.c:2423 [inline]
allocate_slab mm/slub.c:2587 [inline]
new_slab+0x23d/0x330 mm/slub.c:2640
___slab_alloc+0xc5d/0x1720 mm/slub.c:3826
__slab_alloc.constprop.0+0x56/0xb0 mm/slub.c:3916
__slab_alloc_node mm/slub.c:3991 [inline]
slab_alloc_node mm/slub.c:4152 [inline]
__kmalloc_cache_noprof+0xfa/0x410 mm/slub.c:4320
kmalloc_noprof include/linux/slab.h:901 [inline]
kzalloc_noprof include/linux/slab.h:1037 [inline]
netlbl_secattr_alloc_noprof include/net/netlabel.h:385 [inline]
selinux_netlbl_sock_genattr+0xe8/0x4f0 security/selinux/netlabel.c:78
selinux_netlbl_socket_post_create+0xb0/0x1b0 security/selinux/netlabel.c:404
selinux_socket_post_create+0x2fa/0x7f0 security/selinux/hooks.c:4686
security_socket_post_create+0x247/0x260 security/security.c:4577
__sock_create+0x738/0x8d0 net/socket.c:1571
sock_create net/socket.c:1606 [inline]
__sys_socket_create net/socket.c:1643 [inline]
__sys_socket+0x14f/0x260 net/socket.c:1690
__do_sys_socket net/socket.c:1704 [inline]
__se_sys_socket net/socket.c:1702 [inline]
__x64_sys_socket+0x72/0xb0 net/socket.c:1702
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
page last free pid 32431 tgid 32431 stack trace:
reset_page_owner include/linux/page_owner.h:25 [inline]
free_pages_prepare mm/page_alloc.c:1127 [inline]
free_frozen_pages+0x6db/0xfb0 mm/page_alloc.c:2660
vfree+0x174/0x950 mm/vmalloc.c:3383
copy_entries_to_user net/ipv4/netfilter/arp_tables.c:713 [inline]
get_entries net/ipv4/netfilter/arp_tables.c:867 [inline]
do_arpt_get_ctl+0x846/0x9a0 net/ipv4/netfilter/arp_tables.c:1461
nf_getsockopt+0x79/0xe0 net/netfilter/nf_sockopt.c:116
ip_getsockopt+0x18e/0x1e0 net/ipv4/ip_sockglue.c:1777
tcp_getsockopt+0x9e/0x100 net/ipv4/tcp.c:4671
do_sock_getsockopt+0x3fe/0x800 net/socket.c:2364
__sys_getsockopt+0x12f/0x260 net/socket.c:2393
__do_sys_getsockopt net/socket.c:2400 [inline]
__se_sys_getsockopt net/socket.c:2397 [inline]
__x64_sys_getsockopt+0xbd/0x160 net/socket.c:2397
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Memory state around the buggy address:
ffff888035aff800: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
ffff888035aff880: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
>ffff888035aff900: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
^
ffff888035aff980: 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc fc
ffff888035affa00: fa fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
==================================================================
Tested on:
commit: 8f6629c0 kbuild: Move -Wenum-enum-conversion to W=2
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1699cb18580000
kernel config: https://syzkaller.appspot.com/x/.config?x=a7ddf49cf33ba213
dashboard link: https://syzkaller.appspot.com/bug?extid=8863ad36d31449b4dc17
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=1309cb18580000
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [syzbot] [hams?] possible deadlock in nr_remove_neigh (2)
2025-02-08 5:02 ` syzbot
2025-02-08 11:35 ` Hillf Danton
@ 2025-02-08 23:45 ` Hillf Danton
2025-02-09 0:51 ` syzbot
1 sibling, 1 reply; 6+ messages in thread
From: Hillf Danton @ 2025-02-08 23:45 UTC (permalink / raw)
To: syzbot; +Cc: linux-kernel, syzkaller-bugs
On Fri, 07 Feb 2025 21:02:23 -0800
> syzbot has found a reproducer for the following issue on:
>
> HEAD commit: 7ee983c850b4 Merge tag 'drm-fixes-2025-02-08' of https://g..
> git tree: upstream
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17148bdf980000
#syz test
--- x/net/netrom/nr_route.c
+++ y/net/netrom/nr_route.c
@@ -100,6 +100,7 @@ static int __must_check nr_add_node(ax25
{
struct nr_node *nr_node;
struct nr_neigh *nr_neigh;
+ struct nr_neigh *victim = NULL;
int i, found;
struct net_device *odev;
@@ -243,10 +244,9 @@ static int __must_check nr_add_node(ax25
/* It must be better than the worst */
if (quality > nr_node->routes[2].quality) {
nr_node->routes[2].neighbour->count--;
- nr_neigh_put(nr_node->routes[2].neighbour);
if (nr_node->routes[2].neighbour->count == 0 && !nr_node->routes[2].neighbour->locked)
- nr_remove_neigh(nr_node->routes[2].neighbour);
+ victim = nr_node->routes[2].neighbour;
nr_node->routes[2].quality = quality;
nr_node->routes[2].obs_count = obs_count;
@@ -281,6 +281,8 @@ static int __must_check nr_add_node(ax25
nr_neigh_put(nr_neigh);
nr_node_unlock(nr_node);
+ if (victim)
+ nr_remove_neigh(victim);
nr_node_put(nr_node);
return 0;
}
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [syzbot] [hams?] possible deadlock in nr_remove_neigh (2)
2025-02-08 23:45 ` Hillf Danton
@ 2025-02-09 0:51 ` syzbot
0 siblings, 0 replies; 6+ messages in thread
From: syzbot @ 2025-02-09 0:51 UTC (permalink / raw)
To: hdanton, linux-kernel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger any issue:
Reported-by: syzbot+8863ad36d31449b4dc17@syzkaller.appspotmail.com
Tested-by: syzbot+8863ad36d31449b4dc17@syzkaller.appspotmail.com
Tested on:
commit: 9946eaf5 Merge tag 'hardening-v6.14-rc2' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=109902a4580000
kernel config: https://syzkaller.appspot.com/x/.config?x=a7ddf49cf33ba213
dashboard link: https://syzkaller.appspot.com/bug?extid=8863ad36d31449b4dc17
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=12b32b18580000
Note: testing is done by a robot and is best-effort only.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-02-09 0:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-30 2:36 [syzbot] [hams?] possible deadlock in nr_remove_neigh (2) syzbot
2025-02-08 5:02 ` syzbot
2025-02-08 11:35 ` Hillf Danton
2025-02-08 12:06 ` syzbot
2025-02-08 23:45 ` Hillf Danton
2025-02-09 0:51 ` syzbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox