public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [syzbot] [bluetooth?] general protection fault in h5_recv
@ 2025-02-09 15:45 syzbot
  2025-02-10 11:03 ` Hillf Danton
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: syzbot @ 2025-02-09 15:45 UTC (permalink / raw)
  To: linux-bluetooth, linux-kernel, luiz.dentz, marcel, syzkaller-bugs

Hello,

syzbot found the following issue on:

HEAD commit:    ed58d103e6da Add linux-next specific files for 20250207
git tree:       linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=11d782a4580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=244a34ec1429746
dashboard link: https://syzkaller.appspot.com/bug?extid=b5691bb559396b262064
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=137f2bdf980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ce459b7174dd/disk-ed58d103.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/60699733c0c8/vmlinux-ed58d103.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f589bce7c898/bzImage-ed58d103.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b5691bb559396b262064@syzkaller.appspotmail.com

Oops: general protection fault, probably for non-canonical address 0xdffffc000000005f: 0000 [#1] PREEMPT SMP KASAN PTI
KASAN: null-ptr-deref in range [0x00000000000002f8-0x00000000000002ff]
CPU: 1 UID: 0 PID: 9956 Comm: syz.2.1414 Not tainted 6.14.0-rc1-next-20250207-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
RIP: 0010:h5_recv+0x153/0x940 drivers/bluetooth/hci_h5.c:572
Code: 08 01 44 8b 64 24 04 48 8b 5c 24 08 4c 8b 74 24 18 49 ff c7 41 ff cc 45 85 e4 0f 8e 55 06 00 00 e8 e2 f5 f5 f8 48 8b 44 24 30 <42> 80 3c 28 00 74 08 48 89 df e8 be d1 5c f9 48 8b 1b 31 ff 48 89
RSP: 0000:ffffc90004cafc60 EFLAGS: 00010202
RAX: 000000000000005f RBX: 00000000000002f8 RCX: 0000000000000061
RDX: ffff888033690000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90004cafd70 R08: ffffffff88c9927e R09: 1ffff110048c0403
R10: dffffc0000000000 R11: ffffffff88c991c0 R12: 0000000000000001
R13: dffffc0000000000 R14: ffff888024602000 R15: ffffc90004cafe00
FS:  00007f50a01cf6c0(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000040000001f000 CR3: 0000000028c32000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 hci_uart_tty_receive+0x141/0x1c0 drivers/bluetooth/hci_ldisc.c:622
 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299
 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2716
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:906 [inline]
 __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:892
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f509f38cde9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f50a01cf038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f509f5a6080 RCX: 00007f509f38cde9
RDX: 0000400000000180 RSI: 0000000000005412 RDI: 0000000000000003
RBP: 00007f509f40e2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f509f5a6080 R15: 00007ffed807d2a8
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:h5_recv+0x153/0x940 drivers/bluetooth/hci_h5.c:572
Code: 08 01 44 8b 64 24 04 48 8b 5c 24 08 4c 8b 74 24 18 49 ff c7 41 ff cc 45 85 e4 0f 8e 55 06 00 00 e8 e2 f5 f5 f8 48 8b 44 24 30 <42> 80 3c 28 00 74 08 48 89 df e8 be d1 5c f9 48 8b 1b 31 ff 48 89
RSP: 0000:ffffc90004cafc60 EFLAGS: 00010202
RAX: 000000000000005f RBX: 00000000000002f8 RCX: 0000000000000061
RDX: ffff888033690000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90004cafd70 R08: ffffffff88c9927e R09: 1ffff110048c0403
R10: dffffc0000000000 R11: ffffffff88c991c0 R12: 0000000000000001
R13: dffffc0000000000 R14: ffff888024602000 R15: ffffc90004cafe00
FS:  00007f50a01cf6c0(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000028c32000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	08 01                	or     %al,(%rcx)
   2:	44 8b 64 24 04       	mov    0x4(%rsp),%r12d
   7:	48 8b 5c 24 08       	mov    0x8(%rsp),%rbx
   c:	4c 8b 74 24 18       	mov    0x18(%rsp),%r14
  11:	49 ff c7             	inc    %r15
  14:	41 ff cc             	dec    %r12d
  17:	45 85 e4             	test   %r12d,%r12d
  1a:	0f 8e 55 06 00 00    	jle    0x675
  20:	e8 e2 f5 f5 f8       	call   0xf8f5f607
  25:	48 8b 44 24 30       	mov    0x30(%rsp),%rax
* 2a:	42 80 3c 28 00       	cmpb   $0x0,(%rax,%r13,1) <-- trapping instruction
  2f:	74 08                	je     0x39
  31:	48 89 df             	mov    %rbx,%rdi
  34:	e8 be d1 5c f9       	call   0xf95cd1f7
  39:	48 8b 1b             	mov    (%rbx),%rbx
  3c:	31 ff                	xor    %edi,%edi
  3e:	48                   	rex.W
  3f:	89                   	.byte 0x89


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] [bluetooth?] general protection fault in h5_recv
  2025-02-09 15:45 [syzbot] [bluetooth?] general protection fault in h5_recv syzbot
@ 2025-02-10 11:03 ` Hillf Danton
  2025-02-10 11:47   ` syzbot
  2025-02-11  7:05 ` syzbot
  2025-02-12  0:12 ` syzbot
  2 siblings, 1 reply; 5+ messages in thread
From: Hillf Danton @ 2025-02-10 11:03 UTC (permalink / raw)
  To: syzbot; +Cc: linux-kernel, syzkaller-bugs

On Sun, 09 Feb 2025 07:45:19 -0800
> syzbot found the following issue on:
> 
> HEAD commit:    ed58d103e6da Add linux-next specific files for 20250207
> git tree:       linux-next
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=137f2bdf980000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  master

--- x/drivers/bluetooth/hci_ldisc.c
+++ y/drivers/bluetooth/hci_ldisc.c
@@ -711,6 +711,7 @@ static int hci_uart_set_proto(struct hci
 
 	err = hci_uart_register_dev(hu);
 	if (err) {
+		clear_bit(HCI_UART_PROTO_READY, &hu->flags);
 		return err;
 	}
 
--

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] [bluetooth?] general protection fault in h5_recv
  2025-02-10 11:03 ` Hillf Danton
@ 2025-02-10 11:47   ` syzbot
  0 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2025-02-10 11:47 UTC (permalink / raw)
  To: hdanton, linux-kernel, syzkaller-bugs

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+b5691bb559396b262064@syzkaller.appspotmail.com
Tested-by: syzbot+b5691bb559396b262064@syzkaller.appspotmail.com

Tested on:

commit:         df5d6180 Add linux-next specific files for 20250210
git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=12b3c2a4580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=2cd616b6e736ca7
dashboard link: https://syzkaller.appspot.com/bug?extid=b5691bb559396b262064
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=117dc2a4580000

Note: testing is done by a robot and is best-effort only.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] [bluetooth?] general protection fault in h5_recv
  2025-02-09 15:45 [syzbot] [bluetooth?] general protection fault in h5_recv syzbot
  2025-02-10 11:03 ` Hillf Danton
@ 2025-02-11  7:05 ` syzbot
  2025-02-12  0:12 ` syzbot
  2 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2025-02-11  7:05 UTC (permalink / raw)
  To: hdanton, linux-bluetooth, linux-kernel, luiz.dentz, marcel,
	syzkaller-bugs

syzbot has found a reproducer for the following issue on:

HEAD commit:    df5d6180169a Add linux-next specific files for 20250210
git tree:       linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=14a9c3f8580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=2cd616b6e736ca7
dashboard link: https://syzkaller.appspot.com/bug?extid=b5691bb559396b262064
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=149c78e4580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=129c78e4580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/92495cf20271/disk-df5d6180.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4b3656161842/vmlinux-df5d6180.xz
kernel image: https://storage.googleapis.com/syzbot-assets/7fbc4e7a0f5d/bzImage-df5d6180.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b5691bb559396b262064@syzkaller.appspotmail.com

Oops: general protection fault, probably for non-canonical address 0xdffffc000000005f: 0000 [#1] PREEMPT SMP KASAN PTI
KASAN: null-ptr-deref in range [0x00000000000002f8-0x00000000000002ff]
CPU: 1 UID: 0 PID: 5834 Comm: syz-executor200 Not tainted 6.14.0-rc2-next-20250210-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
RIP: 0010:h5_recv+0x153/0x940 drivers/bluetooth/hci_h5.c:572
Code: 08 01 44 8b 64 24 04 48 8b 5c 24 08 4c 8b 74 24 18 49 ff c7 41 ff cc 45 85 e4 0f 8e 55 06 00 00 e8 a2 58 f5 f8 48 8b 44 24 30 <42> 80 3c 28 00 74 08 48 89 df e8 ce 53 5c f9 48 8b 1b 31 ff 48 89
RSP: 0018:ffffc90003e8fc60 EFLAGS: 00010202
RAX: 000000000000005f RBX: 00000000000002f8 RCX: 0000000000000061
RDX: ffff8880350dda00 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90003e8fd70 R08: ffffffff88ca308e R09: 1ffff110062cdb03
R10: dffffc0000000000 R11: ffffffff88ca2fd0 R12: 0000000000000001
R13: dffffc0000000000 R14: ffff88803166d800 R15: ffffc90003e8fe00
FS:  00007f38f1dd06c0(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f38f1d8ed58 CR3: 000000007b704000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 hci_uart_tty_receive+0x141/0x1c0 drivers/bluetooth/hci_ldisc.c:622
 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299
 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2716
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:906 [inline]
 __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:892
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f38f1e183d9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f38f1dd0218 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f38f1e9f328 RCX: 00007f38f1e183d9
RDX: 0000400000000040 RSI: 0000000000005412 RDI: 0000000000000006
RBP: 00007f38f1e9f320 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f38f1e6c074
R13: 0000400000000300 R14: 00004000000000c0 R15: 0000400000000040
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:h5_recv+0x153/0x940 drivers/bluetooth/hci_h5.c:572
Code: 08 01 44 8b 64 24 04 48 8b 5c 24 08 4c 8b 74 24 18 49 ff c7 41 ff cc 45 85 e4 0f 8e 55 06 00 00 e8 a2 58 f5 f8 48 8b 44 24 30 <42> 80 3c 28 00 74 08 48 89 df e8 ce 53 5c f9 48 8b 1b 31 ff 48 89
RSP: 0018:ffffc90003e8fc60 EFLAGS: 00010202
RAX: 000000000000005f RBX: 00000000000002f8 RCX: 0000000000000061
RDX: ffff8880350dda00 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90003e8fd70 R08: ffffffff88ca308e R09: 1ffff110062cdb03
R10: dffffc0000000000 R11: ffffffff88ca2fd0 R12: 0000000000000001
R13: dffffc0000000000 R14: ffff88803166d800 R15: ffffc90003e8fe00
FS:  00007f38f1dd06c0(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000040000000f000 CR3: 000000007b704000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	08 01                	or     %al,(%rcx)
   2:	44 8b 64 24 04       	mov    0x4(%rsp),%r12d
   7:	48 8b 5c 24 08       	mov    0x8(%rsp),%rbx
   c:	4c 8b 74 24 18       	mov    0x18(%rsp),%r14
  11:	49 ff c7             	inc    %r15
  14:	41 ff cc             	dec    %r12d
  17:	45 85 e4             	test   %r12d,%r12d
  1a:	0f 8e 55 06 00 00    	jle    0x675
  20:	e8 a2 58 f5 f8       	call   0xf8f558c7
  25:	48 8b 44 24 30       	mov    0x30(%rsp),%rax
* 2a:	42 80 3c 28 00       	cmpb   $0x0,(%rax,%r13,1) <-- trapping instruction
  2f:	74 08                	je     0x39
  31:	48 89 df             	mov    %rbx,%rdi
  34:	e8 ce 53 5c f9       	call   0xf95c5407
  39:	48 8b 1b             	mov    (%rbx),%rbx
  3c:	31 ff                	xor    %edi,%edi
  3e:	48                   	rex.W
  3f:	89                   	.byte 0x89


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [syzbot] [bluetooth?] general protection fault in h5_recv
  2025-02-09 15:45 [syzbot] [bluetooth?] general protection fault in h5_recv syzbot
  2025-02-10 11:03 ` Hillf Danton
  2025-02-11  7:05 ` syzbot
@ 2025-02-12  0:12 ` syzbot
  2 siblings, 0 replies; 5+ messages in thread
From: syzbot @ 2025-02-12  0:12 UTC (permalink / raw)
  To: avkrasnov, hdanton, linux-bluetooth, linux-kernel, luiz.dentz,
	luiz.von.dentz, marcel, syzkaller-bugs

syzbot has bisected this issue to:

commit c411c62cc13319533b1861e00cedc4883c3bc1bb
Author: Arseniy Krasnov <avkrasnov@salutedevices.com>
Date:   Thu Jan 30 18:43:26 2025 +0000

    Bluetooth: hci_uart: fix race during initialization

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=138cdbdf980000
start commit:   df5d6180169a Add linux-next specific files for 20250210
git tree:       linux-next
final oops:     https://syzkaller.appspot.com/x/report.txt?x=104cdbdf980000
console output: https://syzkaller.appspot.com/x/log.txt?x=178cdbdf980000
kernel config:  https://syzkaller.appspot.com/x/.config?x=2cd616b6e736ca7
dashboard link: https://syzkaller.appspot.com/bug?extid=b5691bb559396b262064
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=149c78e4580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=129c78e4580000

Reported-by: syzbot+b5691bb559396b262064@syzkaller.appspotmail.com
Fixes: c411c62cc133 ("Bluetooth: hci_uart: fix race during initialization")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-02-12  0:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-09 15:45 [syzbot] [bluetooth?] general protection fault in h5_recv syzbot
2025-02-10 11:03 ` Hillf Danton
2025-02-10 11:47   ` syzbot
2025-02-11  7:05 ` syzbot
2025-02-12  0:12 ` syzbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox