public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in dtDelete
@ 2025-03-18 19:54 syzbot
  2025-04-18  3:25 ` [syzbot] " syzbot
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: syzbot @ 2025-03-18 19:54 UTC (permalink / raw)
  To: jfs-discussion, linux-kernel, shaggy, syzkaller-bugs

Hello,

syzbot found the following issue on:

HEAD commit:    e3a854b577cb Merge tag 'clk-fixes-for-linus' of git://git...
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=111b1fa8580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=eb44f62cb82f8a0a
dashboard link: https://syzkaller.appspot.com/bug?extid=4f9c823a6f63d87491ba
compiler:       Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=1484dc78580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=151b1fa8580000

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-e3a854b5.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/80a4e52e75a6/vmlinux-e3a854b5.xz
kernel image: https://storage.googleapis.com/syzbot-assets/e261756ed740/bzImage-e3a854b5.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/7fd9c181a987/mount_0.gz
  fsck result: failed (log: https://syzkaller.appspot.com/x/fsck.log?x=135a419b980000)

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+4f9c823a6f63d87491ba@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 32768
------------[ cut here ]------------
UBSAN: array-index-out-of-bounds in fs/jfs/jfs_dtree.c:2132:32
index 240 is out of range for type 'struct dtslot[128]'
CPU: 0 UID: 0 PID: 5303 Comm: syz-executor483 Not tainted 6.14.0-rc6-syzkaller-00115-ge3a854b577cb #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 ubsan_epilogue lib/ubsan.c:231 [inline]
 __ubsan_handle_out_of_bounds+0x121/0x150 lib/ubsan.c:429
 dtDelete+0x2d67/0x2db0 fs/jfs/jfs_dtree.c:2132
 jfs_rename+0xf91/0x1bf0 fs/jfs/namei.c:1239
 vfs_rename+0xbdb/0xf00 fs/namei.c:5069
 do_renameat2+0xd94/0x13f0 fs/namei.c:5226
 __do_sys_rename fs/namei.c:5273 [inline]
 __se_sys_rename fs/namei.c:5271 [inline]
 __x64_sys_rename+0x82/0x90 fs/namei.c:5271
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fc873bc9bb9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff24dc46e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 0000400000000e00 RCX: 00007fc873bc9bb9
RDX: 00007fc873bc9bb9 RSI: 0000400000000f40 RDI: 0000400000000300
RBP: 00007fc873c42610 R08: 00007fff24dc48b8 R09: 00007fff24dc48b8
R10: 00007fff24dc48b8 R11: 0000000000000246 R12: 0000000000000001
R13: 00007fff24dc48a8 R14: 0000000000000001 R15: 0000000000000001
 </TASK>
---[ end trace ]---


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in dtDelete
@ 2025-03-19  2:26 Leonardo Hirata
  2025-03-19  2:43 ` syzbot
  0 siblings, 1 reply; 9+ messages in thread
From: Leonardo Hirata @ 2025-03-19  2:26 UTC (permalink / raw)
  To: syzbot+4f9c823a6f63d87491ba
  Cc: jfs-discussion, linux-kernel, shaggy, syzkaller-bugs


[-- Attachment #1.1: Type: text/plain, Size: 10 bytes --]

#syz test

[-- Attachment #1.2: Type: text/html, Size: 31 bytes --]

[-- Attachment #2: 0001-jfs-Add-check-for-array-bounds-in-dtReadFirst.patch --]
[-- Type: text/x-patch, Size: 906 bytes --]

From d2015dde38d6f730eabdc613eb26f7c59daa9cab Mon Sep 17 00:00:00 2001
From: Leonardo Felipe Takao Hirata <leo.fthirata@gmail.com>
Date: Tue, 18 Mar 2025 22:03:57 -0300
Subject: [PATCH] jfs: Add check for array bounds in dtReadFirst

Add a check for index out of bound.

Signed-off-by: Leonardo Felipe Takao Hirata <leo.fthirata@gmail.com>
---
 fs/jfs/jfs_dtree.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c
index 8f85177f284b..4e29f8c7d624 100644
--- a/fs/jfs/jfs_dtree.c
+++ b/fs/jfs/jfs_dtree.c
@@ -2128,6 +2128,13 @@ int dtDelete(tid_t tid,
 					next_index = -1;
 				else {
 					stbl = DT_GETSTBL(np);
+
+					if (stbl[0] < 0 || stbl[0] > 127) {
+						DT_PUTPAGE(mp);
+						jfs_error(ip->i_sb, "stbl[0] out of bound\n");
+						return -EIO;
+					}
+
 					ldtentry =
 					    (struct ldtentry *) & np->
 					    slot[stbl[0]];
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread
[parent not found: <20250418032543.128924-1-richard120310@gmail.com>]
[parent not found: <825ad453-7347-4af7-8a14-3aaf678c83a6n@googlegroups.com>]

end of thread, other threads:[~2025-09-19 15:45 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-18 19:54 [syzbot] [jfs?] UBSAN: array-index-out-of-bounds in dtDelete syzbot
2025-04-18  3:25 ` [syzbot] " syzbot
2025-09-18 21:04 ` [PATCH] jfs: Add check for array bounds " Pedro Demarchi Gomes
2025-09-18 21:27   ` [syzbot] [jfs?] UBSAN: array-index-out-of-bounds " syzbot
2025-09-19 15:23 ` Forwarded: " syzbot
  -- strict thread matches above, loose matches on Subject: below --
2025-03-19  2:26 Leonardo Hirata
2025-03-19  2:43 ` syzbot
     [not found] <20250418032543.128924-1-richard120310@gmail.com>
2025-04-18  3:53 ` syzbot
     [not found] <825ad453-7347-4af7-8a14-3aaf678c83a6n@googlegroups.com>
2025-09-19 15:45 ` syzbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox