* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 11:53 [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth syzbot
@ 2025-04-08 14:17 ` Qasim Ijaz
2025-04-08 14:30 ` Edward Adam Davis
` (5 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Qasim Ijaz @ 2025-04-08 14:17 UTC (permalink / raw)
To: johannes, linux-kernel, linux-wireless, netdev, syzkaller-bugs
On Tue, Apr 08, 2025 at 04:53:34AM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 0af2f6be1b42 Linux 6.15-rc1
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=1284523f980000
> kernel config: https://syzkaller.appspot.com/x/.config?x=66996a2350ef05e0
> dashboard link: https://syzkaller.appspot.com/bug?extid=00778a9a557a2a5e1a33
> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13c9eb4c580000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=179bbd98580000
>
> Downloadable assets:
> disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-0af2f6be.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/3fcfb8eefe4d/vmlinux-0af2f6be.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/e06a39be2bd8/bzImage-0af2f6be.xz
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+00778a9a557a2a5e1a33@syzkaller.appspotmail.com
>
> Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI
> KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
I done some analysis and it looks like during cfg80211_conn_work() the
wdev->conn->params.bssid is NULL, this gets passed to cfg80211_conn_do_work()
which hits the CFG80211_CONN_ASSOC_FAILED label of the switch statement where
ether_addr_equal() compares the NULL bssid via ether_addr_equal().
Regards,
Qasim
> CPU: 0 UID: 0 PID: 4854 Comm: kworker/0:3 Not tainted 6.15.0-rc1-syzkaller #0 PREEMPT(full)
> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
> Workqueue: events cfg80211_conn_work
> RIP: 0010:ether_addr_equal include/linux/etherdevice.h:355 [inline]
> RIP: 0010:cfg80211_mlme_deauth+0x35a/0x940 net/wireless/mlme.c:514
> Code: 8d 9c 24 b0 00 00 00 48 89 d8 48 c1 e8 03 42 0f b6 04 28 84 c0 4c 8b 7c 24 28 0f 85 25 03 00 00 44 8b 23 4c 89 f8 48 c1 e8 03 <42> 0f b6 04 28 84 c0 0f 85 2b 03 00 00 45 8b 37 48 8b 44 24 20 48
> RSP: 0018:ffffc90002cdf180 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: ffff888045820e40 RCX: ffff888000b5c880
> RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
> RBP: ffffc90002cdf268 R08: ffffffff8b8395d8 R09: 0000000000000003
> R10: 0000000000000009 R11: ffff888000b5c880 R12: 0000000000000000
> R13: dffffc0000000000 R14: 0000000000000003 R15: 0000000000000000
> FS: 0000000000000000(0000) GS:ffff88808c596000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007f25d8438198 CR3: 000000001f4b4000 CR4: 0000000000352ef0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> cfg80211_conn_do_work+0x369/0xed0 net/wireless/sme.c:229
> cfg80211_conn_work+0x2c2/0x530 net/wireless/sme.c:273
> process_one_work kernel/workqueue.c:3238 [inline]
> process_scheduled_works+0xac3/0x18e0 kernel/workqueue.c:3319
> worker_thread+0x870/0xd50 kernel/workqueue.c:3400
> kthread+0x7b7/0x940 kernel/kthread.c:464
> ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153
> ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
> </TASK>
> Modules linked in:
> ---[ end trace 0000000000000000 ]---
> RIP: 0010:ether_addr_equal include/linux/etherdevice.h:355 [inline]
> RIP: 0010:cfg80211_mlme_deauth+0x35a/0x940 net/wireless/mlme.c:514
> Code: 8d 9c 24 b0 00 00 00 48 89 d8 48 c1 e8 03 42 0f b6 04 28 84 c0 4c 8b 7c 24 28 0f 85 25 03 00 00 44 8b 23 4c 89 f8 48 c1 e8 03 <42> 0f b6 04 28 84 c0 0f 85 2b 03 00 00 45 8b 37 48 8b 44 24 20 48
> RSP: 0018:ffffc90002cdf180 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: ffff888045820e40 RCX: ffff888000b5c880
> RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
> RBP: ffffc90002cdf268 R08: ffffffff8b8395d8 R09: 0000000000000003
> R10: 0000000000000009 R11: ffff888000b5c880 R12: 0000000000000000
> R13: dffffc0000000000 R14: 0000000000000003 R15: 0000000000000000
> FS: 0000000000000000(0000) GS:ffff88808c596000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007f25d8438198 CR3: 000000001f4b4000 CR4: 0000000000352ef0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> ----------------
> Code disassembly (best guess):
> 0: 8d 9c 24 b0 00 00 00 lea 0xb0(%rsp),%ebx
> 7: 48 89 d8 mov %rbx,%rax
> a: 48 c1 e8 03 shr $0x3,%rax
> e: 42 0f b6 04 28 movzbl (%rax,%r13,1),%eax
> 13: 84 c0 test %al,%al
> 15: 4c 8b 7c 24 28 mov 0x28(%rsp),%r15
> 1a: 0f 85 25 03 00 00 jne 0x345
> 20: 44 8b 23 mov (%rbx),%r12d
> 23: 4c 89 f8 mov %r15,%rax
> 26: 48 c1 e8 03 shr $0x3,%rax
> * 2a: 42 0f b6 04 28 movzbl (%rax,%r13,1),%eax <-- trapping instruction
> 2f: 84 c0 test %al,%al
> 31: 0f 85 2b 03 00 00 jne 0x362
> 37: 45 8b 37 mov (%r15),%r14d
> 3a: 48 8b 44 24 20 mov 0x20(%rsp),%rax
> 3f: 48 rex.W
>
>
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@googlegroups.com.
>
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>
> If the report is already addressed, let syzbot know by replying with:
> #syz fix: exact-commit-title
>
> If you want syzbot to run the reproducer, reply with:
> #syz test: git://repo/address.git branch-or-commit-hash
> If you attach or paste a git patch, syzbot will apply it before testing.
>
> If you want to overwrite report's subsystems, reply with:
> #syz set subsystems: new-subsystem
> (See the list of subsystem names on the web dashboard)
>
> If the report is a duplicate of another one, reply with:
> #syz dup: exact-subject-of-another-report
>
> If you want to undo deduplication, reply with:
> #syz undup
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 11:53 [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth syzbot
2025-04-08 14:17 ` Qasim Ijaz
@ 2025-04-08 14:30 ` Edward Adam Davis
2025-04-08 14:48 ` syzbot
2025-04-09 0:34 ` Edward Adam Davis
` (4 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Edward Adam Davis @ 2025-04-08 14:30 UTC (permalink / raw)
To: syzbot+00778a9a557a2a5e1a33; +Cc: linux-kernel, syzkaller-bugs
#syz test
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index cf998500a965..916c9e8fea15 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -268,6 +268,12 @@ void cfg80211_conn_work(struct work_struct *work)
if (wdev->conn->params.bssid) {
memcpy(bssid_buf, wdev->conn->params.bssid, ETH_ALEN);
bssid = bssid_buf;
+ } else {
+ if (wdev->conn->state == CFG80211_CONN_ASSOC_FAILED && wdev->conn->bssid) {
+ wdev->conn->params.bssid = wdev->conn->bssid;
+ memcpy(bssid_buf, wdev->conn->bssid, ETH_ALEN);
+ bssid = bssid_buf;
+ }
}
treason = NL80211_TIMEOUT_UNSPECIFIED;
if (cfg80211_conn_do_work(wdev, &treason)) {
@@ -411,6 +417,8 @@ bool cfg80211_sme_rx_assoc_resp(struct wireless_dev *wdev, u16 status)
return true;
}
+ printk("bssid: %p, pbssid: %p, dis bssid: %p, %s\n",
+ wdev->conn->bssid, wdev->conn->params.bssid, wdev->disconnect_bssid, __func__);
wdev->conn->state = CFG80211_CONN_ASSOC_FAILED;
schedule_work(&rdev->conn_work);
return false;
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 14:30 ` Edward Adam Davis
@ 2025-04-08 14:48 ` syzbot
0 siblings, 0 replies; 14+ messages in thread
From: syzbot @ 2025-04-08 14:48 UTC (permalink / raw)
To: eadavis, linux-kernel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
general protection fault in cfg80211_mlme_deauth
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
CPU: 0 UID: 0 PID: 790 Comm: kworker/0:2 Not tainted 6.15.0-rc1-syzkaller-g0af2f6be1b42-dirty #0 PREEMPT(full)
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Workqueue: events cfg80211_conn_work
RIP: 0010:ether_addr_equal include/linux/etherdevice.h:355 [inline]
RIP: 0010:cfg80211_mlme_deauth+0x35a/0x940 net/wireless/mlme.c:514
Code: 8d 9c 24 b0 00 00 00 48 89 d8 48 c1 e8 03 42 0f b6 04 28 84 c0 4c 8b 7c 24 28 0f 85 25 03 00 00 44 8b 23 4c 89 f8 48 c1 e8 03 <42> 0f b6 04 28 84 c0 0f 85 2b 03 00 00 45 8b 37 48 8b 44 24 20 48
RSP: 0018:ffffc90001acf160 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff8880437a4e40 RCX: ffff888000784880
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90001acf248 R08: ffffffff8b8395d8 R09: 0000000000000003
R10: 0000000000000009 R11: ffff888000784880 R12: 0000000000000000
R13: dffffc0000000000 R14: 0000000000000003 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff88808c596000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000200000001080 CR3: 0000000011f84000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
cfg80211_conn_do_work+0x369/0xed0 net/wireless/sme.c:229
cfg80211_conn_work+0x35e/0x5b0 net/wireless/sme.c:279
process_one_work kernel/workqueue.c:3238 [inline]
process_scheduled_works+0xac3/0x18e0 kernel/workqueue.c:3319
worker_thread+0x870/0xd50 kernel/workqueue.c:3400
kthread+0x7b7/0x940 kernel/kthread.c:464
ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:ether_addr_equal include/linux/etherdevice.h:355 [inline]
RIP: 0010:cfg80211_mlme_deauth+0x35a/0x940 net/wireless/mlme.c:514
Code: 8d 9c 24 b0 00 00 00 48 89 d8 48 c1 e8 03 42 0f b6 04 28 84 c0 4c 8b 7c 24 28 0f 85 25 03 00 00 44 8b 23 4c 89 f8 48 c1 e8 03 <42> 0f b6 04 28 84 c0 0f 85 2b 03 00 00 45 8b 37 48 8b 44 24 20 48
RSP: 0018:ffffc90001acf160 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff8880437a4e40 RCX: ffff888000784880
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90001acf248 R08: ffffffff8b8395d8 R09: 0000000000000003
R10: 0000000000000009 R11: ffff888000784880 R12: 0000000000000000
R13: dffffc0000000000 R14: 0000000000000003 R15: 0000000000000000
FS: 0000000000000000(0000) GS:ffff88808c596000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000200000001080 CR3: 00000000124d8000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: 8d 9c 24 b0 00 00 00 lea 0xb0(%rsp),%ebx
7: 48 89 d8 mov %rbx,%rax
a: 48 c1 e8 03 shr $0x3,%rax
e: 42 0f b6 04 28 movzbl (%rax,%r13,1),%eax
13: 84 c0 test %al,%al
15: 4c 8b 7c 24 28 mov 0x28(%rsp),%r15
1a: 0f 85 25 03 00 00 jne 0x345
20: 44 8b 23 mov (%rbx),%r12d
23: 4c 89 f8 mov %r15,%rax
26: 48 c1 e8 03 shr $0x3,%rax
* 2a: 42 0f b6 04 28 movzbl (%rax,%r13,1),%eax <-- trapping instruction
2f: 84 c0 test %al,%al
31: 0f 85 2b 03 00 00 jne 0x362
37: 45 8b 37 mov (%r15),%r14d
3a: 48 8b 44 24 20 mov 0x20(%rsp),%rax
3f: 48 rex.W
Tested on:
commit: 0af2f6be Linux 6.15-rc1
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10c8b74c580000
kernel config: https://syzkaller.appspot.com/x/.config?x=66996a2350ef05e0
dashboard link: https://syzkaller.appspot.com/bug?extid=00778a9a557a2a5e1a33
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
patch: https://syzkaller.appspot.com/x/patch.diff?x=15217b4c580000
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 11:53 [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth syzbot
2025-04-08 14:17 ` Qasim Ijaz
2025-04-08 14:30 ` Edward Adam Davis
@ 2025-04-09 0:34 ` Edward Adam Davis
2025-04-09 0:51 ` syzbot
2025-04-09 1:05 ` Edward Adam Davis
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Edward Adam Davis @ 2025-04-09 0:34 UTC (permalink / raw)
To: syzbot+00778a9a557a2a5e1a33; +Cc: linux-kernel, syzkaller-bugs
#syz test
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index cf998500a965..f78071015d93 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -269,6 +269,12 @@ void cfg80211_conn_work(struct work_struct *work)
memcpy(bssid_buf, wdev->conn->params.bssid, ETH_ALEN);
bssid = bssid_buf;
}
+
+ if (wdev->conn->state == CFG80211_CONN_ASSOC_FAILED)
+ printk("bssid: %p, pbssid: %p, dis bssid: %p, connected: %d, %s\n",
+ wdev->conn->bssid, wdev->conn->params.bssid,
+ wdev->disconnect_bssid, wdev->connected, __func__);
+
treason = NL80211_TIMEOUT_UNSPECIFIED;
if (cfg80211_conn_do_work(wdev, &treason)) {
struct cfg80211_connect_resp_params cr;
@@ -411,6 +417,8 @@ bool cfg80211_sme_rx_assoc_resp(struct wireless_dev *wdev, u16 status)
return true;
}
+ printk("bssid: %p, pbssid: %p, dis bssid: %p, %s\n",
+ wdev->conn->bssid, wdev->conn->params.bssid, wdev->disconnect_bssid, __func__);
wdev->conn->state = CFG80211_CONN_ASSOC_FAILED;
schedule_work(&rdev->conn_work);
return false;
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 11:53 [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth syzbot
` (2 preceding siblings ...)
2025-04-09 0:34 ` Edward Adam Davis
@ 2025-04-09 1:05 ` Edward Adam Davis
2025-04-09 1:22 ` syzbot
2025-04-09 1:26 ` Edward Adam Davis
` (2 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Edward Adam Davis @ 2025-04-09 1:05 UTC (permalink / raw)
To: syzbot+00778a9a557a2a5e1a33; +Cc: linux-kernel, syzkaller-bugs
#syz test
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index cf998500a965..f78071015d93 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -269,6 +269,12 @@ void cfg80211_conn_work(struct work_struct *work)
memcpy(bssid_buf, wdev->conn->params.bssid, ETH_ALEN);
bssid = bssid_buf;
}
+
+ if (wdev->conn->state == CFG80211_CONN_ASSOC_FAILED)
+ printk("bssid: %p, pbssid: %p, dis bssid: %p, connected: %d, %s\n",
+ wdev->conn->bssid, wdev->conn->params.bssid,
+ wdev->disconnect_bssid, wdev->connected, __func__);
+
treason = NL80211_TIMEOUT_UNSPECIFIED;
if (cfg80211_conn_do_work(wdev, &treason)) {
struct cfg80211_connect_resp_params cr;
@@ -411,6 +417,8 @@ bool cfg80211_sme_rx_assoc_resp(struct wireless_dev *wdev, u16 status)
return true;
}
+ printk("bssid: %p, pbssid: %p, dis bssid: %p, %s\n",
+ wdev->conn->bssid, wdev->conn->params.bssid, wdev->disconnect_bssid, __func__);
wdev->conn->state = CFG80211_CONN_ASSOC_FAILED;
schedule_work(&rdev->conn_work);
return false;
diff --git a/drivers/net/wireless/virtual/mac80211_hwsim.c b/drivers/net/wireless/virtual/mac80211_hwsim.c
index cf3e976471c6..ee9609d70d72 100644
--- a/drivers/net/wireless/virtual/mac80211_hwsim.c
+++ b/drivers/net/wireless/virtual/mac80211_hwsim.c
@@ -6479,7 +6479,7 @@ static int mac80211_hwsim_netlink_notify(struct notifier_block *nb,
remove_user_radios(notify->portid);
if (notify->portid == hwsim_net_get_wmediumd(notify->net)) {
- printk(KERN_INFO "mac80211_hwsim: wmediumd released netlink"
+ printk_ratelimited(KERN_INFO "mac80211_hwsim: wmediumd released netlink"
" socket, switching to perfect channel medium\n");
hwsim_register_wmediumd(notify->net, 0);
}
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 11:53 [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth syzbot
` (3 preceding siblings ...)
2025-04-09 1:05 ` Edward Adam Davis
@ 2025-04-09 1:26 ` Edward Adam Davis
2025-04-09 1:43 ` syzbot
2025-04-09 5:40 ` Edward Adam Davis
2025-04-09 9:20 ` Edward Adam Davis
6 siblings, 1 reply; 14+ messages in thread
From: Edward Adam Davis @ 2025-04-09 1:26 UTC (permalink / raw)
To: syzbot+00778a9a557a2a5e1a33; +Cc: linux-kernel, syzkaller-bugs
#syz test
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index cf998500a965..b983faa5bbf1 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -269,6 +269,16 @@ void cfg80211_conn_work(struct work_struct *work)
memcpy(bssid_buf, wdev->conn->params.bssid, ETH_ALEN);
bssid = bssid_buf;
}
+
+ if (wdev->conn->state == CFG80211_CONN_ASSOC_FAILED) {
+ printk("bssid: %p, pbssid: %p, dis bssid: %p, connected: %d, %s\n",
+ wdev->conn->bssid, wdev->conn->params.bssid,
+ wdev->disconnect_bssid, wdev->connected, __func__);
+ BUG_ON(!wdev->conn->bssid ||
+ !wdev->conn->params.bssid ||
+ !wdev->disconnect_bssid);
+ }
+
treason = NL80211_TIMEOUT_UNSPECIFIED;
if (cfg80211_conn_do_work(wdev, &treason)) {
struct cfg80211_connect_resp_params cr;
@@ -411,6 +421,8 @@ bool cfg80211_sme_rx_assoc_resp(struct wireless_dev *wdev, u16 status)
return true;
}
+ printk("bssid: %p, pbssid: %p, dis bssid: %p, %s\n",
+ wdev->conn->bssid, wdev->conn->params.bssid, wdev->disconnect_bssid, __func__);
wdev->conn->state = CFG80211_CONN_ASSOC_FAILED;
schedule_work(&rdev->conn_work);
return false;
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 11:53 [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth syzbot
` (4 preceding siblings ...)
2025-04-09 1:26 ` Edward Adam Davis
@ 2025-04-09 5:40 ` Edward Adam Davis
2025-04-09 6:01 ` syzbot
2025-04-09 9:20 ` Edward Adam Davis
6 siblings, 1 reply; 14+ messages in thread
From: Edward Adam Davis @ 2025-04-09 5:40 UTC (permalink / raw)
To: syzbot+00778a9a557a2a5e1a33; +Cc: linux-kernel, syzkaller-bugs
#syz test
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index cf998500a965..39bc68b3428a 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -226,6 +226,9 @@ static int cfg80211_conn_do_work(struct wireless_dev *wdev,
*treason = NL80211_TIMEOUT_ASSOC;
fallthrough;
case CFG80211_CONN_ASSOC_FAILED:
+ BUG_ON(!wdev->conn->bssid);
+ BUG_ON(!wdev->conn->params.bssid);
+ BUG_ON(!wdev->disconnect_bssid);
cfg80211_mlme_deauth(rdev, wdev->netdev, params->bssid,
NULL, 0,
WLAN_REASON_DEAUTH_LEAVING, false);
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth
2025-04-08 11:53 [syzbot] [wireless?] general protection fault in cfg80211_mlme_deauth syzbot
` (5 preceding siblings ...)
2025-04-09 5:40 ` Edward Adam Davis
@ 2025-04-09 9:20 ` Edward Adam Davis
2025-04-09 9:33 ` syzbot
6 siblings, 1 reply; 14+ messages in thread
From: Edward Adam Davis @ 2025-04-09 9:20 UTC (permalink / raw)
To: syzbot+00778a9a557a2a5e1a33; +Cc: linux-kernel, syzkaller-bugs
#syz test: upstream 0af2f6be1b42
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index cf998500a965..39bc68b3428a 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -226,6 +226,9 @@ static int cfg80211_conn_do_work(struct wireless_dev *wdev,
*treason = NL80211_TIMEOUT_ASSOC;
fallthrough;
case CFG80211_CONN_ASSOC_FAILED:
+ BUG_ON(!wdev->conn->bssid);
+ BUG_ON(!wdev->conn->params.bssid);
+ BUG_ON(!wdev->disconnect_bssid);
cfg80211_mlme_deauth(rdev, wdev->netdev, params->bssid,
NULL, 0,
WLAN_REASON_DEAUTH_LEAVING, false);
^ permalink raw reply related [flat|nested] 14+ messages in thread