The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion
@ 2026-07-17 13:25 Marco Giunta
  2026-07-17 13:25 ` [PATCH 1/8] ASoC: aw88399: extract shared device library Marco Giunta
                   ` (9 more replies)
  0 siblings, 10 replies; 15+ messages in thread
From: Marco Giunta @ 2026-07-17 13:25 UTC (permalink / raw)
  To: tiwai
  Cc: perex, lgirdwood, broonie, linux-kernel, linux-sound, rafael,
	lenb, hansg, ilpo.jarvinen, linux-acpi, platform-driver-x86,
	wangweidong.a, nadim, imitoy, munzirtaha, yakov.till,
	Marco Giunta

Several Lenovo Legion laptops (Pro 7i 16IAX10H, Y9000P IAX10,
Pro 7 16AFR10H, R9000P ADR10) use AWINIC AW88399 smart amplifiers
to drive their bass woofers, connected via I2C as side codecs
to a Realtek ALC287 HDA codec.

Without a driver for these amplifiers, only the tweeters produce
sound, resulting in quiet and tinny audio.

An ASoC driver for the AW88399 already exists in-tree
(sound/soc/codecs/aw88399.c), contributed by AWINIC, but it targets
ASoC topologies and cannot drive the chip when it sits behind an
HDA controller. This series adds a proper HDA side codec driver,
following the established pattern used by the CS35L41, CS35L56,
and TAS2781 drivers.

Patch 1 extracts the device-level functions from the existing ASoC
driver into a shared library module (SND_SOC_AW88399_LIB) with a
shared header at include/sound/aw88399.h, following the CS35L41
precedent (SND_SOC_CS35L41_LIB / include/sound/cs35l41.h). This
avoids a build-time dependency on the full ASoC codec module and
ensures clean separation between the ASoC and HDA drivers.

Patches 2 through 5 prepare the shared library for use on ACPI-based
HDA systems: patch 2 extends channel assignment to work without
Device Tree properties, patch 3 adds a per-instance flag to bypass
an unreliable hardware status bit on certain boards, patch 4 adds
a firmware reload flag so that the HDA driver can signal that DSP
firmware needs to be re-uploaded after system sleep, and patch 5
adds a channel setter so that the HDA driver can configure the
amplifier without depending on ASoC-internal device headers.

Patch 6 registers the AWINIC ACPI HID "AWDZ8399" with the ACPI scan
ignore list and the serial-multi-instantiate driver for correct
enumeration of the two amplifier instances.

Patch 7 adds the HDA side codec driver itself, structured after the
CS35L41 HDA driver: an I2C bus driver, and a core driver implementing
HDA component binding, playback hooks, power management, and per-model
quirk matching using ACPI subsystem ID.

Patch 8 enables the driver on Lenovo Legion Pro models by adding
the necessary Realtek ALC287 fixups (DAC rerouting for bass speaker
volume control, internal microphone calibration) and AW88399 per-model
quirks (I2C channel swap correction, BSTS status check bypass).

NOTE ON FIRMWARE: This driver requires the firmware file
aw88399_acf.bin, which uses the same format and request path as the
existing ASoC driver. This firmware is not yet available in the
linux-firmware repository. We intend to coordinate with the AWINIC
maintainers (CC'd) to arrange its inclusion. In the meantime, users
can extract the firmware from the Windows driver and place it in
/lib/firmware/.

This work builds on the initial driver development by Yakov Till
("Lyapsus") and the bounty effort organized by Nadim Kobeissi:
https://github.com/nadimkobeissi/16iax10h-linux-sound-saga

Marco Giunta (8):
  ASoC: aw88399: extract shared device library
  ASoC: aw88399: derive channel from I2C address on ACPI systems
  ASoC: aw88399: add per-instance BSTS status bypass flag
  ASoC: aw88399: add firmware reload flag for resume
  ASoC: aw88399: add channel setter for HDA side codec
  ACPI/platform: add AWDZ8399 to serial-multi-instantiate
  ALSA: hda/scodec: add AW88399 HDA side codec driver
  ALSA: hda/realtek: enable AW88399 on Lenovo Legion Pro

 drivers/acpi/scan.c                           |    1 +
 .../platform/x86/serial-multi-instantiate.c   |   10 +
 include/sound/aw88399.h                       |  621 ++++++++
 sound/hda/codecs/realtek/alc269.c             |   50 +
 sound/hda/codecs/side-codecs/Kconfig          |   18 +
 sound/hda/codecs/side-codecs/Makefile         |    4 +
 sound/hda/codecs/side-codecs/aw88399_hda.c    |  371 +++++
 sound/hda/codecs/side-codecs/aw88399_hda.h    |   36 +
 .../hda/codecs/side-codecs/aw88399_hda_i2c.c  |   54 +
 sound/soc/codecs/Kconfig                      |    5 +
 sound/soc/codecs/Makefile                     |    2 +
 sound/soc/codecs/aw88399-lib.c                | 1411 +++++++++++++++++
 sound/soc/codecs/aw88399.c                    | 1349 ----------------
 sound/soc/codecs/aw88399.h                    |  582 +------
 14 files changed, 2585 insertions(+), 1929 deletions(-)
 create mode 100644 include/sound/aw88399.h
 create mode 100644 sound/hda/codecs/side-codecs/aw88399_hda.c
 create mode 100644 sound/hda/codecs/side-codecs/aw88399_hda.h
 create mode 100644 sound/hda/codecs/side-codecs/aw88399_hda_i2c.c
 create mode 100644 sound/soc/codecs/aw88399-lib.c


base-commit: f9be704f58bde47c5ea841d5e4a6e9a7459c1578
-- 
2.55.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2026-07-22 13:34 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-17 13:25 [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion Marco Giunta
2026-07-17 13:25 ` [PATCH 1/8] ASoC: aw88399: extract shared device library Marco Giunta
2026-07-21 15:21   ` Ilpo Järvinen
2026-07-21 16:57     ` Mark Brown
2026-07-17 13:25 ` [PATCH 2/8] ASoC: aw88399: derive channel from I2C address on ACPI systems Marco Giunta
2026-07-17 13:25 ` [PATCH 3/8] ASoC: aw88399: add per-instance BSTS status bypass flag Marco Giunta
2026-07-17 13:25 ` [PATCH 4/8] ASoC: aw88399: add firmware reload flag for resume Marco Giunta
2026-07-17 13:25 ` [PATCH 5/8] ASoC: aw88399: add channel setter for HDA side codec Marco Giunta
2026-07-17 13:25 ` [PATCH 6/8] ACPI/platform: add AWDZ8399 to serial-multi-instantiate Marco Giunta
2026-07-21 12:13   ` Rafael J. Wysocki (Intel)
2026-07-21 15:22   ` Ilpo Järvinen
2026-07-17 13:25 ` [PATCH 7/8] ALSA: hda/scodec: add AW88399 HDA side codec driver Marco Giunta
2026-07-17 13:25 ` [PATCH 8/8] ALSA: hda/realtek: enable AW88399 on Lenovo Legion Pro Marco Giunta
2026-07-21 11:32 ` [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion Takashi Iwai
2026-07-21 18:19 ` (subset) " Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox