Re: [PATCH v11 07/15] platform/x86: lenovo-wmi-helpers: Move gamezone enums to wmi-helpers

["Derek J. Clark" <derekjohn.clark@gmail.com>]

On May 8, 2026 7:21:22 AM PDT, "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> wrote:
>On Thu, 7 May 2026, Derek J. Clark wrote:
>
>It seems there are a few nits still to address (they were too many so I'd 
>want to try to do inline editing).
>

No problem. I'll try to get v12 done today after you're done with the review.

>> In a later patch in the series the thermal mode enum will be accessed
>> across three separate drivers (wmi-capdata, wmi-gamezonem and wmi-other).
>> An additional patch in the series will also add a function protoype that
>
>prototype
>
>> needs to reference this enum in wmi-helpers.h. To avoid having all these
>> drivers begin to import each others headers, and to avoid declaring an
>> opaque enum to hande the second case, move the thermal mode enum to
>> helpers where it can be safely accessed by everything that needs it from
>> a single import.
>> 
>> While at it, since the gamezone_events_type enum is the only remaining
>> item in the header, move that as well and remove the gamezone header
>> entirely.
>> 
>> Fixes: 22024ac5366f ("platform/x86: Add Lenovo Gamezone WMI Driver")
>
>This change doesn't seem to exactly fix anything so it shouldn't have 
>Fixes tag.
>
>We want to only have Cc: stable in the prerequisites for some other fix 
>that comes after.
>
Makes sense. I wasn't sure, checkpatch flagged it as missing a fixes tag and I figured it was easier to drop than to have you try and find the original commit. I'll drop that for the formatting only patches. 

Thanks,
Derek

>My plan is to take patches 1-9 through fixes branch and then merge fixes 
>to for-next and take the rest through for-next.
>