From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: isdn@linux-pingi.de, davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH 6/6] mISDN: remove unused function
Date: Sat, 24 Sep 2016 10:42:14 +0200 [thread overview]
Message-ID: <6975809.FmUs8oxeay@wuerfel> (raw)
In-Reply-To: <1474694882-25427-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, September 24, 2016 1:28:02 PM CEST Baoyou Xie wrote:
> diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
> index f6ab6027..2519510 100644
> --- a/drivers/isdn/mISDN/layer2.c
> +++ b/drivers/isdn/mISDN/layer2.c
> @@ -459,15 +459,6 @@ IsDISC(u_char *data)
> return (data[0] & 0xef) == DISC;
> }
>
> -inline int
> -IsRR(u_char *data, struct layer2 *l2)
> -{
> - if (test_bit(FLG_MOD128, &l2->flag))
> - return data[0] == RR;
> - else
> - return (data[0] & 0xf) == 1;
> -}
> -
> static inline int
> IsSFrame(u_char *data, struct layer2 *l2)
> {
> --
>
This is not wrong, but it might be nicer to just
make this one as 'static inline' as well like the other
ones for consistency.
Note that static inline functions don't cause a warning
when they are unused.
Arnd
prev parent reply other threads:[~2016-10-04 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 5:28 [PATCH 6/6] mISDN: remove unused function Baoyou Xie
2016-09-24 8:42 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6975809.FmUs8oxeay@wuerfel \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox