* [PATCH 6/6] mISDN: remove unused function
@ 2016-09-24 5:28 Baoyou Xie
2016-09-24 8:42 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-24 5:28 UTC (permalink / raw)
To: isdn, davem; +Cc: netdev, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/isdn/mISDN/layer2.c:463:1: warning: no previous declaration for 'IsRR' [-Wmissing-declarations]
In fact, this function is called by no one and not exported,
so this patch removes it.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/isdn/mISDN/layer2.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
index f6ab6027..2519510 100644
--- a/drivers/isdn/mISDN/layer2.c
+++ b/drivers/isdn/mISDN/layer2.c
@@ -459,15 +459,6 @@ IsDISC(u_char *data)
return (data[0] & 0xef) == DISC;
}
-inline int
-IsRR(u_char *data, struct layer2 *l2)
-{
- if (test_bit(FLG_MOD128, &l2->flag))
- return data[0] == RR;
- else
- return (data[0] & 0xf) == 1;
-}
-
static inline int
IsSFrame(u_char *data, struct layer2 *l2)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 6/6] mISDN: remove unused function
2016-09-24 5:28 [PATCH 6/6] mISDN: remove unused function Baoyou Xie
@ 2016-09-24 8:42 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-09-24 8:42 UTC (permalink / raw)
To: Baoyou Xie; +Cc: isdn, davem, netdev, linux-kernel, xie.baoyou
On Saturday, September 24, 2016 1:28:02 PM CEST Baoyou Xie wrote:
> diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
> index f6ab6027..2519510 100644
> --- a/drivers/isdn/mISDN/layer2.c
> +++ b/drivers/isdn/mISDN/layer2.c
> @@ -459,15 +459,6 @@ IsDISC(u_char *data)
> return (data[0] & 0xef) == DISC;
> }
>
> -inline int
> -IsRR(u_char *data, struct layer2 *l2)
> -{
> - if (test_bit(FLG_MOD128, &l2->flag))
> - return data[0] == RR;
> - else
> - return (data[0] & 0xf) == 1;
> -}
> -
> static inline int
> IsSFrame(u_char *data, struct layer2 *l2)
> {
> --
>
This is not wrong, but it might be nicer to just
make this one as 'static inline' as well like the other
ones for consistency.
Note that static inline functions don't cause a warning
when they are unused.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-04 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-24 5:28 [PATCH 6/6] mISDN: remove unused function Baoyou Xie
2016-09-24 8:42 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox