[parent not found: <20260425144309.67569-1-kartikey406@gmail.com>]
[parent not found: <20260425125451.64534-1-kartikey406@gmail.com>]
[parent not found: <20260425093612.30657-1-souradiptodas6@gmail.com>]
* Re: [syzbot] [usb?] memory leak in hub_event (4)
[not found] <20260425093612.30657-1-souradiptodas6@gmail.com>
@ 2026-04-25 10:11 ` syzbot
0 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2026-04-25 10:11 UTC (permalink / raw)
To: linux-kernel, souradiptodas6, syzkaller-bugs
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in hub_event
BUG: memory leak
unreferenced object 0xffff88811451c000 (size 2048):
comm "kworker/0:2", pid 4940, jiffies 4294947134
hex dump (first 32 bytes):
ff ff ff ff 31 00 00 00 00 00 00 00 00 00 00 00 ....1...........
00 00 00 00 00 00 00 00 00 00 00 00 02 00 00 00 ................
backtrace (crc be863add):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__kmalloc_cache_noprof+0x371/0x480 mm/slub.c:5410
kmalloc_noprof include/linux/slab.h:950 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
usb_alloc_dev+0x36/0x4e0 drivers/usb/core/usb.c:651
hub_port_connect drivers/usb/core/hub.c:5471 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5711 [inline]
port_event drivers/usb/core/hub.c:5875 [inline]
hub_event+0x153d/0x2220 drivers/usb/core/hub.c:5957
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
BUG: memory leak
unreferenced object 0xffff888128ed5a80 (size 8):
comm "kworker/0:2", pid 4940, jiffies 4294947165
hex dump (first 8 bytes):
00 69 f1 28 81 88 ff ff .i.(....
backtrace (crc 35b42ed6):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__do_kmalloc_node mm/slub.c:5294 [inline]
__kmalloc_noprof+0x3b7/0x550 mm/slub.c:5307
kmalloc_noprof include/linux/slab.h:954 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
usb_get_configuration+0x11d/0x2110 drivers/usb/core/config.c:945
usb_enumerate_device drivers/usb/core/hub.c:2527 [inline]
usb_new_device+0x1b4/0x300 drivers/usb/core/hub.c:2665
hub_port_connect drivers/usb/core/hub.c:5568 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5711 [inline]
port_event drivers/usb/core/hub.c:5875 [inline]
hub_event+0x1790/0x2220 drivers/usb/core/hub.c:5957
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
BUG: memory leak
unreferenced object 0xffff88812a6de200 (size 256):
comm "kworker/0:2", pid 4940, jiffies 4294947170
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 08 e2 6d 2a 81 88 ff ff ..........m*....
08 e2 6d 2a 81 88 ff ff b0 7d 41 83 ff ff ff ff ..m*.....}A.....
backtrace (crc f539164e):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__kmalloc_cache_noprof+0x371/0x480 mm/slub.c:5410
kmalloc_noprof include/linux/slab.h:950 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
device_private_init drivers/base/core.c:3536 [inline]
device_add+0x73c/0xc70 drivers/base/core.c:3587
usb_new_device.cold+0x115/0x626 drivers/usb/core/hub.c:2695
hub_port_connect drivers/usb/core/hub.c:5568 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5711 [inline]
port_event drivers/usb/core/hub.c:5875 [inline]
hub_event+0x1790/0x2220 drivers/usb/core/hub.c:5957
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
connection error: failed to recv *flatrpc.ExecutorMessageRawT: EOF
Tested on:
commit: 27d128c1 Merge tag 'trace-ring-buffer-v7.1-3' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1762f1ba580000
kernel config: https://syzkaller.appspot.com/x/.config?x=9645c21cfd1d3e8f
dashboard link: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
compiler: gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
patch: https://syzkaller.appspot.com/x/patch.diff?x=159ef702580000
^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CAKVbAB1UYCWwpZvmV05TuA_NU16YY6fEr5t0HUjuixVq_f5b+w@mail.gmail.com>]
[parent not found: <20260425063629.59918-1-kartikey406@gmail.com>]
* Re: [syzbot] [usb?] memory leak in hub_event (4)
[not found] <20260425063629.59918-1-kartikey406@gmail.com>
@ 2026-04-25 7:13 ` syzbot
0 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2026-04-25 7:13 UTC (permalink / raw)
To: kartikey406, linux-kernel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in hub_event
BUG: memory leak
unreferenced object 0xffff8881149d6000 (size 2048):
comm "kworker/0:2", pid 807, jiffies 4294949998
hex dump (first 32 bytes):
ff ff ff ff 31 00 00 00 00 00 00 00 00 00 00 00 ....1...........
00 00 00 00 00 00 00 00 00 00 00 00 02 00 00 00 ................
backtrace (crc 6a8f68af):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__kmalloc_cache_noprof+0x371/0x480 mm/slub.c:5410
kmalloc_noprof include/linux/slab.h:950 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
usb_alloc_dev+0x36/0x4e0 drivers/usb/core/usb.c:651
hub_port_connect drivers/usb/core/hub.c:5471 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5708 [inline]
port_event drivers/usb/core/hub.c:5872 [inline]
hub_event+0x14d0/0x2180 drivers/usb/core/hub.c:5954
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
BUG: memory leak
unreferenced object 0xffff888129f4a800 (size 256):
comm "kworker/0:2", pid 807, jiffies 4294950032
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 08 a8 f4 29 81 88 ff ff ...........)....
08 a8 f4 29 81 88 ff ff b0 7d 41 83 ff ff ff ff ...).....}A.....
backtrace (crc c705f08):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__kmalloc_cache_noprof+0x371/0x480 mm/slub.c:5410
kmalloc_noprof include/linux/slab.h:950 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
device_private_init drivers/base/core.c:3536 [inline]
device_add+0x73c/0xc70 drivers/base/core.c:3587
usb_new_device.cold+0x115/0x633 drivers/usb/core/hub.c:2695
hub_port_connect drivers/usb/core/hub.c:5568 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5708 [inline]
port_event drivers/usb/core/hub.c:5872 [inline]
hub_event+0x1723/0x2180 drivers/usb/core/hub.c:5954
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
connection error: failed to recv *flatrpc.ExecutorMessageRawT: EOF
Tested on:
commit: 27d128c1 Merge tag 'trace-ring-buffer-v7.1-3' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17a91c36580000
kernel config: https://syzkaller.appspot.com/x/.config?x=9645c21cfd1d3e8f
dashboard link: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
compiler: gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
patch: https://syzkaller.appspot.com/x/patch.diff?x=1027e2ce580000
^ permalink raw reply [flat|nested] 10+ messages in thread
* [syzbot] [usb?] memory leak in hub_event (4)
@ 2026-04-25 2:12 syzbot
2026-04-27 11:40 ` Oliver Neukum
0 siblings, 1 reply; 10+ messages in thread
From: syzbot @ 2026-04-25 2:12 UTC (permalink / raw)
To: gregkh, linux-kernel, linux-usb, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: dd6c438c3e64 Merge tag 'vfs-7.1-rc1.fixes' of git://git.ke..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15cf7702580000
kernel config: https://syzkaller.appspot.com/x/.config?x=ac5083db84233db3
dashboard link: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
compiler: gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13cf7702580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17941c36580000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/dea6ab846ab3/disk-dd6c438c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/acebe380aa03/vmlinux-dd6c438c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/2cdbd012d0d3/bzImage-dd6c438c.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
BUG: memory leak
unreferenced object 0xffff8881277dc000 (size 2048):
comm "kworker/0:2", pid 1783, jiffies 4294946784
hex dump (first 32 bytes):
ff ff ff ff 31 00 00 00 00 00 00 00 00 00 00 00 ....1...........
00 00 00 00 00 00 00 00 00 00 00 00 02 00 00 00 ................
backtrace (crc 20105372):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__kmalloc_cache_noprof+0x371/0x480 mm/slub.c:5410
kmalloc_noprof include/linux/slab.h:950 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
usb_alloc_dev+0x36/0x4e0 drivers/usb/core/usb.c:651
hub_port_connect drivers/usb/core/hub.c:5470 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5707 [inline]
port_event drivers/usb/core/hub.c:5871 [inline]
hub_event+0x14d0/0x2180 drivers/usb/core/hub.c:5953
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
BUG: memory leak
unreferenced object 0xffff888128b06c00 (size 1024):
comm "kworker/0:2", pid 1783, jiffies 4294946815
hex dump (first 32 bytes):
09 02 49 00 02 01 00 10 40 00 00 00 00 00 00 00 ..I.....@.......
00 00 00 00 00 00 00 00 89 b8 69 09 81 88 ff ff ..........i.....
backtrace (crc b43c3ef8):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__do_kmalloc_node mm/slub.c:5294 [inline]
__kmalloc_noprof+0x3b7/0x550 mm/slub.c:5307
kmalloc_noprof include/linux/slab.h:954 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
usb_get_configuration+0xeb/0x2110 drivers/usb/core/config.c:940
usb_enumerate_device drivers/usb/core/hub.c:2527 [inline]
usb_new_device+0x1b4/0x300 drivers/usb/core/hub.c:2665
hub_port_connect drivers/usb/core/hub.c:5567 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5707 [inline]
port_event drivers/usb/core/hub.c:5871 [inline]
hub_event+0x1723/0x2180 drivers/usb/core/hub.c:5953
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
BUG: memory leak
unreferenced object 0xffff88810c3d5a50 (size 8):
comm "kworker/0:2", pid 1783, jiffies 4294946815
hex dump (first 8 bytes):
80 b8 69 09 81 88 ff ff ..i.....
backtrace (crc 66af3167):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__do_kmalloc_node mm/slub.c:5294 [inline]
__kmalloc_noprof+0x3b7/0x550 mm/slub.c:5307
kmalloc_noprof include/linux/slab.h:954 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
usb_get_configuration+0x11d/0x2110 drivers/usb/core/config.c:945
usb_enumerate_device drivers/usb/core/hub.c:2527 [inline]
usb_new_device+0x1b4/0x300 drivers/usb/core/hub.c:2665
hub_port_connect drivers/usb/core/hub.c:5567 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5707 [inline]
port_event drivers/usb/core/hub.c:5871 [inline]
hub_event+0x1723/0x2180 drivers/usb/core/hub.c:5953
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
BUG: memory leak
unreferenced object 0xffff888113c25840 (size 64):
comm "kworker/0:2", pid 1783, jiffies 4294946817
hex dump (first 32 bytes):
01 00 00 00 01 00 00 00 09 04 00 00 00 01 01 30 ...............0
00 00 00 00 0a 00 00 00 9a b8 69 09 81 88 ff ff ..........i.....
backtrace (crc a90fa323):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__do_kmalloc_node mm/slub.c:5294 [inline]
__kmalloc_noprof+0x3b7/0x550 mm/slub.c:5307
kmalloc_noprof include/linux/slab.h:954 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
usb_parse_configuration drivers/usb/core/config.c:826 [inline]
usb_get_configuration+0x88f/0x2110 drivers/usb/core/config.c:1002
usb_enumerate_device drivers/usb/core/hub.c:2527 [inline]
usb_new_device+0x1b4/0x300 drivers/usb/core/hub.c:2665
hub_port_connect drivers/usb/core/hub.c:5567 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5707 [inline]
port_event drivers/usb/core/hub.c:5871 [inline]
hub_event+0x1723/0x2180 drivers/usb/core/hub.c:5953
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
BUG: memory leak
unreferenced object 0xffff88811d54a500 (size 256):
comm "kworker/0:2", pid 1783, jiffies 4294946821
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 08 a5 54 1d 81 88 ff ff ..........T.....
08 a5 54 1d 81 88 ff ff 20 e7 41 83 ff ff ff ff ..T..... .A.....
backtrace (crc 85d09f91):
kmemleak_alloc_recursive include/linux/kmemleak.h:44 [inline]
slab_post_alloc_hook mm/slub.c:4574 [inline]
slab_alloc_node mm/slub.c:4898 [inline]
__kmalloc_cache_noprof+0x371/0x480 mm/slub.c:5410
kmalloc_noprof include/linux/slab.h:950 [inline]
kzalloc_noprof include/linux/slab.h:1188 [inline]
device_private_init drivers/base/core.c:3536 [inline]
device_add+0x73c/0xc70 drivers/base/core.c:3587
usb_new_device.cold+0x115/0x626 drivers/usb/core/hub.c:2695
hub_port_connect drivers/usb/core/hub.c:5567 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5707 [inline]
port_event drivers/usb/core/hub.c:5871 [inline]
hub_event+0x1723/0x2180 drivers/usb/core/hub.c:5953
process_one_work+0x277/0x5b0 kernel/workqueue.c:3302
process_scheduled_works kernel/workqueue.c:3385 [inline]
worker_thread+0x255/0x4a0 kernel/workqueue.c:3466
kthread+0x14e/0x1a0 kernel/kthread.c:436
ret_from_fork+0x219/0x490 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
connection error: failed to recv *flatrpc.ExecutorMessageRawT: EOF
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-25 2:12 syzbot
@ 2026-04-27 11:40 ` Oliver Neukum
2026-04-27 12:37 ` syzbot
2026-04-27 14:19 ` Alan Stern
0 siblings, 2 replies; 10+ messages in thread
From: Oliver Neukum @ 2026-04-27 11:40 UTC (permalink / raw)
To: syzbot, gregkh, linux-kernel, linux-usb, syzkaller-bugs
[-- Attachment #1: Type: text/plain, Size: 81 bytes --]
On 25.04.26 04:12, syzbot wrote:
#syz test: git://repo/address.git dd6c438c3e64
[-- Attachment #2: 0001-usb-core-fix-memory-of-error-case-in-usb_get_configu.patch --]
[-- Type: text/x-patch, Size: 1527 bytes --]
From 001175f4d2e1c2ceac98b4af2521fc4d0253d0c8 Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Mon, 27 Apr 2026 13:35:38 +0200
Subject: [PATCH] usb: core: fix memory of error case in usb_get_configuration
Prior allocations need to be reversed if subsequent
allocations fail.
Fixes: dd2057e544dc9 ("USB: core: drop OOM message")
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
---
drivers/usb/core/config.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 417140b012bb..67475ff81641 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -944,11 +944,11 @@ int usb_get_configuration(struct usb_device *dev)
length = ncfg * sizeof(char *);
dev->rawdescriptors = kzalloc(length, GFP_KERNEL);
if (!dev->rawdescriptors)
- return -ENOMEM;
+ goto bailout2;
desc = kmalloc(USB_DT_CONFIG_SIZE, GFP_KERNEL);
if (!desc)
- return -ENOMEM;
+ goto bailout;
for (cfgno = 0; cfgno < ncfg; cfgno++) {
/* We grab just the first descriptor so we know how long
@@ -1012,6 +1012,15 @@ int usb_get_configuration(struct usb_device *dev)
dev->descriptor.bNumConfigurations = cfgno;
return result;
+
+bailout:
+ kfree(dev->rawdescriptors);
+ dev->rawdescriptors = NULL;
+bailout2:
+ kfree(dev->config);
+ dev->config = NULL;
+
+ return -ENOMEM;
}
void usb_release_bos_descriptor(struct usb_device *dev)
--
2.54.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-27 11:40 ` Oliver Neukum
@ 2026-04-27 12:37 ` syzbot
2026-04-27 14:19 ` Alan Stern
1 sibling, 0 replies; 10+ messages in thread
From: syzbot @ 2026-04-27 12:37 UTC (permalink / raw)
To: gregkh, linux-kernel, linux-usb, oneukum, syzkaller-bugs
Hello,
syzbot tried to test the proposed patch but the build/boot failed:
failed to checkout kernel repo git://repo/address.git on commit dd6c438c3e64: failed to run ["git" "fetch" "--force" "--tags" "b7cf8f2fbfc36c709a08e0b9c77990e491473738"]: exit status 128
Tested on:
commit: [unknown
git tree: git://repo/address.git dd6c438c3e64
kernel config: https://syzkaller.appspot.com/x/.config?x=ac5083db84233db3
dashboard link: https://syzkaller.appspot.com/bug?extid=2afd7e71155c7e241560
compiler:
patch: https://syzkaller.appspot.com/x/patch.diff?x=1575b236580000
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [syzbot] [usb?] memory leak in hub_event (4)
2026-04-27 11:40 ` Oliver Neukum
2026-04-27 12:37 ` syzbot
@ 2026-04-27 14:19 ` Alan Stern
1 sibling, 0 replies; 10+ messages in thread
From: Alan Stern @ 2026-04-27 14:19 UTC (permalink / raw)
To: Oliver Neukum; +Cc: syzbot, gregkh, linux-kernel, linux-usb, syzkaller-bugs
On Mon, Apr 27, 2026 at 01:40:02PM +0200, Oliver Neukum wrote:
> On 25.04.26 04:12, syzbot wrote:
>
> #syz test: git://repo/address.git dd6c438c3e64
> From 001175f4d2e1c2ceac98b4af2521fc4d0253d0c8 Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oneukum@suse.com>
> Date: Mon, 27 Apr 2026 13:35:38 +0200
> Subject: [PATCH] usb: core: fix memory of error case in usb_get_configuration
>
> Prior allocations need to be reversed if subsequent
> allocations fail.
>
> Fixes: dd2057e544dc9 ("USB: core: drop OOM message")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Reported-by: syzbot+2afd7e71155c7e241560@syzkaller.appspotmail.com
> ---
> drivers/usb/core/config.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index 417140b012bb..67475ff81641 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -944,11 +944,11 @@ int usb_get_configuration(struct usb_device *dev)
> length = ncfg * sizeof(char *);
> dev->rawdescriptors = kzalloc(length, GFP_KERNEL);
> if (!dev->rawdescriptors)
> - return -ENOMEM;
> + goto bailout2;
>
> desc = kmalloc(USB_DT_CONFIG_SIZE, GFP_KERNEL);
> if (!desc)
> - return -ENOMEM;
> + goto bailout;
>
> for (cfgno = 0; cfgno < ncfg; cfgno++) {
> /* We grab just the first descriptor so we know how long
> @@ -1012,6 +1012,15 @@ int usb_get_configuration(struct usb_device *dev)
> dev->descriptor.bNumConfigurations = cfgno;
>
> return result;
> +
> +bailout:
> + kfree(dev->rawdescriptors);
> + dev->rawdescriptors = NULL;
> +bailout2:
> + kfree(dev->config);
> + dev->config = NULL;
> +
> + return -ENOMEM;
> }
This is not needed. dev->rawdescriptors and dev->config are deallocated
in usb_destroy_configuration(), which gets called when the usb_device
structure is released.
The memory leak must have a different cause.
Alan Stern
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-04-27 14:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260425075154.61497-1-kartikey406@gmail.com>
2026-04-25 8:41 ` [syzbot] [usb?] memory leak in hub_event (4) syzbot
[not found] <20260425144309.67569-1-kartikey406@gmail.com>
2026-04-25 15:23 ` syzbot
[not found] <20260425125451.64534-1-kartikey406@gmail.com>
2026-04-25 14:09 ` syzbot
[not found] <20260425093612.30657-1-souradiptodas6@gmail.com>
2026-04-25 10:11 ` syzbot
[not found] <CAKVbAB1UYCWwpZvmV05TuA_NU16YY6fEr5t0HUjuixVq_f5b+w@mail.gmail.com>
2026-04-25 9:51 ` syzbot
[not found] <20260425063629.59918-1-kartikey406@gmail.com>
2026-04-25 7:13 ` syzbot
2026-04-25 2:12 syzbot
2026-04-27 11:40 ` Oliver Neukum
2026-04-27 12:37 ` syzbot
2026-04-27 14:19 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox