[PATCH] rust: block: fix comment referring to states by wrong labels

[PATCH] rust: block: fix comment referring to states by wrong labels

[Hsiu Che Yu]

The comment in `Request` describing the four ownership states referred
to states 2 and 3 as "B" and "C", which are inconsistent with the
numbering scheme used throughout the same comment block.

Update the labels to use "2" and "3" to match the existing numbered list.

Fixes: a307bf1db5448 ("rust: block: convert `block::mq` to use `Refcount`")
Signed-off-by: Hsiu Che Yu <yu.whisper.personal@gmail.com>
---
 rust/kernel/block/mq/request.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs
index ce3e30c81cb5..75d3fdf896e0 100644
--- a/rust/kernel/block/mq/request.rs
+++ b/rust/kernel/block/mq/request.rs
@@ -39,7 +39,7 @@
 /// back ownership to the block layer.
 ///
 /// Note that the driver can still obtain new `ARef` even if there is no `ARef`s in existence by
-/// using `tag_to_rq`, hence the need to distinguish B and C.
+/// using `tag_to_rq`, hence the need to distinguish 2 and 3.
 ///
 /// The states are tracked through the private `refcount` field of
 /// `RequestDataWrapper`. This structure lives in the private data area of the C

---
base-commit: b4e07588e743c989499ca24d49e752c074924a9a
change-id: 20260428-fix-docs-mq-req-d2a0fe1b6471

Best regards,
--  
Hsiu Che Yu <yu.whisper.personal@gmail.com>

Re: [PATCH] rust: block: fix comment referring to states by wrong labels

[Miguel Ojeda]

On Tue, Apr 28, 2026 at 9:25 AM Hsiu Che Yu
<yu.whisper.personal@gmail.com> wrote:
>
> Fixes: a307bf1db5448 ("rust: block: convert `block::mq` to use `Refcount`")

Since this commit exists in stable kernels, and this is visible in
generated docs, we generally tag them for backport, so I am doing so
here:

Cc: stable@vger.kernel.org

Thanks!

Cheers,
Miguel

Re: [PATCH] rust: block: fix comment referring to states by wrong labels

[Hsiu Che Yu]

On Tue, Apr 28, 2026 at 01:42:31PM +0200, Miguel Ojeda wrote:
>Since this commit exists in stable kernels, and this is visible in
>generated docs, we generally tag them for backport, so I am doing so
>here:
>
>Cc: stable@vger.kernel.org

Thanks!

Re: [PATCH] rust: block: fix comment referring to states by wrong labels

[Andreas Hindborg]

Hi,

"Hsiu Che Yu" <yu.whisper.personal@gmail.com> writes:

> The comment in `Request` describing the four ownership states referred
> to states 2 and 3 as "B" and "C", which are inconsistent with the
> numbering scheme used throughout the same comment block.
>
> Update the labels to use "2" and "3" to match the existing numbered list.
>
> Fixes: a307bf1db5448 ("rust: block: convert `block::mq` to use `Refcount`")
> Signed-off-by: Hsiu Che Yu <yu.whisper.personal@gmail.com>
> ---
>  rust/kernel/block/mq/request.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/block/mq/request.rs b/rust/kernel/block/mq/request.rs
> index ce3e30c81cb5..75d3fdf896e0 100644
> --- a/rust/kernel/block/mq/request.rs
> +++ b/rust/kernel/block/mq/request.rs
> @@ -39,7 +39,7 @@
>  /// back ownership to the block layer.
>  ///
>  /// Note that the driver can still obtain new `ARef` even if there is no `ARef`s in existence by
> -/// using `tag_to_rq`, hence the need to distinguish B and C.
> +/// using `tag_to_rq`, hence the need to distinguish 2 and 3.
>  ///
>  /// The states are tracked through the private `refcount` field of
>  /// `RequestDataWrapper`. This structure lives in the private data area of the C
>
> ---
> base-commit: b4e07588e743c989499ca24d49e752c074924a9a
> change-id: 20260428-fix-docs-mq-req-d2a0fe1b6471
>
> Best regards,
> --
> Hsiu Che Yu <yu.whisper.personal@gmail.com>

Thanks for the patch. Please be aware that this mistake is fixed in the
latest rust null block series [1]. Please take a look at that series if
you have more patches for the rust block subsystem queued.

Best regards,
Andreas Hindborg


[1] https://lore.kernel.org/rust-for-linux/20260216-rnull-v6-19-rc5-send-v1-0-de9a7af4b469@kernel.org/

Re: [PATCH] rust: block: fix comment referring to states by wrong labels

[Hsiu Che Yu]

On Wed, Apr 29, 2026 at 12:17:43PM +0200, Andreas Hindborg wrote:
>Thanks for the patch. Please be aware that this mistake is fixed in the
>latest rust null block series [1]. Please take a look at that series if
>you have more patches for the rust block subsystem queued.

Thank you for letting me know. I'll take a look at the series.

Best regards,
Hsiu