From: Luka Gejak <luka.gejak@linux.dev>
To: osdevhari@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, luka.gejak@linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove trailing whitespace in rtw_xmit.c
Date: Sat, 18 Apr 2026 09:10:47 +0200 [thread overview]
Message-ID: <6C4D65F4-8955-4B96-87A3-3FB25F5743EE@linux.dev> (raw)
In-Reply-To: <CA+TGEkHXoCfY0RhmKFnfLrnPO+dKwKXAnGu84RNsNcE0=MaGAQ@mail.gmail.com>
Hi Osdevhari,
Let's start from the top of the email. Firstly attachments are not
allowed, only plaintext. Secondly Signed-off-by tag must use your real
name(Firstname Lastname <email>. Thirdly, you should setup git
send-email and use it to send patches. Now let's take a look at actual
code:
>ret = xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe);
>- if (true == ret) {
>+ if (ret) {
Here you did completely unrelated change to what your commit says.
> ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8
>*)(&ac_index));
Also why break this line.
>
> ptxservq->qcnt--;
> phwxmits[ac_index].accnt--;
>- } else {
>- }
>+ }
> }
Here you removed an else without readding it
> }
You didn't even do anything related to trailing whitespace, they
weren't even there. Also please don't do unrelated changes and stick
to atomic patch rule. Check Documentation/process for more
information on how to create and send patches.
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-04-18 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 3:36 [PATCH] staging: rtl8723bs: remove trailing whitespace in rtw_xmit.c Hari Haran
2026-04-18 7:10 ` Luka Gejak [this message]
2026-04-18 7:22 ` Luka Gejak
2026-04-18 7:24 ` Greg KH
2026-04-18 7:37 ` Luka Gejak
2026-04-18 8:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6C4D65F4-8955-4B96-87A3-3FB25F5743EE@linux.dev \
--to=luka.gejak@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=osdevhari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox