From: Greg KH <gregkh@linuxfoundation.org>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: osdevhari@gmail.com, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: remove trailing whitespace in rtw_xmit.c
Date: Sat, 18 Apr 2026 09:24:01 +0200 [thread overview]
Message-ID: <2026041841-prowling-reflex-a7b5@gregkh> (raw)
In-Reply-To: <6C4D65F4-8955-4B96-87A3-3FB25F5743EE@linux.dev>
On Sat, Apr 18, 2026 at 09:10:47AM +0200, Luka Gejak wrote:
> Hi Osdevhari,
> Let's start from the top of the email. Firstly attachments are not
> allowed, only plaintext. Secondly Signed-off-by tag must use your real
> name(Firstname Lastname <email>. Thirdly, you should setup git
> send-email and use it to send patches. Now let's take a look at actual
> code:
Again, Luka, please take a break from reviews. I would recommend
getting some more experience in the developer workflow before doing
this, as it can be a bit confusing for new developers coming in to see
stuff like this.
And again, please do not use AI for reviews, we have that already, and
there is a big reason I do not let it loose on the staging list because
it is not yet ready for it.
thanks,
greg k-h
next prev parent reply other threads:[~2026-04-18 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 3:36 [PATCH] staging: rtl8723bs: remove trailing whitespace in rtw_xmit.c Hari Haran
2026-04-18 7:10 ` Luka Gejak
2026-04-18 7:22 ` Luka Gejak
2026-04-18 7:24 ` Greg KH [this message]
2026-04-18 7:37 ` Luka Gejak
2026-04-18 8:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026041841-prowling-reflex-a7b5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=luka.gejak@linux.dev \
--cc=osdevhari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox