The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Aubrey Li <aubrey.li@intel.com>,
	tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
	hpa@zytor.com
Cc: ak@linux.intel.com, tim.c.chen@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] x86/fpu: track AVX-512 usage of tasks
Date: Tue, 11 Dec 2018 16:14:19 -0800	[thread overview]
Message-ID: <6a549986-f01a-a3c6-10c8-c116667bf7e4@linux.intel.com> (raw)
In-Reply-To: <143a5451-c7cf-16a5-a7ef-8c4b0633b689@linux.intel.com>

On 12/11/2018 3:46 PM, Li, Aubrey wrote:
> On 2018/12/12 1:18, Dave Hansen wrote:
>> On 12/10/18 4:24 PM, Aubrey Li wrote:
>>> The tracking turns on the usage flag at the next context switch of
>>> the task, but requires 3 consecutive context switches with no usage
>>> to clear it. This decay is required because well-written AVX-512
>>> applications are expected to clear this state when not actively using
>>> AVX-512 registers.
>>
>> One concern about this:  Given a HZ=1000 system, this means that the
>> flag needs to get scanned every ~3ms.  That's a pretty good amount of
>> scanning on a system with hundreds or thousands of tasks running around.
>>
>> How many tasks does this scale to until you're eating up an entire CPU
>> or two just scanning /proc?
>>
> 
> Do we have a real requirement to do this in practical environment?
> AFAIK, 1s or even 5s is good enough in some customers environment.

maybe instead of a 1/0 bit, it's useful to store the timestamp of the last
time we found the task to use avx? (need to find a good time unit)


  reply	other threads:[~2018-12-12  0:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  0:24 [PATCH v4 1/2] x86/fpu: track AVX-512 usage of tasks Aubrey Li
2018-12-11  0:24 ` [PATCH v4 2/2] proc: add AVX-512 usage to /proc/pid/status Aubrey Li
2018-12-11 17:57   ` Tim Chen
2018-12-11 17:18 ` [PATCH v4 1/2] x86/fpu: track AVX-512 usage of tasks Dave Hansen
2018-12-11 17:52   ` Tim Chen
2018-12-11 17:53   ` Andi Kleen
2018-12-11 23:46   ` Li, Aubrey
2018-12-12  0:14     ` Arjan van de Ven [this message]
2018-12-12  0:59       ` Li, Aubrey
2018-12-12  1:06         ` Dave Hansen
2018-12-11 17:20 ` Dave Hansen
2018-12-12  0:34   ` Li, Aubrey
2018-12-12  0:39     ` Dave Hansen
2018-12-12 16:55 ` David Laight
2018-12-12 18:00   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a549986-f01a-a3c6-10c8-c116667bf7e4@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=ak@linux.intel.com \
    --cc=aubrey.li@intel.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox