Re: [PATCH] clk: davinci: add Kconfig symbol

[David Lechner <david@lechnology.com>]

On 4/27/26 12:23 AM, Rosen Penev wrote:
> Add COMPILE_TEST support as a result so that the buildbots can run
> through this driver. There's nothing architecture specific about it.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/clk/Kconfig          | 7 +++++++
>  drivers/clk/Makefile         | 2 +-
>  drivers/clk/davinci/Makefile | 6 +++---
>  3 files changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 06a7ac971edf..42d84c0ed5fc 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -317,6 +317,13 @@ config COMMON_CLK_AXI_CLKGEN
>  	  Support for the Analog Devices axi-clkgen pcore clock generator for Xilinx
>  	  FPGAs. It is commonly used in Analog Devices' reference designs.
>  
> +config CLK_DA850
> +	bool "DaVinci DA850 CLK support"

Should this be `default y` so that it gets enabled? Or have
config ARCH_DAVINCI_DA850 select CLK_DA850?

Otherwise, we would need to modify the defconfigs as well to
enable it.

> +	depends on ARCH_DAVINCI_DA850 || COMPILE_TEST

We should also make this `depend on COMMON_CLK`. (see related comment
below.)

> +	help
> +	  This adds the clock driver support for DaVinci DA850 platform
> +	  using common clock framework.
> +
>  config CLK_QORIQ
>  	bool "Clock driver for Freescale QorIQ platforms"
>  	depends on OF
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index 0fc8f20b0fb1..6e13c001a544 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -118,7 +118,7 @@ obj-$(CONFIG_ARCH_ARTPEC)		+= axis/
>  obj-$(CONFIG_ARC_PLAT_AXS10X)		+= axs10x/
>  obj-y					+= bcm/
>  obj-$(CONFIG_ARCH_BERLIN)		+= berlin/
> -obj-$(CONFIG_ARCH_DAVINCI)		+= davinci/
> +obj-$(CONFIG_CLK_DAVINCI)		+= davinci/

Did you mean CONFIG_CLK_DA850? I don't think CONFIG_CLK_DAVINCI exists.

>  obj-$(CONFIG_COMMON_CLK_ESWIN)		+= eswin/
>  obj-$(CONFIG_ARCH_HISI)			+= hisilicon/
>  obj-y					+= imgtec/
> diff --git a/drivers/clk/davinci/Makefile b/drivers/clk/davinci/Makefile
> index f9d5c9a392e4..5ff30ceb2092 100644
> --- a/drivers/clk/davinci/Makefile
> +++ b/drivers/clk/davinci/Makefile
> @@ -1,11 +1,11 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
>  ifeq ($(CONFIG_COMMON_CLK), y)

Then we can drop this if statement.

> -obj-$(CONFIG_ARCH_DAVINCI_DA8XX)	+= da8xx-cfgchip.o
> +obj-$(CONFIG_CLK_DA850)		+= da8xx-cfgchip.o
>  
>  obj-y += pll.o

Since there is only one platform left supported, it would probably
make more sense to make everything (including pll.o and psc.o)
`obj-$(CONFIG_CLK_DA850)` or perhaps even better, make everything
(including da8xx-cfgchip.o, pll-da850.o and psc-da850.o) `obj-y`
since the containing directory already has the conditional (and
include a comment to this effect).

> -obj-$(CONFIG_ARCH_DAVINCI_DA850)	+= pll-da850.o
> +obj-$(CONFIG_CLK_DA850)		+= pll-da850.o
>  
>  obj-y += psc.o
> -obj-$(CONFIG_ARCH_DAVINCI_DA850)	+= psc-da850.o
> +obj-$(CONFIG_CLK_DA850)		+= psc-da850.o
>  endif