The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] hwmon: (yogafan) fix non-kernel-doc comment
@ 2026-08-21 11:57 hanzhijian
  2026-08-21 14:04 ` hanzhijian
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: hanzhijian @ 2026-08-21 11:57 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel, hanzhijian

The file description comment starts with "/**" which is reserved for
kernel-doc comments, triggering a kernel-doc checker warning.  Change
it to a plain "/*" comment since it does not document any function or
struct.

Signed-off-by: hanzhijian <hanzhijian1991@gmail.com>
---
 drivers/hwmon/yogafan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c
index 48fa5148d..278cb089b 100644
--- a/drivers/hwmon/yogafan.c
+++ b/drivers/hwmon/yogafan.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  * yoga_fan.c - Lenovo Yoga/Legion Fan Hardware Monitoring Driver
  *
  * Provides fan speed monitoring for Lenovo Yoga, Legion, and IdeaPad
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] hwmon: (yogafan) fix non-kernel-doc comment
  2026-08-21 11:57 [PATCH] hwmon: (yogafan) fix non-kernel-doc comment hanzhijian
@ 2026-08-21 14:04 ` hanzhijian
  2026-08-21 14:24 ` Guenter Roeck
  2026-08-23  1:38 ` [PATCH v2] " hanzhijian
  2 siblings, 0 replies; 6+ messages in thread
From: hanzhijian @ 2026-08-21 14:04 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel

Please drop this patch as well.  It is a trivial cleanup that only
silences the kernel-doc checker and does not fix a real problem.

hanzhijian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] hwmon: (yogafan) fix non-kernel-doc comment
  2026-08-21 11:57 [PATCH] hwmon: (yogafan) fix non-kernel-doc comment hanzhijian
  2026-08-21 14:04 ` hanzhijian
@ 2026-08-21 14:24 ` Guenter Roeck
  2026-08-23  1:38 ` [PATCH v2] " hanzhijian
  2 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2026-08-21 14:24 UTC (permalink / raw)
  To: hanzhijian; +Cc: linux-hwmon, linux-kernel

On Fri, Aug 21, 2026 at 07:57:20PM +0800, hanzhijian wrote:
> The file description comment starts with "/**" which is reserved for
> kernel-doc comments, triggering a kernel-doc checker warning.  Change
> it to a plain "/*" comment since it does not document any function or
> struct.
> 
> Signed-off-by: hanzhijian <hanzhijian1991@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/yogafan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c
> index 48fa5148d..278cb089b 100644
> --- a/drivers/hwmon/yogafan.c
> +++ b/drivers/hwmon/yogafan.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
>   * yoga_fan.c - Lenovo Yoga/Legion Fan Hardware Monitoring Driver
>   *
>   * Provides fan speed monitoring for Lenovo Yoga, Legion, and IdeaPad

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] hwmon: (yogafan) fix non-kernel-doc comment
  2026-08-21 11:57 [PATCH] hwmon: (yogafan) fix non-kernel-doc comment hanzhijian
  2026-08-21 14:04 ` hanzhijian
  2026-08-21 14:24 ` Guenter Roeck
@ 2026-08-23  1:38 ` hanzhijian
  2026-08-23  4:26   ` Guenter Roeck
  2 siblings, 1 reply; 6+ messages in thread
From: hanzhijian @ 2026-08-23  1:38 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel, hanzhijian

The file description comment starts with "/**", which is reserved for
kernel-doc comments.  scripts/kernel-doc then warns when building the
documentation:

  Warning: drivers/hwmon/yogafan.c:2 This comment starts with '/**',
  but isn't a kernel-doc comment. Refer to
  Documentation/doc-guide/kernel-doc.rst

Change it to a plain "/*" comment since it does not document any
function or struct.

Signed-off-by: hanzhijian <hanzhijian1991@gmail.com>
---
 drivers/hwmon/yogafan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c
index 48fa5148d..278cb089b 100644
--- a/drivers/hwmon/yogafan.c
+++ b/drivers/hwmon/yogafan.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  * yoga_fan.c - Lenovo Yoga/Legion Fan Hardware Monitoring Driver
  *
  * Provides fan speed monitoring for Lenovo Yoga, Legion, and IdeaPad
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] hwmon: (yogafan) fix non-kernel-doc comment
  2026-08-23  1:38 ` [PATCH v2] " hanzhijian
@ 2026-08-23  4:26   ` Guenter Roeck
  2026-08-24 12:55     ` hanzhijian
  0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2026-08-23  4:26 UTC (permalink / raw)
  To: hanzhijian; +Cc: linux-hwmon, linux-kernel

On 8/22/26 18:38, hanzhijian wrote:
> The file description comment starts with "/**", which is reserved for
> kernel-doc comments.  scripts/kernel-doc then warns when building the
> documentation:
> 
>    Warning: drivers/hwmon/yogafan.c:2 This comment starts with '/**',
>    but isn't a kernel-doc comment. Refer to
>    Documentation/doc-guide/kernel-doc.rst
> 
> Change it to a plain "/*" comment since it does not document any
> function or struct.
> 
> Signed-off-by: hanzhijian <hanzhijian1991@gmail.com>

No change log, no change other than the commit message, that change
does not add any value, and I already applied this patch and sent
out a note that I did.

Are you playing with me ? I am inclined to drop this patch.

Guenter

> ---
>   drivers/hwmon/yogafan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c
> index 48fa5148d..278cb089b 100644
> --- a/drivers/hwmon/yogafan.c
> +++ b/drivers/hwmon/yogafan.c
> @@ -1,5 +1,5 @@
>   // SPDX-License-Identifier: GPL-2.0-only
> -/**
> +/*
>    * yoga_fan.c - Lenovo Yoga/Legion Fan Hardware Monitoring Driver
>    *
>    * Provides fan speed monitoring for Lenovo Yoga, Legion, and IdeaPad


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] hwmon: (yogafan) fix non-kernel-doc comment
  2026-08-23  4:26   ` Guenter Roeck
@ 2026-08-24 12:55     ` hanzhijian
  0 siblings, 0 replies; 6+ messages in thread
From: hanzhijian @ 2026-08-24 12:55 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel

My apologies, Guenter.  You are right, and I'm sorry for the noise.

I sent the "please drop" note by mistake, then over-corrected by
resending it as v2 with no code change.  That was the wrong way to
handle it.

Please drop the patch entirely.  Sorry for wasting your time.

hanzhijian

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-08-24 12:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 11:57 [PATCH] hwmon: (yogafan) fix non-kernel-doc comment hanzhijian
2026-08-21 14:04 ` hanzhijian
2026-08-21 14:24 ` Guenter Roeck
2026-08-23  1:38 ` [PATCH v2] " hanzhijian
2026-08-23  4:26   ` Guenter Roeck
2026-08-24 12:55     ` hanzhijian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox