From: Paul Walmsley <pjw@kernel.org>
To: Zishun Yi <vulab@iscas.ac.cn>
Cc: Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Kees Cook <kees@kernel.org>,
Will Pierce <wgpierce17@gmail.com>,
Maxim Kochetkov <fido_max@inbox.ru>,
Samuel Holland <samuel.holland@sifive.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Markus.Elfring@web.de, patchwork@lists.ozlabs.org
Subject: Re: [PATCH] riscv: Check the return value of reloc handlers
Date: Thu, 30 Apr 2026 14:04:20 -0600 (MDT) [thread overview]
Message-ID: <6c1715e6-2bb9-40fd-dfb2-791468522614@kernel.org> (raw)
In-Reply-To: <20260321113419.34437-1-vulab@iscas.ac.cn>
Hello Zishun Yi (and, apparently, Wentao Liang),
On Sat, 21 Mar 2026, Zishun Yi wrote:
> Currently, process_accumulated_relocations() ignores the return values
> from both reloc_handler() and accumulate_handler().
>
> As a result, the kernel will proceed to load the module with corrupted
> or incomplete sections, which can lead to unpredictable behavior or
> kernel panics.
>
> So we need to check the return values of the handlers to propagate the
> error, and fall back to the cleanup mode.
>
> Fixes: 8fd6c5142395 ("riscv: Add remaining module relocations")
> Signed-off-by: Zishun Yi <vulab@iscas.ac.cn>
Thank you for sending this and several other fixes. I would like to
accept the RISC-V-oriented fixes, but have a few questions first --
similar to the ones that Markus already asked you several weeks ago.
First: were these fixes found and/or generated by LLM tools? They appear
to be. If so, please add an Assisted-by: tag, according to the directions
documented here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n637
and here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-assistants.rst
Second: is it possible for you both to get your own unique E-mail
accounts? Many kernel developers and tools assume that a specific E-mail
address will be used by only one person. For example, Patchwork is now
incorrectly attributing patches originally sent by Zishun Yi to Wentao
Liang, under the not-unreasonable assumption that each developer will have
their own E-mail address.
- Paul
prev parent reply other threads:[~2026-04-30 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 11:34 [PATCH] riscv: Check the return value of reloc handlers Zishun Yi
2026-03-22 7:26 ` Markus Elfring
2026-04-30 20:04 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c1715e6-2bb9-40fd-dfb2-791468522614@kernel.org \
--to=pjw@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=fido_max@inbox.ru \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=patchwork@lists.ozlabs.org \
--cc=samuel.holland@sifive.com \
--cc=vulab@iscas.ac.cn \
--cc=wgpierce17@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox