From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Zhang Rui <rui.zhang@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v2] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()
Date: Mon, 20 May 2024 12:38:55 +0300 (EEST) [thread overview]
Message-ID: <6d1bf351-77cc-7fe9-2d62-8bd99789e4f1@linux.intel.com> (raw)
In-Reply-To: <d5203ff5-8ed4-48ea-8e58-a2e6680b0542@web.de>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
On Sat, 18 May 2024, Markus Elfring wrote:
> …
> > Fix this by reordering the kfree() post the dereference.
>
> Would a wording approach (like the following) be a bit nicer?
>
> Move a kfree() call behind an assignment statement in the affected if branch.
No, the suggested wording would make it less precise ("post the
dereference" -> "behind an assignment") and also tries to tell pointless
things about the location in the codei that is visible in the patch itself.
--
i.
> > v1->v2: Add R.B from Hans and fix commit message wrapping to 75 chars.
> > This is found by smatch and only compile tested.
>
> * Can it occasionally be nicer to use an enumeration also for
> version descriptions?
>
> * Is it helpful to separate additional comments by blank lines?
>
>
> > ---
> > drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 2 +-
>
> How do you think about to omit a repeated marker line here?
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2024-05-20 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:49 [PATCH v2] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove() Harshit Mogalapalli
2024-05-17 15:15 ` srinivas pandruvada
2024-05-18 17:30 ` Markus Elfring
2024-05-20 9:38 ` Ilpo Järvinen [this message]
2024-05-20 10:56 ` [v2] " Markus Elfring
2024-05-20 17:49 ` Hans de Goede
2024-05-21 5:15 ` Markus Elfring
2024-05-21 10:06 ` Ilpo Järvinen
2024-05-21 10:42 ` Markus Elfring
2024-05-21 10:56 ` Ilpo Järvinen
2024-05-21 11:09 ` Markus Elfring
2024-05-27 9:29 ` [PATCH v2] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1bf351-77cc-7fe9-2d62-8bd99789e4f1@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox