From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Hans de Goede <hdegoede@redhat.com>,
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Zhang Rui <rui.zhang@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [v2] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()
Date: Tue, 21 May 2024 13:06:11 +0300 (EEST) [thread overview]
Message-ID: <a8eb3ba6-eeab-6c0c-7b57-4fde508853ed@linux.intel.com> (raw)
In-Reply-To: <51368bcf-d2e3-42cc-a112-a1a485f29c73@web.de>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Tue, 21 May 2024, Markus Elfring wrote:
> >>>> …
> >>>>> Fix this by reordering the kfree() post the dereference.
> …
> > The original wording of the commit message really is fine as is,
> > I see no need for Harshit to send a new version and I plan to
> > merge this as is.
>
> Are there opportunities remaining to improve the discussed wording?
>
> 1. https://en.wiktionary.org/wiki/post#Etymology_1
>
> 2. https://en.wiktionary.org/wiki/reorder
>
> 3. Function call indication?
> https://elixir.bootlin.com/linux/v6.9.1/source/mm/slub.c#L4371
>
> 4. Rephrasing of “Fix this by …”?
>
> 5. https://en.wikipedia.org/wiki/Dangling_pointer#Cause_of_dangling_pointers
>
> 6. https://wiki.sei.cmu.edu/confluence/display/c/MEM30-C.+Do+not+access+freed+memory#MEM30C.Donotaccessfreedmemory-AutomatedDetection
>
> 7. https://en.wikipedia.org/wiki/Code_sanitizer#KernelAddressSanitizer
We'll not waste our time in wordsmithing commit messages to perfection,
the current one is good enough as was stated to you already.
--
i.
next prev parent reply other threads:[~2024-05-21 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:49 [PATCH v2] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove() Harshit Mogalapalli
2024-05-17 15:15 ` srinivas pandruvada
2024-05-18 17:30 ` Markus Elfring
2024-05-20 9:38 ` Ilpo Järvinen
2024-05-20 10:56 ` [v2] " Markus Elfring
2024-05-20 17:49 ` Hans de Goede
2024-05-21 5:15 ` Markus Elfring
2024-05-21 10:06 ` Ilpo Järvinen [this message]
2024-05-21 10:42 ` Markus Elfring
2024-05-21 10:56 ` Ilpo Järvinen
2024-05-21 11:09 ` Markus Elfring
2024-05-27 9:29 ` [PATCH v2] " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8eb3ba6-eeab-6c0c-7b57-4fde508853ed@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox