From: Russ Weight <russell.h.weight@intel.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linuxppc-dev@lists.ozlabs.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
<linux-kernel@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h>
Date: Mon, 28 Nov 2022 17:18:40 -0800 [thread overview]
Message-ID: <6dc8ce0d-6587-5f39-d8cc-e4626ebfaf41@intel.com> (raw)
In-Reply-To: <20221126051002.123199-1-linux@weissschuh.net>
On 11/25/22 21:09, Thomas Weißschuh wrote:
> utsrelease.h is potentially generated on each build.
> By removing this unused include we can get rid of some spurious
> recompilations.
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/base/firmware_loader/firmware.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h
> index fe77e91c38a2..bf549d6500d7 100644
> --- a/drivers/base/firmware_loader/firmware.h
> +++ b/drivers/base/firmware_loader/firmware.h
> @@ -9,8 +9,6 @@
> #include <linux/list.h>
> #include <linux/completion.h>
>
> -#include <generated/utsrelease.h>
> -
> /**
> * enum fw_opt - options to control firmware loading behaviour
> *
>
> base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536
next prev parent reply other threads:[~2022-11-29 1:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 5:09 [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h> Thomas Weißschuh
2022-11-26 5:10 ` [PATCH 2/3] powerpc/book3e: " Thomas Weißschuh
2022-11-26 7:36 ` Christophe Leroy
2022-11-26 14:07 ` Thomas Weißschuh
2022-11-26 14:54 ` Christophe Leroy
2022-11-27 22:59 ` Michael Ellerman
2022-11-29 9:34 ` Masahiro Yamada
2022-11-26 22:17 ` Masahiro Yamada
2022-11-26 5:10 ` [PATCH 3/3] init/version.c: remove #include <generated/utsversion.h> Thomas Weißschuh
2022-11-26 22:18 ` Masahiro Yamada
2022-11-29 9:33 ` Masahiro Yamada
2022-11-26 22:13 ` [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h> Masahiro Yamada
2022-11-29 1:18 ` Russ Weight [this message]
2022-11-29 9:31 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc8ce0d-6587-5f39-d8cc-e4626ebfaf41@intel.com \
--to=russell.h.weight@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox