From: Michael Ellerman <mpe@ellerman.id.au>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russell.h.weight@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 2/3] powerpc/book3e: remove #include <generated/utsrelease.h>
Date: Mon, 28 Nov 2022 09:59:31 +1100 [thread overview]
Message-ID: <87r0xoatrg.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <8f8b12fd-2e25-49e4-a1fa-247f08f56454@t-8ch.de>
Thomas Weißschuh <linux@weissschuh.net> writes:
> On 2022-11-26 07:36+0000, Christophe Leroy wrote:
>> Le 26/11/2022 à 06:10, Thomas Weißschuh a écrit :
>>> Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include <generated/compile.h>")
>>> removed the usage of the define UTS_VERSION but forgot to drop the
>>> include.
>>
>> What about:
>> arch/powerpc/platforms/52xx/efika.c
>> arch/powerpc/platforms/amigaone/setup.c
>> arch/powerpc/platforms/chrp/setup.c
>> arch/powerpc/platforms/powermac/bootx_init.c
>>
>> I believe you can do a lot more than what you did in your series.
>
> The commit messages are wrong.
> They should have said UTS_RELEASE instead of UTS_VERSION.
>
> Could the maintainers fix this up when applying?
> I also changed it locally so it will be fixed for v2.
I'll take this patch, but not the others.
cheers
next prev parent reply other threads:[~2022-11-27 22:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 5:09 [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h> Thomas Weißschuh
2022-11-26 5:10 ` [PATCH 2/3] powerpc/book3e: " Thomas Weißschuh
2022-11-26 7:36 ` Christophe Leroy
2022-11-26 14:07 ` Thomas Weißschuh
2022-11-26 14:54 ` Christophe Leroy
2022-11-27 22:59 ` Michael Ellerman [this message]
2022-11-29 9:34 ` Masahiro Yamada
2022-11-26 22:17 ` Masahiro Yamada
2022-11-26 5:10 ` [PATCH 3/3] init/version.c: remove #include <generated/utsversion.h> Thomas Weißschuh
2022-11-26 22:18 ` Masahiro Yamada
2022-11-29 9:33 ` Masahiro Yamada
2022-11-26 22:13 ` [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h> Masahiro Yamada
2022-11-29 1:18 ` Russ Weight
2022-11-29 9:31 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0xoatrg.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=npiggin@gmail.com \
--cc=rafael@kernel.org \
--cc=russell.h.weight@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox