From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nam Tran <trannamatk@gmail.com>,
pavel@kernel.org, lee@kernel.org, krzk+dt@kernel.org,
robh@kernel.org, conor+dt@kernel.org, corbet@lwn.net
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/5] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
Date: Mon, 14 Apr 2025 17:10:56 +0200 [thread overview]
Message-ID: <6e054aad-8e2d-46d9-a45b-e334f7826f5d@kernel.org> (raw)
In-Reply-To: <20250414145742.35713-6-trannamatk@gmail.com>
On 14/04/2025 16:57, Nam Tran wrote:
> Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
> This enables the LED connected to the LP5812 to be controlled via I2C.
>
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
> .../arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> index 353bb50ce542..0dec6ce44c6c 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> @@ -152,6 +152,66 @@ &hdmi1 {
> status = "okay";
> };
>
> +&i2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@1b {
> + compatible = "ti,lp5812";
> + reg = <0x1b>;
Messed indentation... You already got such comment about your DTS in the
binding. :/
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-14 15:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 14:57 [PATCH v5 0/5] leds: add new LED driver for TI LP5812 Nam Tran
2025-04-14 14:57 ` [PATCH v5 1/5] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver Nam Tran
2025-04-14 15:10 ` Krzysztof Kozlowski
2025-04-15 9:53 ` Nam Tran
2025-04-15 9:59 ` Krzysztof Kozlowski
2025-04-17 2:06 ` Nam Tran
2025-04-17 5:43 ` Krzysztof Kozlowski
2025-04-17 9:37 ` Nam Tran
2025-04-14 14:57 ` [PATCH v5 2/5] " Nam Tran
2025-04-14 14:57 ` [PATCH v5 3/5] docs: ABI: Document LP5812 LED sysfs interfaces Nam Tran
2025-04-14 14:57 ` [PATCH v5 4/5] docs: leds: Document TI LP5812 LED driver Nam Tran
2025-04-14 14:57 ` [PATCH v5 5/5] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B Nam Tran
2025-04-14 15:10 ` Krzysztof Kozlowski [this message]
2025-04-15 9:56 ` Nam Tran
2025-04-14 15:05 ` [PATCH v5 0/5] leds: add new LED driver for TI LP5812 Krzysztof Kozlowski
2025-04-18 4:43 ` Nam Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e054aad-8e2d-46d9-a45b-e334f7826f5d@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
--cc=trannamatk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox