Re: [PATCH v5 1/5] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/04/2025 04:06, Nam Tran wrote:
> 
>>>
>>>>> +
>>>>> +patternProperties:
>>>>> +  "^led@[0-9a-b]$":
>>>>> +    type: object
>>>>> +    $ref: common.yaml#
>>>>> +    unevaluatedProperties: false
>>>>> +
>>>>> +    properties:
>>>>> +      reg:
>>>>> +        minimum: 0
>>>>> +        maximum: 0xb
>>>>> +
>>>>> +      chan-name:
>>>>> +        $ref: /schemas/types.yaml#/definitions/string
>>>>> +        description: LED channel name
>>>>
>>>> My comment stay valid. I don't think LEDs have channels, datasheet also
>>>> has nothing about channels, so again - use existing properties. Or
>>>> better drop it - I don't see any point in the name. The reg already
>>>> defines it.
>>>
>>> The channel was named for the output channel to each LED, not the LED channels.
>>
>> I don't understand what you want to say. Please explain why existing
>> label property is not correct here.
> 
> I understand that the label property is deprecated and that the preferred approach now is to use function and color instead.
> However, in the case of the LP5812, which is a matrix LED driver, these properties are not a good fit.
> The LP5812 does not associate each output with a specific function (like "status", "activity"),
> and the LEDs driven by LP5812 are not fixed to a particular color.

Then use label instead of creating another property. If label is
deprecated, how creating another property which duplicates the label
solves anything?


Best regards,
Krzysztof