From: <Conor.Dooley@microchip.com>
To: <yuanjilin@cdjrlc.com>, <johan@kernel.org>, <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb/serial: fix repeated words in comments
Date: Sun, 21 Aug 2022 15:42:55 +0000 [thread overview]
Message-ID: <6f3059bf-1a12-8ad4-305c-50fc5e0782bc@microchip.com> (raw)
In-Reply-To: <20220821153441.6165-1-yuanjilin@cdjrlc.com>
Hi,
On 21/08/2022 16:34, Jilin Yuan wrote:
> Delete the redundant word 'more'.
>
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
> drivers/usb/serial/mct_u232.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/mct_u232.h b/drivers/usb/serial/mct_u232.h
> index e3d09a83cab1..f79a1f1b6a98 100644
> --- a/drivers/usb/serial/mct_u232.h
> +++ b/drivers/usb/serial/mct_u232.h
> @@ -273,13 +273,13 @@ static int mct_u232_calculate_baud_rate(struct usb_serial *serial,
> * Bit 5: Data Set Ready (DSR). Reflects the state of the DSR line on the UART.
> * Bit 4: Clear To Send (CTS). Reflects the state of the CTS line on the UART.
> * Bit 3: Delta Data Carrier Detect (DDCD). Set to "1" if the -DCD line has
> - * changed state one more more times since the last time the MSR was
> + * changed state one more times since the last time the MSR was
This does not really make much sense before or after the patch.
Should it read: "one or more times"?
Thanks,
Conor.
> * read by the host.
> * Bit 2: Trailing Edge Ring Indicator (TERI). Set to "1" if the -RI line has
> * had a low to high transition since the last time the MSR was read by
> * the host.
> * Bit 1: Delta Data Set Ready (DDSR). Set to "1" if the -DSR line has changed
> - * state one more more times since the last time the MSR was read by the
> + * state one more times since the last time the MSR was read by the
> * host.
> * Bit 0: Delta Clear To Send (DCTS). Set to "1" if the -CTS line has changed
> * state one more times since the last time the MSR was read by the
next prev parent reply other threads:[~2022-08-21 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 15:34 [PATCH] usb/serial: fix repeated words in comments Jilin Yuan
2022-08-21 15:42 ` Conor.Dooley [this message]
[not found] ` <tencent_1AC094251C7AD08A5B832814@qq.com>
2022-08-22 12:26 ` Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2022-07-16 13:48 Jilin Yuan
2022-07-18 10:26 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f3059bf-1a12-8ad4-305c-50fc5e0782bc@microchip.com \
--to=conor.dooley@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox