From: Johan Hovold <johan@kernel.org>
To: 无名 <yuanjilin@cdjrlc.com>
Cc: gregkh <gregkh@linuxfoundation.org>,
linux-usb <linux-usb@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb/serial: fix repeated words in comments
Date: Mon, 22 Aug 2022 14:26:07 +0200 [thread overview]
Message-ID: <YwN138qeP74YZ9Em@hovoldconsulting.com> (raw)
In-Reply-To: <tencent_1AC094251C7AD08A5B832814@qq.com>
On Mon, Aug 22, 2022 at 07:47:39PM +0800, 无名 wrote:
> Replace 'mode' with 'or'
This is not a proper commit message as it only says what you do, not
why. Try to spell it out.
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
Missing changelog here.
> drivers/usb/serial/mct_u232.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This patch is corrupt and looks like it was sent as HTML too.
Also look at the git log for this file and use the common Subject
prefix.
It's also customary to CC people that have helped review your patch.
Johan
next prev parent reply other threads:[~2022-08-22 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 15:34 [PATCH] usb/serial: fix repeated words in comments Jilin Yuan
2022-08-21 15:42 ` Conor.Dooley
[not found] ` <tencent_1AC094251C7AD08A5B832814@qq.com>
2022-08-22 12:26 ` Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-16 13:48 Jilin Yuan
2022-07-18 10:26 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwN138qeP74YZ9Em@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox