[PATCH] usb/serial: fix repeated words in comments

[PATCH] usb/serial: fix repeated words in comments

[Jilin Yuan]

 Delete the redundant word 'more'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/usb/serial/mct_u232.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/mct_u232.h b/drivers/usb/serial/mct_u232.h
index e3d09a83cab1..f79a1f1b6a98 100644
--- a/drivers/usb/serial/mct_u232.h
+++ b/drivers/usb/serial/mct_u232.h
@@ -273,13 +273,13 @@ static int mct_u232_calculate_baud_rate(struct usb_serial *serial,
  *  Bit 5: Data Set Ready (DSR). Reflects the state of the DSR line on the UART.
  *  Bit 4: Clear To Send (CTS). Reflects the state of the CTS line on the UART.
  *  Bit 3: Delta Data Carrier Detect (DDCD). Set to "1" if the -DCD line has
- *	   changed state one more more times since the last time the MSR was
+ *	   changed state one more times since the last time the MSR was
  *	   read by the host.
  *  Bit 2: Trailing Edge Ring Indicator (TERI). Set to "1" if the -RI line has
  *	   had a low to high transition since the last time the MSR was read by
  *	   the host.
  *  Bit 1: Delta Data Set Ready (DDSR). Set to "1" if the -DSR line has changed
- *	   state one more more times since the last time the MSR was read by the
+ *	   state one more times since the last time the MSR was read by the
  *	   host.
  *  Bit 0: Delta Clear To Send (DCTS). Set to "1" if the -CTS line has changed
  *	   state one more times since the last time the MSR was read by the
-- 
2.36.1

Re: [PATCH] usb/serial: fix repeated words in comments

[Conor.Dooley]

Hi,
On 21/08/2022 16:34, Jilin Yuan wrote:
>  Delete the redundant word 'more'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  drivers/usb/serial/mct_u232.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/mct_u232.h b/drivers/usb/serial/mct_u232.h
> index e3d09a83cab1..f79a1f1b6a98 100644
> --- a/drivers/usb/serial/mct_u232.h
> +++ b/drivers/usb/serial/mct_u232.h
> @@ -273,13 +273,13 @@ static int mct_u232_calculate_baud_rate(struct usb_serial *serial,
>   *  Bit 5: Data Set Ready (DSR). Reflects the state of the DSR line on the UART.
>   *  Bit 4: Clear To Send (CTS). Reflects the state of the CTS line on the UART.
>   *  Bit 3: Delta Data Carrier Detect (DDCD). Set to "1" if the -DCD line has
> - *	   changed state one more more times since the last time the MSR was
> + *	   changed state one more times since the last time the MSR was

This does not really make much sense before or after the patch.
Should it read: "one or more times"?

Thanks,
Conor.

>   *	   read by the host.
>   *  Bit 2: Trailing Edge Ring Indicator (TERI). Set to "1" if the -RI line has
>   *	   had a low to high transition since the last time the MSR was read by
>   *	   the host.
>   *  Bit 1: Delta Data Set Ready (DDSR). Set to "1" if the -DSR line has changed
> - *	   state one more more times since the last time the MSR was read by the
> + *	   state one more times since the last time the MSR was read by the
>   *	   host.
>   *  Bit 0: Delta Clear To Send (DCTS). Set to "1" if the -CTS line has changed
>   *	   state one more times since the last time the MSR was read by the

Re: [PATCH] usb/serial: fix repeated words in comments

[Johan Hovold]

On Mon, Aug 22, 2022 at 07:47:39PM +0800, 无名 wrote:
> Replace 'mode' with 'or'

This is not a proper commit message as it only says what you do, not
why. Try to spell it out.

> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com&gt;
> ---

Missing changelog here.

> &nbsp;drivers/usb/serial/mct_u232.h | 4 ++--
> &nbsp;1 file changed, 2 insertions(+), 2 deletions(-)

This patch is corrupt and looks like it was sent as HTML too.

Also look at the git log for this file and use the common Subject
prefix.

It's also customary to CC people that have helped review your patch.

Johan

[PATCH] usb/serial: fix repeated words in comments

[Jilin Yuan]

 Delete the redundant word 'the'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/usb/serial/cypress_m8.c | 2 +-
 drivers/usb/serial/mos7720.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 6924fa95f6bd..da8913683104 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -256,7 +256,7 @@ static int analyze_baud_rate(struct usb_serial_port *port, speed_t new_rate)
 		/*
 		 * Mike Isely <isely@pobox.com> 2-Feb-2008: The
 		 * Cypress app note that describes this mechanism
-		 * states the the low-speed part can't handle more
+		 * states the low-speed part can't handle more
 		 * than 800 bytes/sec, in which case 4800 baud is the
 		 * safest speed for a part like that.
 		 */
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 1e12b5f30dcc..23ccbba716c7 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -826,7 +826,7 @@ static int mos77xx_calc_num_ports(struct usb_serial *serial,
 		/*
 		 * The 7715 uses the first bulk in/out endpoint pair for the
 		 * parallel port, and the second for the serial port. We swap
-		 * the endpoint descriptors here so that the the first and
+		 * the endpoint descriptors here so that the first and
 		 * only registered port structure uses the serial-port
 		 * endpoints.
 		 */
-- 
2.36.1

Re: [PATCH] usb/serial: fix repeated words in comments

[Johan Hovold]

On Sat, Jul 16, 2022 at 09:48:26PM +0800, Jilin Yuan wrote:
>  Delete the redundant word 'the'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>

This has been addressed in -next:


	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9ec7e8d5fae34b3da52b4b0a7a47877bc6aa8416

Johan