* [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake
@ 2025-10-28 17:29 Tony Luck
2025-10-28 19:57 ` Dave Hansen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tony Luck @ 2025-10-28 17:29 UTC (permalink / raw)
To: Dave Hansen; +Cc: x86, linux-kernel, patches, Tony Luck
The E-core in Panther Lake is Darkmont, not Crestmont.
Nova Lake is built from Coyote Cove (P-core) and Arctic Wolf (E-core).
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
arch/x86/include/asm/intel-family.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
index f32a0eca2ae5..950bfd006905 100644
--- a/arch/x86/include/asm/intel-family.h
+++ b/arch/x86/include/asm/intel-family.h
@@ -150,12 +150,12 @@
#define INTEL_LUNARLAKE_M IFM(6, 0xBD) /* Lion Cove / Skymont */
-#define INTEL_PANTHERLAKE_L IFM(6, 0xCC) /* Cougar Cove / Crestmont */
+#define INTEL_PANTHERLAKE_L IFM(6, 0xCC) /* Cougar Cove / Darkmont */
#define INTEL_WILDCATLAKE_L IFM(6, 0xD5)
-#define INTEL_NOVALAKE IFM(18, 0x01)
-#define INTEL_NOVALAKE_L IFM(18, 0x03)
+#define INTEL_NOVALAKE IFM(18, 0x01) /* Coyote Cove / Arctic Wolf */
+#define INTEL_NOVALAKE_L IFM(18, 0x03) /* Coyote Cove / Arctic Wolf */
/* "Small Core" Processors (Atom/E-Core) */
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake
2025-10-28 17:29 [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake Tony Luck
@ 2025-10-28 19:57 ` Dave Hansen
2025-10-28 20:44 ` Andrew Cooper
2025-10-28 21:19 ` Luck, Tony
2025-10-29 8:42 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
2025-10-30 10:36 ` tip-bot2 for Tony Luck
2 siblings, 2 replies; 6+ messages in thread
From: Dave Hansen @ 2025-10-28 19:57 UTC (permalink / raw)
To: Tony Luck; +Cc: x86, linux-kernel, patches
On 10/28/25 10:29, Tony Luck wrote:
> -#define INTEL_NOVALAKE IFM(18, 0x01)
> -#define INTEL_NOVALAKE_L IFM(18, 0x03)
> +#define INTEL_NOVALAKE IFM(18, 0x01) /* Coyote Cove / Arctic Wolf */
> +#define INTEL_NOVALAKE_L IFM(18, 0x03) /* Coyote Cove / Arctic Wolf */
Is it even worth keeping the core names in there? This is an example
where they're causing churn. If nobody cares, maybe we should just
zap them, or at least stop putting them in there for new CPUs.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake
2025-10-28 19:57 ` Dave Hansen
@ 2025-10-28 20:44 ` Andrew Cooper
2025-10-28 21:19 ` Luck, Tony
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2025-10-28 20:44 UTC (permalink / raw)
To: dave.hansen; +Cc: linux-kernel, patches, tony.luck, x86
> Is it even worth keeping the core names in there? This is an example
> where they're causing churn. If nobody cares, maybe we should just
> zap them, or at least stop putting them in there for new CPUs.
Personally speaking, I find it very useful to have the cross reference
all in one place.
This file is the most concise source of information I'm aware of.
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake
2025-10-28 19:57 ` Dave Hansen
2025-10-28 20:44 ` Andrew Cooper
@ 2025-10-28 21:19 ` Luck, Tony
1 sibling, 0 replies; 6+ messages in thread
From: Luck, Tony @ 2025-10-28 21:19 UTC (permalink / raw)
To: Hansen, Dave, Peter Zijlstra
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
patches@lists.linux.dev
On 10/28/25 10:29, Tony Luck wrote:
> > -#define INTEL_NOVALAKE IFM(18, 0x01)
> > -#define INTEL_NOVALAKE_L IFM(18, 0x03)
> > +#define INTEL_NOVALAKE IFM(18, 0x01) /* Coyote Cove / Arctic Wolf */
> > +#define INTEL_NOVALAKE_L IFM(18, 0x03) /* Coyote Cove / Arctic Wolf */
>
> Is it even worth keeping the core names in there? This is an example
> where they're causing churn. If nobody cares, maybe we should just
> zap them, or at least stop putting them in there for new CPUs.
PeterZ thought the comments were useful to track CPU model specific places
(like "perf") where multiple Intel CPU models can share the same code.
-Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip: x86/urgent] x86/cpu: Add/fix core comments for {Panther,Nova} Lake
2025-10-28 17:29 [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake Tony Luck
2025-10-28 19:57 ` Dave Hansen
@ 2025-10-29 8:42 ` tip-bot2 for Tony Luck
2025-10-30 10:36 ` tip-bot2 for Tony Luck
2 siblings, 0 replies; 6+ messages in thread
From: tip-bot2 for Tony Luck @ 2025-10-29 8:42 UTC (permalink / raw)
To: linux-tip-commits
Cc: Tony Luck, Ingo Molnar, Peter Zijlstra, x86, linux-kernel
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 1e7fb6602e2e63b92430ec54a9edb731a51dfbc7
Gitweb: https://git.kernel.org/tip/1e7fb6602e2e63b92430ec54a9edb731a51dfbc7
Author: Tony Luck <tony.luck@intel.com>
AuthorDate: Tue, 28 Oct 2025 10:29:48 -07:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 29 Oct 2025 09:39:34 +01:00
x86/cpu: Add/fix core comments for {Panther,Nova} Lake
The E-core in Panther Lake is Darkmont, not Crestmont.
Nova Lake is built from Coyote Cove (P-core) and Arctic Wolf (E-core).
Fixes: 43bb700cff6b ("x86/cpu: Update Intel Family comments")
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://patch.msgid.link/20251028172948.6721-1-tony.luck@intel.com
---
arch/x86/include/asm/intel-family.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
index f32a0ec..950bfd0 100644
--- a/arch/x86/include/asm/intel-family.h
+++ b/arch/x86/include/asm/intel-family.h
@@ -150,12 +150,12 @@
#define INTEL_LUNARLAKE_M IFM(6, 0xBD) /* Lion Cove / Skymont */
-#define INTEL_PANTHERLAKE_L IFM(6, 0xCC) /* Cougar Cove / Crestmont */
+#define INTEL_PANTHERLAKE_L IFM(6, 0xCC) /* Cougar Cove / Darkmont */
#define INTEL_WILDCATLAKE_L IFM(6, 0xD5)
-#define INTEL_NOVALAKE IFM(18, 0x01)
-#define INTEL_NOVALAKE_L IFM(18, 0x03)
+#define INTEL_NOVALAKE IFM(18, 0x01) /* Coyote Cove / Arctic Wolf */
+#define INTEL_NOVALAKE_L IFM(18, 0x03) /* Coyote Cove / Arctic Wolf */
/* "Small Core" Processors (Atom/E-Core) */
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [tip: x86/urgent] x86/cpu: Add/fix core comments for {Panther,Nova} Lake
2025-10-28 17:29 [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake Tony Luck
2025-10-28 19:57 ` Dave Hansen
2025-10-29 8:42 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
@ 2025-10-30 10:36 ` tip-bot2 for Tony Luck
2 siblings, 0 replies; 6+ messages in thread
From: tip-bot2 for Tony Luck @ 2025-10-30 10:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: Tony Luck, Ingo Molnar, Dave Hansen, Peter Zijlstra, x86,
linux-kernel
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 89216c9051ef6635f1514f8e0d2f9cd63b37a3b6
Gitweb: https://git.kernel.org/tip/89216c9051ef6635f1514f8e0d2f9cd63b37a3b6
Author: Tony Luck <tony.luck@intel.com>
AuthorDate: Tue, 28 Oct 2025 10:29:48 -07:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 30 Oct 2025 11:34:02 +01:00
x86/cpu: Add/fix core comments for {Panther,Nova} Lake
The E-core in Panther Lake is Darkmont, not Crestmont.
Nova Lake is built from Coyote Cove (P-core) and Arctic Wolf (E-core).
Fixes: 43bb700cff6b ("x86/cpu: Update Intel Family comments")
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://patch.msgid.link/20251028172948.6721-1-tony.luck@intel.com
---
arch/x86/include/asm/intel-family.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
index f32a0ec..950bfd0 100644
--- a/arch/x86/include/asm/intel-family.h
+++ b/arch/x86/include/asm/intel-family.h
@@ -150,12 +150,12 @@
#define INTEL_LUNARLAKE_M IFM(6, 0xBD) /* Lion Cove / Skymont */
-#define INTEL_PANTHERLAKE_L IFM(6, 0xCC) /* Cougar Cove / Crestmont */
+#define INTEL_PANTHERLAKE_L IFM(6, 0xCC) /* Cougar Cove / Darkmont */
#define INTEL_WILDCATLAKE_L IFM(6, 0xD5)
-#define INTEL_NOVALAKE IFM(18, 0x01)
-#define INTEL_NOVALAKE_L IFM(18, 0x03)
+#define INTEL_NOVALAKE IFM(18, 0x01) /* Coyote Cove / Arctic Wolf */
+#define INTEL_NOVALAKE_L IFM(18, 0x03) /* Coyote Cove / Arctic Wolf */
/* "Small Core" Processors (Atom/E-Core) */
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-30 10:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-28 17:29 [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake Tony Luck
2025-10-28 19:57 ` Dave Hansen
2025-10-28 20:44 ` Andrew Cooper
2025-10-28 21:19 ` Luck, Tony
2025-10-29 8:42 ` [tip: x86/urgent] " tip-bot2 for Tony Luck
2025-10-30 10:36 ` tip-bot2 for Tony Luck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox