Re: [PATCH v2 2/2] Fix the source file annotation information for the "FOLL_WRITE" macro copied.

[John Hubbard <jhubbard@nvidia.com>]

On 11/14/25 8:11 AM, peng8420.li@gmail.com wrote:
> From: "peng8420.li" <peng8420.li@gmail.com>

Please see my reply to patch 1/1, about the real name, and the
From: item too.

> 
> The 'FOLL_RITE' of the copied source is located in mm_types. h of mm, not mm. h, so fix it.

"FOLL_WRITE"

Also, please wrap to 72 columns.

> 
> Suggested-by: "David Hildenbrand (Red Hat)" <david@kernel.org>
> Signed-off-by: peng8420.li <peng8420.li@gmail.com>
> ---
>  tools/testing/selftests/mm/gup_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c
> index 75f7134d529d..40c1538a17b4 100644
> --- a/tools/testing/selftests/mm/gup_test.c
> +++ b/tools/testing/selftests/mm/gup_test.c
> @@ -17,7 +17,7 @@
>  
>  #define MB (1UL << 20)
>  
> -/* Just the flags we need, copied from mm.h: */
> +/* Just the flags we need, copied from the kernel internals. */
>  #define FOLL_WRITE	0x01	/* check pte is writable */
>  
>  #define GUP_TEST_FILE "/sys/kernel/debug/gup_test"

With the commit log fixed up, please feel free to add:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
-- 
John Hubbard