The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: ygardi@codeaurora.org
Cc: james.bottomley@hansenpartnership.com,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
	linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
	gbroner@codeaurora.org, draviv@codeaurora.org,
	Noa Rubens <noag@codeaurora.org>,
	Raviv Shvili <rshvili@codeaurora.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	"James E.J. Bottomley" <jbottomley@odin.com>,
	"open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: add ioctl interface for query request
Date: Wed, 07 Oct 2015 14:37:35 +0200	[thread overview]
Message-ID: <7161690.NZs9VETTEZ@wuerfel> (raw)
In-Reply-To: <c154d3ff11646f056401afd4fa348d1b.squirrel@www.codeaurora.org>

On Wednesday 07 October 2015 12:27:54 ygardi@codeaurora.org wrote:
> 
> >> +
> >> +/*
> >> + *  IOCTL opcode for ufs queries has the following opcode after
> >> + *  SCSI_IOCTL_GET_PCI
> >> + */
> >> +#define UFS_IOCTL_QUERY                     0x5388
> >
> > Use _IOWR() to define that number with the correct argument length
> 
> i'd rather leave it as is, to be compatible with the SCSI_IOCTL
> opcodes that are defined in scsi_ioctl.h

Do you mean you require this code to work on SunOS? ;-)

If not, better use the normal conventions that Linux and BSD have for
new ioctls.

Note that the 0x53xx ioctl command numbers are also used by
include/uapi/linux/cdrom.h, this one would be right in the middle
of that.

	Arnd

      reply	other threads:[~2015-10-07 12:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07  7:54 [PATCH v2] scsi: ufs: add ioctl interface for query request Yaniv Gardi
2015-10-07  8:11 ` Arnd Bergmann
2015-10-07 12:27   ` ygardi
2015-10-07 12:37     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7161690.NZs9VETTEZ@wuerfel \
    --to=arnd@arndb.de \
    --cc=draviv@codeaurora.org \
    --cc=gbroner@codeaurora.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jbottomley@odin.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=noag@codeaurora.org \
    --cc=rshvili@codeaurora.org \
    --cc=santoshsy@gmail.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    --cc=ygardi@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox