* [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action
@ 2026-05-06 0:00 Prathamesh Deshpande
2026-05-09 13:25 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Prathamesh Deshpande @ 2026-05-06 0:00 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky
Cc: Moshe Shemesh, Tariq Toukan, Mark Bloch, netdev, linux-kernel,
Prathamesh Deshpande
mlx5_cmd_hws_packet_reformat_alloc() handles
MLX5_REFORMAT_TYPE_REMOVE_HDR by looking up a matching HWS remove-header
action.
If mlx5_fs_get_action_remove_header_vlan() returns NULL, the code only
logs an error and continues. The function then returns success with a NULL
HWS action stored in the packet-reformat object.
Return an error when no matching remove-header action is available.
Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API function")
Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
---
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
index aca77853abb8..5a172c572a68 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
@@ -1320,8 +1320,10 @@ mlx5_cmd_hws_packet_reformat_alloc(struct mlx5_flow_root_namespace *ns,
break;
case MLX5_REFORMAT_TYPE_REMOVE_HDR:
hws_action = mlx5_fs_get_action_remove_header_vlan(fs_ctx, params);
- if (!hws_action)
+ if (!hws_action) {
mlx5_core_err(dev, "Only vlan remove header supported\n");
+ return -EOPNOTSUPP;
+ }
break;
default:
mlx5_core_err(ns->dev, "Packet-reformat not supported(%d)\n",
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action
2026-05-06 0:00 [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action Prathamesh Deshpande
@ 2026-05-09 13:25 ` Simon Horman
2026-05-10 8:10 ` Yevgeny Kliteynik
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2026-05-09 13:25 UTC (permalink / raw)
To: Prathamesh Deshpande
Cc: Saeed Mahameed, Leon Romanovsky, Moshe Shemesh, Tariq Toukan,
Mark Bloch, netdev, linux-kernel
On Wed, May 06, 2026 at 01:00:31AM +0100, Prathamesh Deshpande wrote:
> mlx5_cmd_hws_packet_reformat_alloc() handles
> MLX5_REFORMAT_TYPE_REMOVE_HDR by looking up a matching HWS remove-header
> action.
>
> If mlx5_fs_get_action_remove_header_vlan() returns NULL, the code only
> logs an error and continues. The function then returns success with a NULL
> HWS action stored in the packet-reformat object.
>
> Return an error when no matching remove-header action is available.
>
> Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API function")
> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action
2026-05-09 13:25 ` Simon Horman
@ 2026-05-10 8:10 ` Yevgeny Kliteynik
0 siblings, 0 replies; 3+ messages in thread
From: Yevgeny Kliteynik @ 2026-05-10 8:10 UTC (permalink / raw)
To: Prathamesh Deshpande
Cc: Simon Horman, Saeed Mahameed, Leon Romanovsky, Moshe Shemesh,
Tariq Toukan, Mark Bloch, netdev, linux-kernel
On 09-May-26 16:25, Simon Horman wrote:
> On Wed, May 06, 2026 at 01:00:31AM +0100, Prathamesh Deshpande wrote:
>> mlx5_cmd_hws_packet_reformat_alloc() handles
>> MLX5_REFORMAT_TYPE_REMOVE_HDR by looking up a matching HWS remove-header
>> action.
>>
>> If mlx5_fs_get_action_remove_header_vlan() returns NULL, the code only
>> logs an error and continues. The function then returns success with a NULL
>> HWS action stored in the packet-reformat object.
>>
>> Return an error when no matching remove-header action is available.
>>
>> Fixes: aecd9d1020e3 ("net/mlx5: fs, add HWS packet reformat API function")
>> Signed-off-by: Prathamesh Deshpande <prathameshdeshpande7@gmail.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-10 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 0:00 [PATCH net v1] net/mlx5: HWS: Reject unsupported remove-header action Prathamesh Deshpande
2026-05-09 13:25 ` Simon Horman
2026-05-10 8:10 ` Yevgeny Kliteynik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox