From: Markus Elfring <Markus.Elfring@web.de>
To: Yunfeng Ye <yeyunfeng@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc()
Date: Fri, 8 May 2020 15:42:40 +0200 [thread overview]
Message-ID: <757dc0e5-3ab7-b00b-11dc-e94a903e3901@web.de> (raw)
In-Reply-To: <bdda096b-9f8a-dacb-9f89-9077d1288ad7@huawei.com>
> An error is found by a internel analysis tool:
> "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c
If such an information will ever be integrated into a final commit message,
I would prefer a wording variant like the following.
Two issues were pointed out by an internal source code analysis tool:
* Line …:
Memory leak: data
* Line …:
Resource leak: fd
Each of these issues has got a different importance for this function implementation.
> Fix the @data and @fd allocations that are leaked in the error path of
> apply_xbc().
How do you think about to replace the @ characters by other delimiters
for the relevant identifiers?
Regards,
Markus
next prev parent reply other threads:[~2020-05-08 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 12:09 [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc() Yunfeng Ye
2020-05-08 13:42 ` Markus Elfring [this message]
2020-05-08 14:40 ` Dan Carpenter
2020-05-08 14:51 ` Dan Carpenter
2020-05-08 15:42 ` [PATCH v4] tools/bootconfig: Completion of error handling Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757dc0e5-3ab7-b00b-11dc-e94a903e3901@web.de \
--to=markus.elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox