The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] workqueue: forbid TEST_WORKQUEUE from being built-in
@ 2026-05-11 12:26 Breno Leitao
  2026-05-11 19:04 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Breno Leitao @ 2026-05-11 12:26 UTC (permalink / raw)
  To: Andrew Morton, Tejun Heo; +Cc: linux-kernel, kernel-team, Breno Leitao

The benchmark drives the workqueue's affinity_scope through sysfs by
filp_open()'ing /sys/bus/workqueue/devices/bench_wq/affinity_scope. When
CONFIG_TEST_WORKQUEUE=y, the module_init runs during kernel init before
userspace has mounted sysfs, so every open returns -ENOENT and the
benchmark loop spins emitting:

  test_workqueue: open /sys/bus/workqueue/devices/bench_wq/affinity_scope failed: -2

Mirror the TEST_BPF pattern and add "depends on m" so Kconfig will not
let this be built into the kernel image, and document the reason in the
help text.

Fixes: 24b2e73f9700 ("workqueue: add test_workqueue benchmark module")
Signed-off-by: Breno Leitao <leitao@debian.org>
---
 lib/Kconfig.debug | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 9d54c48d7d982..9dfe6e16de91b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2666,12 +2666,17 @@ config TEST_VMALLOC
 
 config TEST_WORKQUEUE
 	tristate "Test module for stress/performance analysis of workqueue"
+	depends on m
 	default n
 	help
 	  This builds the "test_workqueue" module for benchmarking
 	  workqueue throughput under contention. Useful for evaluating
 	  affinity scope changes (e.g., cache_shard vs cache).
 
+	  The test drives sysfs to switch affinity scopes, so it must be
+	  loaded after userspace has mounted sysfs; building it in (=y)
+	  would run module_init before /sys is available.
+
 	  If unsure, say N.
 
 config TEST_BPF

---
base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
change-id: 20260511-workqueue_fix_test-eb1134cb7237

Best regards,
--  
Breno Leitao <leitao@debian.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] workqueue: forbid TEST_WORKQUEUE from being built-in
  2026-05-11 12:26 [PATCH] workqueue: forbid TEST_WORKQUEUE from being built-in Breno Leitao
@ 2026-05-11 19:04 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2026-05-11 19:04 UTC (permalink / raw)
  To: Breno Leitao; +Cc: Andrew Morton, linux-kernel, kernel-team

Hello,

Applied to wq/for-7.2.

Thanks.

--
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-11 19:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-11 12:26 [PATCH] workqueue: forbid TEST_WORKQUEUE from being built-in Breno Leitao
2026-05-11 19:04 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox