* Re: [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq
2025-11-04 11:13 [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq Marco Crivellari
@ 2025-12-24 14:56 ` Marco Crivellari
2026-02-04 11:45 ` Marco Crivellari
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Marco Crivellari @ 2025-12-24 14:56 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko, Andrzej Hajda,
Robert Foss, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
On Tue, Nov 4, 2025 at 12:13 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> [...]
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Gentle ping.
Thanks!
--
Marco Crivellari
L3 Support Engineer
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq
2025-11-04 11:13 [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq Marco Crivellari
2025-12-24 14:56 ` Marco Crivellari
@ 2026-02-04 11:45 ` Marco Crivellari
2026-03-09 16:02 ` Marco Crivellari
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Marco Crivellari @ 2026-02-04 11:45 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko, Andrzej Hajda,
Robert Foss, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
On Tue, Nov 4, 2025 at 12:13 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> [...]
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Gentle Ping.
Thanks!
--
Marco Crivellari
L3 Support Engineer
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq
2025-11-04 11:13 [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq Marco Crivellari
2025-12-24 14:56 ` Marco Crivellari
2026-02-04 11:45 ` Marco Crivellari
@ 2026-03-09 16:02 ` Marco Crivellari
2026-03-31 10:10 ` Marco Crivellari
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Marco Crivellari @ 2026-03-09 16:02 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko, Andrzej Hajda,
Robert Foss, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Hi,
On Tue, Nov 4, 2025 at 12:13 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> [...]
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Gentle ping.
Thanks!
--
Marco Crivellari
L3 Support Engineer
On Tue, Nov 4, 2025 at 12:13 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
>
> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
>
> This lack of consistentcy cannot be addressed without refactoring the API.
>
> This patch continues the effort to refactor worqueue APIs, which has begun
> with the change introducing new workqueues and a new alloc_workqueue flag:
>
> commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
>
> system_wq should be the per-cpu workqueue, yet in this name nothing makes
> that clear, so replace system_wq with system_percpu_wq.
>
> The old wq (system_wq) will be kept for a few release cycles.
>
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index a094803ba7aa..37bb8123cf9b 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -2048,7 +2048,7 @@ static void it6505_start_hdcp(struct it6505 *it6505)
>
> DRM_DEV_DEBUG_DRIVER(dev, "start");
> it6505_reset_hdcp(it6505);
> - queue_delayed_work(system_wq, &it6505->hdcp_work,
> + queue_delayed_work(system_percpu_wq, &it6505->hdcp_work,
> msecs_to_jiffies(2400));
> }
>
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index b80ee089f880..85fa3f8a747e 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -115,7 +115,7 @@ static void tfp410_hpd_callback(void *arg, enum drm_connector_status status)
> {
> struct tfp410 *dvi = arg;
>
> - mod_delayed_work(system_wq, &dvi->hpd_work,
> + mod_delayed_work(system_percpu_wq, &dvi->hpd_work,
> msecs_to_jiffies(HOTPLUG_DEBOUNCE_MS));
> }
>
> --
> 2.51.1
>
--
Marco Crivellari
L3 Support Engineer
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq
2025-11-04 11:13 [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq Marco Crivellari
` (2 preceding siblings ...)
2026-03-09 16:02 ` Marco Crivellari
@ 2026-03-31 10:10 ` Marco Crivellari
2026-04-09 9:56 ` Marco Crivellari
2026-04-27 11:19 ` Thomas Zimmermann
5 siblings, 0 replies; 7+ messages in thread
From: Marco Crivellari @ 2026-03-31 10:10 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko, Andrzej Hajda,
Robert Foss, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Hi,
On Tue, Nov 4, 2025 at 12:13 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> [...]
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Gentle ping.
Thanks!
--
Marco Crivellari
L3 Support Engineer
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq
2025-11-04 11:13 [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq Marco Crivellari
` (3 preceding siblings ...)
2026-03-31 10:10 ` Marco Crivellari
@ 2026-04-09 9:56 ` Marco Crivellari
2026-04-27 11:19 ` Thomas Zimmermann
5 siblings, 0 replies; 7+ messages in thread
From: Marco Crivellari @ 2026-04-09 9:56 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko, Andrzej Hajda,
Robert Foss, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
On Tue, Nov 4, 2025 at 12:13 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> [...]
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Hi,
Gentle ping.
Thanks!
--
Marco Crivellari
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq
2025-11-04 11:13 [PATCH] drm/bridge: replace use of system_wq with system_percpu_wq Marco Crivellari
` (4 preceding siblings ...)
2026-04-09 9:56 ` Marco Crivellari
@ 2026-04-27 11:19 ` Thomas Zimmermann
5 siblings, 0 replies; 7+ messages in thread
From: Thomas Zimmermann @ 2026-04-27 11:19 UTC (permalink / raw)
To: Marco Crivellari, linux-kernel, dri-devel
Cc: Tejun Heo, Lai Jiangshan, Frederic Weisbecker,
Sebastian Andrzej Siewior, Michal Hocko, Andrzej Hajda,
Robert Foss, Maarten Lankhorst, Maxime Ripard, David Airlie,
Simona Vetter
Am 04.11.25 um 12:13 schrieb Marco Crivellari:
> Currently if a user enqueue a work item using schedule_delayed_work() the
> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
> schedule_work() that is using system_wq and queue_work(), that makes use
> again of WORK_CPU_UNBOUND.
>
> This lack of consistentcy cannot be addressed without refactoring the API.
>
> This patch continues the effort to refactor worqueue APIs, which has begun
> with the change introducing new workqueues and a new alloc_workqueue flag:
>
> commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
>
> system_wq should be the per-cpu workqueue, yet in this name nothing makes
> that clear, so replace system_wq with system_percpu_wq.
>
> The old wq (system_wq) will be kept for a few release cycles.
>
> Suggested-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index a094803ba7aa..37bb8123cf9b 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -2048,7 +2048,7 @@ static void it6505_start_hdcp(struct it6505 *it6505)
>
> DRM_DEV_DEBUG_DRIVER(dev, "start");
> it6505_reset_hdcp(it6505);
> - queue_delayed_work(system_wq, &it6505->hdcp_work,
> + queue_delayed_work(system_percpu_wq, &it6505->hdcp_work,
> msecs_to_jiffies(2400));
> }
>
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index b80ee089f880..85fa3f8a747e 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -115,7 +115,7 @@ static void tfp410_hpd_callback(void *arg, enum drm_connector_status status)
> {
> struct tfp410 *dvi = arg;
>
> - mod_delayed_work(system_wq, &dvi->hpd_work,
> + mod_delayed_work(system_percpu_wq, &dvi->hpd_work,
> msecs_to_jiffies(HOTPLUG_DEBOUNCE_MS));
> }
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 7+ messages in thread