public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kevin Chen <kevin_chen@aspeedtech.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	joel@jms.id.au, andrew@codeconstruct.com.au, tglx@linutronix.de,
	catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de,
	olof@lixom.net, quic_bjorande@quicinc.com,
	geert+renesas@glider.be, dmitry.baryshkov@linaro.org,
	konradybcio@kernel.org, neil.armstrong@linaro.org,
	johan+linaro@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	soc@lists.linux.dev
Subject: Re: [PATCH v3 2/6] dt-bindings: arm: aspeed: Add ASPEED AST27XX SoC
Date: Fri, 13 Dec 2024 09:03:46 +0100	[thread overview]
Message-ID: <7b991fca-6e2f-454f-a94d-6a583854769b@kernel.org> (raw)
In-Reply-To: <7289a50a-e139-453f-a512-3dd68a0839a2@kernel.org>

On 13/12/2024 08:59, Krzysztof Kozlowski wrote:
> On 12/12/2024 16:52, Kevin Chen wrote:
>> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
>> ---
>>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> index 2f92b8ab08fa..20191fee1f5b 100644
>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> @@ -101,4 +101,10 @@ properties:
>>                - ufispace,ncplite-bmc
>>            - const: aspeed,ast2600
>>  
>> +      - description: AST2700 based boards
>> +        items:
>> +          - enum:
>> +              - aspeed,ast2700-evb
>> +          - const: aspeed,ast2700
>> +
>>  additionalProperties: true
> 
> 
> 
> This patchset is just corrupted. You already sent it as patch #1.
> 
> Please run scripts/checkpatch.pl and fix reported warnings. Then please
> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
> Some warnings can be ignored, especially from --strict run, but the code
> here looks like it needs a fix. Feel free to get in touch if the warning
> is not clear.
BTW, you already got here same comments before and this is third time
you send exactly the same without implementing what we asked you.

Three times same issue.

NAK

Best regards,
Krzysztof

  reply	other threads:[~2024-12-13  8:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 15:52 [PATCH v3 0/6] Introduce ASPEED AST27XX BMC SoC Kevin Chen
2024-12-12 15:52 ` [PATCH v3 1/6] dt-bindings: arm: aspeed: Add ASPEED AST27XX SoC Kevin Chen
2024-12-13  7:56   ` Krzysztof Kozlowski
2024-12-12 15:52 ` [PATCH v3 1/6] dt-bindings: interrupt-controller: Refine size/interrupt-cell usage Kevin Chen
2024-12-13  7:58   ` Krzysztof Kozlowski
2024-12-18  3:04     ` Kevin Chen
2024-12-18  8:07       ` Krzysztof Kozlowski
2024-12-13  9:10   ` Krzysztof Kozlowski
2024-12-16  3:50     ` Kevin Chen
2024-12-12 15:52 ` [PATCH v3 2/6] dt-bindings: arm: aspeed: Add ASPEED AST27XX SoC Kevin Chen
2024-12-13  7:59   ` Krzysztof Kozlowski
2024-12-13  8:03     ` Krzysztof Kozlowski [this message]
2024-12-18  2:55       ` Kevin Chen
2024-12-18  8:11         ` Krzysztof Kozlowski
2024-12-12 15:52 ` [PATCH v3 2/6] dt-bindings: interrupt-controller: Fix the size-cells in ast2700-intc Kevin Chen
2024-12-13  7:59   ` Krzysztof Kozlowski
2024-12-12 15:52 ` [PATCH v3 3/6] arm64: aspeed: Add support for ASPEED AST27XX BMC SoC Kevin Chen
2024-12-12 15:52 ` [PATCH v3 4/6] arm64: dts: aspeed: Add initial AST27XX device tree Kevin Chen
2024-12-13  8:01   ` Krzysztof Kozlowski
2024-12-18  2:50     ` Kevin Chen
2024-12-12 15:52 ` [PATCH v3 5/6] arm64: dts: aspeed: Add initial AST2700 EVB " Kevin Chen
2024-12-13  8:03   ` Krzysztof Kozlowski
2024-12-16  3:58     ` Kevin Chen
2024-12-12 15:52 ` [PATCH v3 6/6] arm64: defconfig: Add ASPEED AST2700 family support Kevin Chen
2024-12-13  5:07 ` [PATCH v3 0/6] Introduce ASPEED AST27XX BMC SoC Andrew Jeffery
2024-12-16  3:34   ` Kevin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b991fca-6e2f-454f-a94d-6a583854769b@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=joel@jms.id.au \
    --cc=johan+linaro@kernel.org \
    --cc=kevin_chen@aspeedtech.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olof@lixom.net \
    --cc=quic_bjorande@quicinc.com \
    --cc=robh@kernel.org \
    --cc=soc@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox