From: Paul Moore <paul@paul-moore.com>
To: Ricardo Robaina <rrobaina@redhat.com>,
audit@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: eparis@redhat.com, Ricardo Robaina <rrobaina@redhat.com>
Subject: Re: [PATCH] audit: use copied skb length in kauditd_send_multicast_skb()
Date: Mon, 24 Aug 2026 18:25:32 -0400 [thread overview]
Message-ID: <7b9f43325dc569ddb689b02893bde8cc@paul-moore.com> (raw)
In-Reply-To: <20260810125726.775689-2-rrobaina@redhat.com>
On Aug 10, 2026 Ricardo Robaina <rrobaina@redhat.com> wrote:
>
> The netlink header's nlmsg_len was being set using the original skb
> instead of the local copy passed to nlmsg_multicast().
>
> While skb->len and copy->len are identical at this point following
> skb_copy(), it is conceptually cleaner and safer to use the length
> of the skb being actively modified and sent. Thus, this is a minor
> cleanup only, no functional change expected.
>
> Signed-off-by: Ricardo Robaina <rrobaina@redhat.com>
> Reviewed-by: Bradley Morgan <include@grrlz.net>
> ---
> kernel/audit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks reasonable. Merged into audit/dev-staging, will be moved to
audit/dev next week.
--
paul-moore.com
next prev parent reply other threads:[~2026-08-24 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 12:57 [PATCH] audit: use copied skb length in kauditd_send_multicast_skb() Ricardo Robaina
2026-08-10 13:26 ` Bradley Morgan
2026-08-10 15:19 ` Ricardo Robaina
2026-08-10 16:27 ` Bradley Morgan
2026-08-10 20:49 ` Ricardo Robaina
2026-08-10 21:10 ` Bradley Morgan
2026-08-24 22:25 ` Paul Moore [this message]
2026-08-25 12:15 ` Ricardo Robaina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9f43325dc569ddb689b02893bde8cc@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rrobaina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox