* [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes @ 2024-12-05 19:40 Igor Belwon 2024-12-05 19:40 ` [PATCH v1 1/1] arm64: dts: exynos990: Add clock management unit nodes Igor Belwon 2024-12-06 8:35 ` [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes Krzysztof Kozlowski 0 siblings, 2 replies; 5+ messages in thread From: Igor Belwon @ 2024-12-05 19:40 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi all, This patchset adds device tree nodes for Exynos990 CMUs (TOP and HSI0). This patchset is compile-time and runtime dependent on [1], which adds driver support for CMU. [1] https://lore.kernel.org/linux-samsung-soc/20241205193423.783815-1-igor. belwon@mentallysanemainliners.org/T/#t Igor Belwon (1): arm64: dts: exynos990: Add clock management unit nodes arch/arm64/boot/dts/exynos/exynos990.dtsi | 27 +++++++++++++++++++++++ 1 file changed, 27 insertions(+) -- 2.45.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 1/1] arm64: dts: exynos990: Add clock management unit nodes 2024-12-05 19:40 [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes Igor Belwon @ 2024-12-05 19:40 ` Igor Belwon 2024-12-06 8:36 ` Krzysztof Kozlowski 2024-12-06 8:35 ` [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes Krzysztof Kozlowski 1 sibling, 1 reply; 5+ messages in thread From: Igor Belwon @ 2024-12-05 19:40 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel Add CMU nodes for: - cmu_top: provides clocks for other blocks - cmu_hsi0: provides clocks for usb31 Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org> --- arch/arm64/boot/dts/exynos/exynos990.dtsi | 27 +++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos990.dtsi b/arch/arm64/boot/dts/exynos/exynos990.dtsi index c1986f00e443..49bb1e156843 100644 --- a/arch/arm64/boot/dts/exynos/exynos990.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos990.dtsi @@ -5,6 +5,7 @@ * Copyright (c) 2024, Igor Belwon <igor.belwon@mentallysanemainliners.org> */ +#include <dt-bindings/clock/samsung,exynos990.h> #include <dt-bindings/interrupt-controller/arm-gic.h> / { @@ -199,6 +200,23 @@ pinctrl_peric1: pinctrl@10730000 { interrupts = <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>; }; + cmu_hsi0: clock-controller@10a00000 { + compatible = "samsung,exynos990-cmu-hsi0"; + reg = <0x10a00000 0x8000>; + #clock-cells = <1>; + + clocks = <&oscclk>, + <&cmu_top CLK_DOUT_CMU_HSI0_BUS>, + <&cmu_top CLK_DOUT_CMU_HSI0_USB31DRD>, + <&cmu_top CLK_DOUT_CMU_HSI0_USBDP_DEBUG>, + <&cmu_top CLK_DOUT_CMU_HSI0_DPGTC>; + clock-names = "oscclk", "dout_cmu_hsi0_bus", + "dout_cmu_hsi0_usb31drd", + "dout_cmu_hsi0_usbdp_debug", + "dout_cmu_hsi0_dpgtc"; + + }; + pinctrl_hsi1: pinctrl@13040000 { compatible = "samsung,exynos990-pinctrl"; reg = <0x13040000 0x1000>; @@ -231,6 +249,15 @@ pinctrl_cmgp: pinctrl@15c30000 { compatible = "samsung,exynos990-pinctrl"; reg = <0x15c30000 0x1000>; }; + + cmu_top: clock-controller@1a330000 { + compatible = "samsung,exynos990-cmu-top"; + reg = <0x1a330000 0x8000>; + #clock-cells = <1>; + + clocks = <&oscclk>; + clock-names = "oscclk"; + }; }; timer { -- 2.45.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: exynos990: Add clock management unit nodes 2024-12-05 19:40 ` [PATCH v1 1/1] arm64: dts: exynos990: Add clock management unit nodes Igor Belwon @ 2024-12-06 8:36 ` Krzysztof Kozlowski 2024-12-06 11:52 ` Igor Belwon 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2024-12-06 8:36 UTC (permalink / raw) To: Igor Belwon, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel On 05/12/2024 20:40, Igor Belwon wrote: > Add CMU nodes for: > - cmu_top: provides clocks for other blocks > - cmu_hsi0: provides clocks for usb31 > > Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org> > --- > arch/arm64/boot/dts/exynos/exynos990.dtsi | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos990.dtsi b/arch/arm64/boot/dts/exynos/exynos990.dtsi > index c1986f00e443..49bb1e156843 100644 > --- a/arch/arm64/boot/dts/exynos/exynos990.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos990.dtsi > @@ -5,6 +5,7 @@ > * Copyright (c) 2024, Igor Belwon <igor.belwon@mentallysanemainliners.org> > */ > > +#include <dt-bindings/clock/samsung,exynos990.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > > / { > @@ -199,6 +200,23 @@ pinctrl_peric1: pinctrl@10730000 { > interrupts = <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>; > }; > > + cmu_hsi0: clock-controller@10a00000 { > + compatible = "samsung,exynos990-cmu-hsi0"; > + reg = <0x10a00000 0x8000>; > + #clock-cells = <1>; > + > + clocks = <&oscclk>, > + <&cmu_top CLK_DOUT_CMU_HSI0_BUS>, > + <&cmu_top CLK_DOUT_CMU_HSI0_USB31DRD>, > + <&cmu_top CLK_DOUT_CMU_HSI0_USBDP_DEBUG>, > + <&cmu_top CLK_DOUT_CMU_HSI0_DPGTC>; > + clock-names = "oscclk", "dout_cmu_hsi0_bus", One per line. > + "dout_cmu_hsi0_usb31drd", Misaligned. > + "dout_cmu_hsi0_usbdp_debug", > + "dout_cmu_hsi0_dpgtc"; > + Drop stray blank line. > + }; > + Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: exynos990: Add clock management unit nodes 2024-12-06 8:36 ` Krzysztof Kozlowski @ 2024-12-06 11:52 ` Igor Belwon 0 siblings, 0 replies; 5+ messages in thread From: Igor Belwon @ 2024-12-06 11:52 UTC (permalink / raw) To: krzk Cc: alim.akhtar, conor+dt, devicetree, igor.belwon, krzk+dt, linux-arm-kernel, linux-kernel, linux-samsung-soc, robh Hi Krzysztof Thanks for the review. I just have a question - do you prefer having the two (pmu and cmu) device tree changes spread out, or should I merge them into one patchset? Thanks and best regards Igor ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes 2024-12-05 19:40 [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes Igor Belwon 2024-12-05 19:40 ` [PATCH v1 1/1] arm64: dts: exynos990: Add clock management unit nodes Igor Belwon @ 2024-12-06 8:35 ` Krzysztof Kozlowski 1 sibling, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2024-12-06 8:35 UTC (permalink / raw) To: Igor Belwon, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel On 05/12/2024 20:40, Igor Belwon wrote: > Hi all, > > This patchset adds device tree nodes for Exynos990 CMUs (TOP and HSI0). > > This patchset is compile-time and runtime dependent on [1], which adds > driver support for CMU. > > [1] https://lore.kernel.org/linux-samsung-soc/20241205193423.783815-1-igor. > belwon@mentallysanemainliners.org/T/#t > Don't wrap links. > Igor Belwon (1): > arm64: dts: exynos990: Add clock management unit nodes > > arch/arm64/boot/dts/exynos/exynos990.dtsi | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-06 11:52 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-12-05 19:40 [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes Igor Belwon 2024-12-05 19:40 ` [PATCH v1 1/1] arm64: dts: exynos990: Add clock management unit nodes Igor Belwon 2024-12-06 8:36 ` Krzysztof Kozlowski 2024-12-06 11:52 ` Igor Belwon 2024-12-06 8:35 ` [PATCH v1 0/1] arm64: dts: exynos990: Add cmu nodes Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox