* [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER_OK
@ 2024-02-13 14:25 Steve Sistare
2024-02-13 14:58 ` Eugenio Perez Martin
0 siblings, 1 reply; 3+ messages in thread
From: Steve Sistare @ 2024-02-13 14:25 UTC (permalink / raw)
To: virtualization, linux-kernel
Cc: Michael S. Tsirkin, Jason Wang, Si-Wei Liu, Eugenio Perez Martin,
Stefano Garzarella, Steve Sistare
If a vdpa device is not in state DRIVER_OK, then there is no driver state
to preserve, so no need to call the suspend and resume driver ops.
Suggested-by: Eugenio Perez Martin <eperezma@redhat.com>"
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
drivers/vhost/vdpa.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index bc4a51e4638b..aef92a7c57f3 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -595,6 +595,9 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
const struct vdpa_config_ops *ops = vdpa->config;
int ret;
+ if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
+ return 0;
+
if (!ops->suspend)
return -EOPNOTSUPP;
@@ -615,6 +618,9 @@ static long vhost_vdpa_resume(struct vhost_vdpa *v)
const struct vdpa_config_ops *ops = vdpa->config;
int ret;
+ if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
+ return 0;
+
if (!ops->resume)
return -EOPNOTSUPP;
--
2.39.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER_OK
2024-02-13 14:25 [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER_OK Steve Sistare
@ 2024-02-13 14:58 ` Eugenio Perez Martin
2024-02-13 15:06 ` Steven Sistare
0 siblings, 1 reply; 3+ messages in thread
From: Eugenio Perez Martin @ 2024-02-13 14:58 UTC (permalink / raw)
To: Steve Sistare
Cc: virtualization, linux-kernel, Michael S. Tsirkin, Jason Wang,
Si-Wei Liu, Stefano Garzarella
On Tue, Feb 13, 2024 at 3:26 PM Steve Sistare <steven.sistare@oracle.com> wrote:
>
> If a vdpa device is not in state DRIVER_OK, then there is no driver state
> to preserve, so no need to call the suspend and resume driver ops.
>
> Suggested-by: Eugenio Perez Martin <eperezma@redhat.com>"
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
Please include a changelog from previous versions for the next series.
Thanks!
> ---
> drivers/vhost/vdpa.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index bc4a51e4638b..aef92a7c57f3 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -595,6 +595,9 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
> const struct vdpa_config_ops *ops = vdpa->config;
> int ret;
>
> + if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
> + return 0;
> +
> if (!ops->suspend)
> return -EOPNOTSUPP;
>
> @@ -615,6 +618,9 @@ static long vhost_vdpa_resume(struct vhost_vdpa *v)
> const struct vdpa_config_ops *ops = vdpa->config;
> int ret;
>
> + if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
> + return 0;
> +
> if (!ops->resume)
> return -EOPNOTSUPP;
>
> --
> 2.39.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER_OK
2024-02-13 14:58 ` Eugenio Perez Martin
@ 2024-02-13 15:06 ` Steven Sistare
0 siblings, 0 replies; 3+ messages in thread
From: Steven Sistare @ 2024-02-13 15:06 UTC (permalink / raw)
To: Eugenio Perez Martin
Cc: virtualization, linux-kernel, Michael S. Tsirkin, Jason Wang,
Si-Wei Liu, Stefano Garzarella
On 2/13/2024 9:58 AM, Eugenio Perez Martin wrote:
> On Tue, Feb 13, 2024 at 3:26 PM Steve Sistare <steven.sistare@oracle.com> wrote:
>>
>> If a vdpa device is not in state DRIVER_OK, then there is no driver state
>> to preserve, so no need to call the suspend and resume driver ops.
>>
>> Suggested-by: Eugenio Perez Martin <eperezma@redhat.com>"
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>
> Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
>
> Please include a changelog from previous versions for the next series.
>
> Thanks!
Will do, thanks - steve
>> ---
>> drivers/vhost/vdpa.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>> index bc4a51e4638b..aef92a7c57f3 100644
>> --- a/drivers/vhost/vdpa.c
>> +++ b/drivers/vhost/vdpa.c
>> @@ -595,6 +595,9 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
>> const struct vdpa_config_ops *ops = vdpa->config;
>> int ret;
>>
>> + if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
>> + return 0;
>> +
>> if (!ops->suspend)
>> return -EOPNOTSUPP;
>>
>> @@ -615,6 +618,9 @@ static long vhost_vdpa_resume(struct vhost_vdpa *v)
>> const struct vdpa_config_ops *ops = vdpa->config;
>> int ret;
>>
>> + if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
>> + return 0;
>> +
>> if (!ops->resume)
>> return -EOPNOTSUPP;
>>
>> --
>> 2.39.3
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-13 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13 14:25 [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER_OK Steve Sistare
2024-02-13 14:58 ` Eugenio Perez Martin
2024-02-13 15:06 ` Steven Sistare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox