From: Marcel Xubuntu <fooglesucks@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: wsa@the-dreams.de, linux-kernel@vger.kernel.org
Subject: Re: Fwd: Re: Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards
Date: Sun, 25 Sep 2016 13:59:18 +0200 [thread overview]
Message-ID: <7ecbe941-1b14-dba1-c23c-896300769ffd@gmail.com> (raw)
In-Reply-To: <20160925103439.GA8119@kroah.com>
On 9/25/16 12:34, Greg KH wrote:
> On Sat, Sep 24, 2016 at 06:08:34PM +0200, Marcel Xubuntu wrote:
>>
>> Code formatting and structuring.
>>
>> Signed-off-by: Marcel Ricquier <fooglesucks@gmail.com>
>>
>> ---
>>
>> Tested-by: Marcel Ricquier <fooglesucks@gmail.com>
>>
>> Mostly code formatting, unapologetically a stepping stone for a potential
>> refactoring with a knowledge seeking, following complete disclosure,
>> ultimate goal.
>> In case this fails, my backup plan is to have the world's record for the
>> quickest kernel patch dismissal, either way it's a win. Did I win ?!
>
> Why did you repeat this?
I like repeating things sometimes.
>
>> diff --git a/drivers/staging/ks7010/ks7010_sdio.c
>> b/drivers/staging/ks7010/ks7010_sdio.c
>> index b7337fd..8de2713 100644
>> --- a/drivers/staging/ks7010/ks7010_sdio.c
>> +++ b/drivers/staging/ks7010/ks7010_sdio.c
>> @@ -14,7 +14,7 @@
>> #include <linux/mmc/card.h>
>> #include <linux/mmc/sdio_func.h>
>> #include <linux/workqueue.h>
>> -#include <asm/atomic.h>
>> +#include <linux/atomic.h>
>
> Patch is corrupted and can not be applied :(
Yes, this was an exercise in reconnaissance. I don't want the name of
Ricquier correlated with some meaningless style fixing on code that is
beyond repair and provides an entry point for outsiders.
>
> Also, you didn't read the link I provided in the last review, please do
> so and fix up the patch to only do one type of a thing at a time.
> (hint, "fix all checkpatch issues" is not one thing...)
I did, see above. A real patch is outstanding.
>
> thanks,
thank you!
>
> greg k-h
>
prev parent reply other threads:[~2016-09-25 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4865f87e-83ca-62af-1ff6-63f10e3e6da7@gmail.com>
2016-09-24 16:08 ` Fwd: Re: Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards Marcel Xubuntu
2016-09-25 10:34 ` Greg KH
2016-09-25 11:59 ` Marcel Xubuntu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ecbe941-1b14-dba1-c23c-896300769ffd@gmail.com \
--to=fooglesucks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox