Re: [PATCH v9 17/23] drm/mediatek: mtk_hdmi: Split driver and add common probe function

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 16/04/25 08:44, CK Hu (胡俊光) ha scritto:
> On Tue, 2025-04-15 at 12:48 +0200, AngeloGioacchino Del Regno wrote:
>> External email : Please do not click links or open attachments until you have verified the sender or the content.
>>
>>
>> Il 15/04/25 12:43, AngeloGioacchino Del Regno ha scritto:
>>> In preparation for adding a new driver for the HDMI TX v2 IP,
>>> split out the functions that will be common between the already
>>> present mtk_hdmi (v1) driver and the new one.
>>>
>>> Since the probe flow for both drivers is 90% similar, add a common
>>> probe function that will be called from each driver's .probe()
>>> callback, avoiding lots of code duplication.
>>>
>>> Reviewed-by: CK Hu <ck.hu@mediatek.com>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>> ---
>>>    drivers/gpu/drm/mediatek/Kconfig           |   11 +-
>>>    drivers/gpu/drm/mediatek/Makefile          |    1 +
>>>    drivers/gpu/drm/mediatek/mtk_hdmi.c        |  538 +-----
>>>    drivers/gpu/drm/mediatek/mtk_hdmi.c.orig   | 1769 ++++++++++++++++++++
>>>    drivers/gpu/drm/mediatek/mtk_hdmi_common.c |  422 +++++
>>>    drivers/gpu/drm/mediatek/mtk_hdmi_common.h |  188 +++
>>>    6 files changed, 2398 insertions(+), 531 deletions(-)
>>>    create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi.c.orig
>>
>> CK, I just acknowledged that a .orig file slipped through and got sent out with
>> this patch....
>>
>> Truly sorry for that, can you please fix that up while applying without having me
>> send another patchbomb?
> 
> I would drop mtk_hdmi.c.orig when apply this patch.
> 

Very much appreciated!

Thanks again,
Angelo

> Regards,
> CK
> 
>>
>> Many thanks,
>> Angelo
>>
>>>    create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_common.c
>>>    create mode 100644 drivers/gpu/drm/mediatek/mtk_hdmi_common.h
>>>
>